Re: [Kgdb-bugreport] [PATCH v2 2/2] soc: fujitsu: Add A64FX diagnostic interrupt driver

2022-03-08 Thread hasegawa-hit...@fujitsu.com
Hi Sumit, > Would it be possible to pass a dynamic sysrq key from BMC to the host > as that would unleash the true power of sysrq in an NMI context > capable of launching kdb as one example? A64FX's BMC supports a subset of the ipmitool command but it doesn't have the ability to dynamically send

Re: [Kgdb-bugreport] [PATCH v3 1/1] soc: fujitsu: Add A64FX diagnostic interrupt driver

2022-04-08 Thread hasegawa-hit...@fujitsu.com
Hi Greg, > > Enable diagnostic interrupts for the A64FX. > > This is done using a pseudo-NMI. > > I do not understand what this driver is, sorry. Can you please provide more > information in the changelog text for what this is, who would use it, and how > it will > be interacted with. I unders

Re: [Kgdb-bugreport] [PATCH v3 1/1] soc: fujitsu: Add A64FX diagnostic interrupt driver

2022-04-19 Thread hasegawa-hit...@fujitsu.com
Hi Greg, Arnd, and Daniel, > > > > > There is some prior art for this sort of feature. AFAICT SGI UV has a > > > > > similar mechanism that can send an NMI-with-no-side-channel to the > > > > > kernel. The corresponding driver offers a range of actions using a > > > > > module parameter: > > > > >

Re: [Kgdb-bugreport] [PATCH v3 1/1] soc: fujitsu: Add A64FX diagnostic interrupt driver

2022-04-27 Thread hasegawa-hit...@fujitsu.com
Hi Greg, Arnd, and Daniel, > I understand that it is not appropriate to hardcode c. > How about using __setup() to add a new kernel parameter and allow the admin > to specify the sysrq command when booting? I have received a lot of advice regarding sysrq, but after some consideration, I would lik

Re: [Kgdb-bugreport] [PATCH v4 1/1] soc: fujitsu: Add A64FX diagnostic interrupt driver

2022-05-17 Thread hasegawa-hit...@fujitsu.com
Hi Jiri, > I'm not sure why you cc linux-serial, but anyway, comments below :). I used sysrq until the last version, so I still included kernel-serial in the destination. I am not planning to use sysrq now, so I will remove it from the destination from the next version. Thank you for your commen

Re: [Kgdb-bugreport] [PATCH v4 1/1] soc: fujitsu: Add A64FX diagnostic interrupt driver

2022-05-17 Thread hasegawa-hit...@fujitsu.com
Hi Greg, > > +obj-y += fujitsu/ > > Why a sub directory for just one .c file? As Arnd mentioned, I placed the sub directory following the convention of drivers/soc. > > + help > > + Say Y here if you want to enable diag interrupt on Fujitsu A64FX. > > + > >