[Kgdb-bugreport] [PATCH v3] kdb: remove unnecessary null check of dbg_io_ops

2020-06-30 Thread Cengiz Can
. Coverity scanner caught this as CID 1465042. I have removed the unnecessary null check and eliminated false-positive forward null dereference warning. Signed-off-by: Cengiz Can --- kernel/debug/kdb/kdb_io.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/kernel

Re: [Kgdb-bugreport] [PATCH v3] kdb: remove unnecessary null check of dbg_io_ops

2020-07-10 Thread Cengiz Can
time -- Cengiz Can @cengiz_io ___ Kgdb-bugreport mailing list Kgdb-bugreport@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport

Re: [Kgdb-bugreport] [PATCH v2] kdb: remove unnecessary null check of dbg_io_ops

2020-06-29 Thread Cengiz Can
On June 30, 2020 00:16:54 Doug Anderson wrote: Hi, On Mon, Jun 29, 2020 at 1:50 PM Cengiz Can wrote: `kdb_msg_write` operates on a global `struct kgdb_io *` called `dbg_io_ops`. It's initialized in `debug_core.c` and checked throughout the debug flow. There's a null check

[Kgdb-bugreport] [PATCH v2] kdb: remove unnecessary null check of dbg_io_ops

2020-06-29 Thread Cengiz Can
. Coverity scanner caught this as CID 1465042. I have removed the unnecessary null check and eliminated false-positive forward null dereference warning. Signed-off-by: Cengiz Can --- kernel/debug/kdb/kdb_io.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/kernel

[Kgdb-bugreport] [PATCH] kdb: prevent possible null deref in kdb_msg_write

2020-06-29 Thread Cengiz Can
have modified the function to bail out if `dbg_io_ops` is not properly initialized. Signed-off-by: Cengiz Can --- kernel/debug/kdb/kdb_io.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c index 683a799618ad

Re: [Kgdb-bugreport] [PATCH] kdb: prevent possible null deref in kdb_msg_write

2020-06-29 Thread Cengiz Can
Thanks Daniel and Petr. I will remove the check and submit v2 very soon. ___ Kgdb-bugreport mailing list Kgdb-bugreport@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport