Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-05 Thread Wayne Stambaugh
On 1/4/2011 10:31 PM, Dick Hollenbeck wrote: The previous patch has a bug. It incorrectly complains about no layers being selected. This patch works better. marco On Sun, Jan 2, 2011 at 11:40 PM, Marco Mattila marco...@gmail.com wrote: Hi, During previous discussions about subtracting

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-05 Thread Marco Mattila
Damn. I always struggle the most with the comments for Doxygen... I think that we may be able to get rid of the global variable. I'll take a look. I'll fix the comments in the next patch, too. marco On Wed, Jan 5, 2011 at 3:24 PM, Wayne Stambaugh stambau...@verizon.net wrote: This is a nice

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-05 Thread Dick Hollenbeck
On 01/05/2011 07:47 AM, Marco Mattila wrote: Damn. I always struggle the most with the comments for Doxygen... I think that we may be able to get rid of the global variable. I'll take a look. I'll fix the comments in the next patch, too. marco From a usability standpoint, i.e. user

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-05 Thread Dick Hollenbeck
From a usability standpoint, i.e. user experience, I have a concern about saving the desired layers, as if I was only ever going to work on one board. Now that you have a compact bitmap, would it make sense to prefix the Config key for layers, with the boardname? Although this might

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-05 Thread Dick Hollenbeck
On 01/05/2011 09:10 AM, Dick Hollenbeck wrote: From a usability standpoint, i.e. user experience, I have a concern about saving the desired layers, as if I was only ever going to work on one board. Now that you have a compact bitmap, would it make sense to prefix the Config key for layers,

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-05 Thread Marco Mattila
If you think that the plotting requirements vary from one project to another (the number of needed technical layers maybe?), saving them outside the config system makes sense. Since there can be multiple boards in a project, maybe the SETUP section of a board file is the correct place for this. I

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-05 Thread Dick Hollenbeck
On 01/05/2011 11:23 AM, Marco Mattila wrote: If you think that the plotting requirements vary from one project to another (the number of needed technical layers maybe?), saving them outside the config system makes sense. Since there can be multiple boards in a project, maybe the SETUP section

Re: [Kicad-developers] [PATCH] wxWidgets 2.8 under Graphics Abstraction Layer Lib (GAL)

2011-01-05 Thread Torsten Hüter
Hi Dick, You have twice as many in a std::list, I will use std::deque. Its ten minutes to change it. Yes, I agree - this was just an initial choice - I've changed some types already to std::vector but the std::deque is also a good idea. std::vector is better than std::list.