I noticed that in 3d-viewer the file menu has thin items and exit icon has
small size (less than standard 26x26). It happens because in file menu the
items added by using Append method but must be used AddMenuItem method. So
I changed it and added some icons for the items of export and copy
Le 27/07/2015 14:10, Константин Барановский a écrit :
I noticed that in 3d-viewer the file menu has thin items and exit icon has
small size (less than standard 26x26). It happens because in file menu the
items added by using Append method but must be used AddMenuItem method. So
I changed it
On Jul 26, 2015, at 2:08 AM, Marco Ciampa ciam...@libero.it wrote:
Coming home after long due holydays, I see this:
On Mon, Jul 06, 2015 at 08:37:24AM -0700, Andy Peters wrote:
I am glad to help out with docs. If someone would be so kind as to
point me in the right direction, I’ll do
Hi,
three small patches for include files cleanup, each of them pretty
self-explanatory.
Simon
Simon Richter (3):
Remove superfluous includes
Include iso646.h for not, and and or keywords
add missing C++ stdlib headers
common/gal/graphics_abstraction_layer.cpp | 2 ++
These are unnecessary:
- in math_util.cpp, including stdint.h is unnecessary because math_util.h
already requires it
- in the other two headers, no definitions from stdint.h are used.
---
common/math/math_util.cpp | 1 -
include/layers_id_colors_and_visibility.h | 1 -
These source files use definitions from the standard library without making
sure they are included. It happens to work on current gcc because parts of
the standard library implicitly include these other headers, but that is
not guaranteed.
---
common/gal/graphics_abstraction_layer.cpp | 2
These are not actually keywords in the C++ standard, but macros. Unless
iso646.h is included, these are not guaranteed to be present.
---
include/common.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/common.h b/include/common.h
index b881444..8be1e25 100644
---
This macro is defined in stddef.h, so cstddef is needed.
---
include/gal/opengl/vertex_common.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/gal/opengl/vertex_common.h b/include/gal/opengl/vertex_common.h
index 9ec8d9b..0d8eb9d 100644
--- a/include/gal/opengl/vertex_common.h
+++
fabs(int) is not defined in the standard, so this is ambiguous. Moving the
cast inside the argument clarifies which overload we want, and gives the
correct return type.
---
common/geometry/shape_poly_set.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Hi,
this repairs const correctness for some STL container accesses:
- The result of .begin() and .end() on a const reference is a const_iterator.
- The .erase() function requires a mutable iterator.
The GNU C++ stdlib actually uses the same type here, because set members
may not be manipulated
Hi,
that function returns a bool, but common/geometry/shape_poly_set.cpp
line 704-705 has
if( !d )
return -1;
That smells fishy and gives a compiler warning.
Simon
signature.asc
Description: OpenPGP digital signature
Hi,
the MSVC build complains:
pcbnew\router\pns_tool_base.h(37) : warning C4275: non dll-interface
class 'TOOL_INTERACTIVE' used as base for dll-interface class
'PNS_TOOL_BASE'
include\tool/tool_interactive.h(35) : see declaration of 'TOOL_INTERACTIVE'
pcbnew\router\pns_tool_base.h(36) : see
Hi,
On 28.07.2015 06:32, Mark Roszko wrote:
What? Those keywords are part of the C++ standard from 2003(at least).
Its only MSVC that is backwards and broken in this regard.
Ah okay, then I misremembered that. Well, I've only used them once in
'99, and back then I needed the header.
Simon
What? Those keywords are part of the C++ standard from 2003(at least).
Its only MSVC that is backwards and broken in this regard.
They are not part of the C standards and thats why iso646.h exists
for those hipsters with non-qwerty keyboards (I joke)
14 matches
Mail list logo
