Re: [Kicad-developers] [PATCH] Fix Touchpad Panning Regressions

2016-02-26 Thread Wayne Stambaugh
On 2/26/2016 11:11 AM, Bernhard Stegmaier wrote: > Fix 3d-viewer regressions introduced by touchpad-panning for > non-touchpad-panning: > * Fix broken horizontal scrolling with ctrl-wheel > * Restore previous step size Patch committed in product branch r6593. Thanks.

[Kicad-developers] [PATCH 6/8] Use ptrdiff_t in potrace instead of ssize_t

2016-02-26 Thread Simon Richter
This is backported from potrace 1.13. --- potrace/bitmap.h| 15 --- potrace/greymap.cpp | 2 +- potrace/greymap.h | 3 ++- 3 files changed, 11 insertions(+), 9 deletions(-) diff --git a/potrace/bitmap.h b/potrace/bitmap.h index 605aa31..059fb2b 100644 --- a/potrace/bitmap.h

[Kicad-developers] [PATCH 5/8] Open namespace around definitions

2016-02-26 Thread Simon Richter
While defining functions in another namespace is technically allowed as long as the definition can be matched to a declaration, this can lead to ambiguous resolutions, such as here (GAL vs KIGFX). --- pcbnew/ratsnest_viewitem.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[Kicad-developers] [PATCH 7/8] Avoid C99 style compound statement

2016-02-26 Thread Simon Richter
Support for C99 in C++ programs is a gcc extension. --- eeschema/autoplace_fields.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/eeschema/autoplace_fields.cpp b/eeschema/autoplace_fields.cpp index 4d97cd8..07c1002 100644 --- a/eeschema/autoplace_fields.cpp +++

[Kicad-developers] [PATCH 8/8] Avoid conflicting declaration for Pgm()

2016-02-26 Thread Simon Richter
This function has two conflicting definitions in the "kicad" executable and the other wrapper programs. As the kifaces can be loaded from either, this silently assumes compatible data layout for the PGM_KICAD and PGM_BASE types when passed by reference, which is valid only when the compiler is

[Kicad-developers] [PATCH 3/8] Use PATH to search for shared libraries on Windows

2016-02-26 Thread Simon Richter
This is appropriate for all Windows targets, not just MSYS. --- include/kiway.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/kiway.h b/include/kiway.h index 406ab91..347c0bb 100644 --- a/include/kiway.h +++ b/include/kiway.h @@ -118,8 +118,10 @@ as such! As

[Kicad-developers] [PATCH 2/8] Use Windows-style DLL import/export for all Windows compilers

2016-02-26 Thread Simon Richter
This should be used whenever Windows is targetted, not just for MSYS. --- include/import_export.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/import_export.h b/include/import_export.h index c31729e..672709f 100644 --- a/include/import_export.h +++

[Kicad-developers] [PATCH 4/8] Add missing C++ stdlib headers

2016-02-26 Thread Simon Richter
The GCC standard library headers often include other headers, which makes some code compile that forgets to include several headers. --- common/gal/graphics_abstraction_layer.cpp | 2 ++ common/grid_tricks.cpp | 2 ++ common/selcolor.cpp|

[Kicad-developers] [PATCH 1/8] Make locale init counter unsigned

2016-02-26 Thread Simon Richter
This counts initializations of the locale subsystem, there is no real good reason why this should be a signed variable. --- common/common.cpp | 2 +- include/common.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/common.cpp b/common/common.cpp index

[Kicad-developers] [PATCH 3/5] Refactor ELECTRICAL_PINTYPE

2016-02-26 Thread Simon Richter
- Move to separate header - Move UI text and bitmap lookups out of LIB_PIN - Move widget init code out of dialog, into own widget class --- eeschema/CMakeLists.txt | 2 + eeschema/dialogs/dialog_erc.cpp | 18 ++-- eeschema/dialogs/dialog_erc.h

[Kicad-developers] [PATCH 4/5] Use TypeSheetLabel enum where appropriate

2016-02-26 Thread Simon Richter
--- eeschema/dialogs/dialog_edit_label.cpp | 3 ++- eeschema/dialogs/dialog_sch_edit_sheet_pin.h | 8 ++-- eeschema/edit_label.cpp | 8 eeschema/sch_sheet_pin.cpp | 2 +- eeschema/sch_text.cpp| 4 ++--

[Kicad-developers] [PATCH 5/5] Add icon to pin type column

2016-02-26 Thread Simon Richter
--- eeschema/dialogs/dialog_lib_edit_pin_table.cpp | 51 -- 1 file changed, 47 insertions(+), 4 deletions(-) diff --git a/eeschema/dialogs/dialog_lib_edit_pin_table.cpp b/eeschema/dialogs/dialog_lib_edit_pin_table.cpp index 369a227..047f737 100644 ---

[Kicad-developers] [PATCH 2/5] Refactor DrawPinShape

2016-02-26 Thread Simon Richter
DrawPinShape is a bitmask, where only a limited set of values is valid. - Replace this with an enum that contains exactly the allowed values - Move UI text and bitmap lookups out of LIB_PIN - Move widget init code out of dialog, into own widget class --- eeschema/CMakeLists.txt

[Kicad-developers] [PATCH 0/5] Enum refactoring and shiny icons

2016-02-26 Thread Simon Richter
Hi, this refactors two enum types, ELECTRICAL_PINTYPE and DrawPinShape (which becomes GRAPHIC_PINSHAPE): 1. Move enum to separate header file, out of lib_pin.h. 2. Move UI text and bitmap lookup out of LIB_PIN (end goal: no UI code in data structures) 3. Create separate widget class for use

[Kicad-developers] [PATCH 1/5] Fix typo

2016-02-26 Thread Simon Richter
--- eeschema/lib_pin.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eeschema/lib_pin.h b/eeschema/lib_pin.h index 51f5f58..15d5412 100644 --- a/eeschema/lib_pin.h +++ b/eeschema/lib_pin.h @@ -277,7 +277,7 @@ public: /** * Get the electrical type of the pin.

Re: [Kicad-developers] Serious issue after updating msys2 (32 bits)

2016-02-26 Thread Nick Østergaard
FWIW, some discussion related to this issue is happening on https://github.com/Alexpux/MINGW-packages/issues/1104#issuecomment-189141900 2016-02-26 17:51 GMT+01:00 Wayne Stambaugh : > On 2/26/2016 11:50 AM, Nick Østergaard wrote: >> 2016-02-26 17:20 GMT+01:00 Wayne Stambaugh

Re: [Kicad-developers] [PATCH] fix position of text and refdes from PCAD import

2016-02-26 Thread Eldar Khayrullin
Add patch for carret return symbol in text > On Feb 25 2016, at 10:36 pm, Eldar Khayrullin eldar.khayrul...@mail.ru wrote: Next I will fix some other import bugs: > > * carret return symbol \r - ? > * size and proportional of text > * etc > >> On Feb 25 2016, at 10:30 pm, Eldar

Re: [Kicad-developers] gerbview/options.cpp

2016-02-26 Thread jp charras
Le 26/02/2016 18:06, Simon Wells a écrit : > Can gerbview/options.cpp be removed? it hasn't been touch since mid > 2012 and is not currently built nor used, It seems to have been > replaced with events_called_functions.cpp > > Simon > Yes. -- Jean-Pierre CHARRAS

[Kicad-developers] gerbview/options.cpp

2016-02-26 Thread Simon Wells
Can gerbview/options.cpp be removed? it hasn't been touch since mid 2012 and is not currently built nor used, It seems to have been replaced with events_called_functions.cpp Simon ___ Mailing list: https://launchpad.net/~kicad-developers Post to :

Re: [Kicad-developers] Serious issue after updating msys2 (32 bits)

2016-02-26 Thread Wayne Stambaugh
On 2/26/2016 11:50 AM, Nick Østergaard wrote: > 2016-02-26 17:20 GMT+01:00 Wayne Stambaugh : >> On 2/26/2016 5:05 AM, jp charras wrote: >>> Le 25/02/2016 21:59, Wayne Stambaugh a écrit : On 2/25/2016 3:50 PM, jp charras wrote: >>> ... >> On 2/25/2016 3:33 PM, Wayne

Re: [Kicad-developers] Serious issue after updating msys2 (32 bits)

2016-02-26 Thread Nick Østergaard
2016-02-26 17:20 GMT+01:00 Wayne Stambaugh : > On 2/26/2016 5:05 AM, jp charras wrote: >> Le 25/02/2016 21:59, Wayne Stambaugh a écrit : >>> On 2/25/2016 3:50 PM, jp charras wrote: >> ... > On 2/25/2016 3:33 PM, Wayne Stambaugh wrote: >> Yep! I just confirmed this.

Re: [Kicad-developers] Serious issue after updating msys2 (32 bits)

2016-02-26 Thread jp charras
Le 26/02/2016 17:20, Wayne Stambaugh a écrit : > On 2/26/2016 5:05 AM, jp charras wrote: >> Le 25/02/2016 21:59, Wayne Stambaugh a écrit : >>> On 2/25/2016 3:50 PM, jp charras wrote: >> ... > On 2/25/2016 3:33 PM, Wayne Stambaugh wrote: >> Yep! I just confirmed this. It must have been

Re: [Kicad-developers] Serious issue after updating msys2 (32 bits)

2016-02-26 Thread Wayne Stambaugh
On 2/26/2016 5:05 AM, jp charras wrote: > Le 25/02/2016 21:59, Wayne Stambaugh a écrit : >> On 2/25/2016 3:50 PM, jp charras wrote: > ... On 2/25/2016 3:33 PM, Wayne Stambaugh wrote: > Yep! I just confirmed this. It must have been the mingw32 updates that > were just released. I'm

[Kicad-developers] [PATCH] Fix Touchpad Panning Regressions

2016-02-26 Thread Bernhard Stegmaier
Hi, attached patch: Fix 3d-viewer regressions introduced by touchpad-panning for non-touchpad-panning: * Fix broken horizontal scrolling with ctrl-wheel * Restore previous step size Sorry for the inconvenience. Regards, Bernhard fix-3d-tp-regr.patch Description: Binary data > On

Re: [Kicad-developers] 3D-Viewer feature proposal: display of the 3D Shapes based on Attributes of the footprint

2016-02-26 Thread jp charras
Le 26/02/2016 14:03, Mário Luzeiro a écrit : > Hello again, > > Could someone clarify this: > https://github.com/KiCad/kicad-source-mirror/blob/a356293fee05b5a48853a3bb1c0d565f846113e6/pcbnew/class_module.h#L64 > * Enum MODULE_ATTR_T > * is the set of attributes allowed within a MODULE, using

Re: [Kicad-developers] 3D-Viewer feature proposal: display of the 3D Shapes based on Attributes of the footprint

2016-02-26 Thread Mário Luzeiro
Hello again, Could someone clarify this: https://github.com/KiCad/kicad-source-mirror/blob/a356293fee05b5a48853a3bb1c0d565f846113e6/pcbnew/class_module.h#L64 * Enum MODULE_ATTR_T * is the set of attributes allowed within a MODULE, using MODULE::SetAttributes() * and MODULE::GetAttributes().

Re: [Kicad-developers] Python functionality on Windows

2016-02-26 Thread Miguel Angel Ajo Pelayo
I understand the issue with dependencies. I don’t have a windows but, has anybody tried easy_install ? https://pythonhosted.org/setuptools/easy_install.html It’s supposed to be lighter than pip, I’m not sure if it comes with the base

Re: [Kicad-developers] Serious issue after updating msys2 (32 bits)

2016-02-26 Thread jp charras
Le 25/02/2016 21:59, Wayne Stambaugh a écrit : > On 2/25/2016 3:50 PM, jp charras wrote: ... >>> On 2/25/2016 3:33 PM, Wayne Stambaugh wrote: Yep! I just confirmed this. It must have been the mingw32 updates that were just released. I'm not sure which package is at fault. I guess we

Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

2016-02-26 Thread Simon Wells
fair enough, In case you missed it wx 3.1 has been announced for release on 29/02, however this probably won't mean much until 3.2 is out as it seems they follow the old linux numbering where odd minor is not stable On Fri, Feb 26, 2016 at 9:30 PM, Bernhard Stegmaier

Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

2016-02-26 Thread Mário Luzeiro
yes it is on 3d-viewer. Everytime I scroll the y coordinate "jumps" in 6 steps. It is not usable for me :/ Mario From: Bernhard Stegmaier [stegma...@sw-systems.de] Sent: 26 February 2016 06:40 To: Mário Luzeiro Cc: Wayne Stambaugh; KiCad Developers

Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning

2016-02-26 Thread Bernhard Stegmaier
I guess the other gestures would have to be covered by wxWidgets in a way similar to pinch-to-zoom. You can have a look here: http://docs.wxwidgets.org/trunk/classwx_mouse_event.html wxWidgets recently added the EVT_MAGNIFY for pinch-to-zoom, but apparently they didn't yet think of