[Kicad-developers] PATCH: bug #1585714

The attached patch *should* fix bug #1585714. Although I haven't tested on MSWin, I have checked the function which was returning the false negative and confirmed that the implementation of the wxFileName::GetForbiddenChars() would return the path separator and cause the false negative described

Re: [Kicad-developers] [PATCH 07/12] Work around VC++ 2015 bug.

I thought this was fixed in VS 2015 Update 2 released in March. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help :

[Kicad-developers] [PATCH 5/5] Add script for generating icons under resources/linux/mime/icons

Quick and dirty script gathers the original SVG icons from the bitmaps_png folder and generates bitmaps at several sizes named according to the mime type or application name. To get the names, the script reads the kicad-kicad.xml mime package and the application .desktop files, reconciling both

[Kicad-developers] [PATCH 0/5] Cleanup and fixes in the Linux desktop integration files (version 2)

This series fixes bug #1583569[1] where it was reported that pcbnew files have the wrong extension in the mime package. When I looked deeper into it I found out that there were many other things wrong with the desktop integration files for Linux, from wrong mimetype names, inconsistent desktop

[Kicad-developers] [PATCH 1/5] Fix pcbnew extension and mimetype in MIME XML package file

This file registers the file extensions used by kicad and their corresponding mimetypes. Before this change the file was refering to the old .brd extension and the wrong mime type. The file was also renamed to kicad-kicad.xml to conform to the XDG spec which expects a vendor-product pair as the

Re: [Kicad-developers] [PATCH 2/2] Remove redundant old copy of cimage class

Hi Jean-Pierre, The patch is good; "cimage" provides all the functions of "CImage" plus a few more. The older "CImage" should have been removed with the introduction of the 3D plugin system but I overlooked it. - Cirilo On Sun, May 29, 2016 at 6:11 PM, jp charras

Re: [Kicad-developers] [PATCH] GAL: Fix offset problem in multiline text rendering

Pushed in 6852. Thank you On Sun, May 29, 2016 at 04:34:30PM -0500, José Ignacio Romero wrote: > > Commit BZR 6703 introduced a minor horizontal adjustment for stroke > text rendering in GAL, but the Translate() call was done before > calling Save(). So, when this function was called multiple

[Kicad-developers] [PATCH] GAL: Fix offset problem in multiline text rendering

Commit BZR 6703 introduced a minor horizontal adjustment for stroke text rendering in GAL, but the Translate() call was done before calling Save(). So, when this function was called multiple times a residual offset carried over to each subsequent line. --- common/gal/stroke_font.cpp | 5 +++-- 1

Re: [Kicad-developers] [PATCH 07/12] Work around VC++ 2015 bug.

I agree, it's ugly. I like portability, I happily commit things that reduce dependency on gcc as they can save us trouble down the road and _also_ often make the code cleaner. But I really do not like the idea of making things ugly to shut up a specific buggy compiler that we mostly don't use.

Re: [Kicad-developers] mode openGL issues after latest updates

Le 09/05/2016 à 17:20, Maciej Sumiński a écrit : > On 05/05/2016 02:26 PM, jp charras wrote: >> Hi, Orson. >> >> I made a few tests: >> >> The crash happens in OPENGL_GAL::~OPENGL_GAL(). >> >> Exactly when executing delete OPENGL_GAL::glContext; >> >> if I comment the 2 lines >> delete

Re: [Kicad-developers] [PATCH 08/12] windows: provide performance measurement primitives

Yea QueryPerformanceCounter is the correct Windows way to do things. Though I wonder why wxStopWatch isn't used for profiling since everything is wxWidgets based anyway..wxStopWatch uses QueryPerformanceCounter on windows too. On Fri, May 27, 2016 at 10:32 AM, Simon Richter

Re: [Kicad-developers] [PATCH 07/12] Work around VC++ 2015 bug.

I really don't like this patch. It is clearly to fix an issue with the MSVC compiler. I would feel the same way about any other compiler as well. We should not have to jump through hoops to support every broken compiler. I still see no reason to change the policy to support MSVC or any other

Re: [Kicad-developers] [PATCH 2/2] Remove redundant old copy of cimage class

No problem, I'll look into this and report back. - Cirilo On Sun, May 29, 2016 at 6:11 PM, jp charras wrote: > Le 26/05/2016 à 08:54, Simon Richter a écrit : > > > > The same class is defined below the 3d_rendering/ directory as well, with > > more functionality. > >

Re: [Kicad-developers] [PATCH 2/2] Remove redundant old copy of cimage class

Le 26/05/2016 à 08:54, Simon Richter a écrit : > > The same class is defined below the 3d_rendering/ directory as well, with > more functionality. > --- > 3d-viewer/3d_draw.cpp| 2 +- > 3d-viewer/3d_draw_board_body.cpp | 2 +- > 3d-viewer/CImage.cpp | 440 >

Re: [Kicad-developers] PATCH: 3D resolver

I have attached the resolver patch made against rev 6850. You're right - the fix for the reported problem is not in this patch; I seem to have lost that patch somehow. I will look into it and fix it as soon as I can. - Cirilo On Sun, May 29, 2016 at 5:42 PM, jp charras

Re: [Kicad-developers] PATCH: 3D resolver

Le 29/05/2016 à 03:28, Cirilo Bernardo a écrit : > I accidentally sent this patch only to Wayne when I meant to send it to > the list as well. > > The attached patch fixes the issues with environment expansion by > using common.cpp ExpandEnvVarSubstitutions() to ensure > threadsafe invocation of