Re: [Kicad-developers] [PATCH 13/16] Avoid static variable in wire merge

Patch committed in product branch r6951. Thanks. On 6/27/2016 2:36 PM, Simon Richter wrote: > Hi Wayne, > > On 27.06.2016 20:21, Wayne Stambaugh wrote: > >> This patch and 0014-Reserve-appropriate-space-in-local-vector.patch have >> been committed to the product branch r6950. > > I have an

Re: [Kicad-developers] [PATCH] Fix memory leaks with improper wxBaseConfig* usage (model ownership and ownership-transfer with std::unique_ptr)

Hi, On 28.06.2016 00:30, Michael Steinberg wrote: >>> -wxConfigBase* config = GetNewConfig( fn.GetFullPath() ); >>> +auto config = GetNewConfig( fn.GetFullPath() ); >>> config->Write( HOTKEYS_CONFIG_KEY, msg ); >>> -delete config; >> This has subtle potential

Re: [Kicad-developers] [PATCH] Fix memory leaks with improper wxBaseConfig* usage (model ownership and ownership-transfer with std::unique_ptr)

-wxConfigBase* config = GetNewConfig( fn.GetFullPath() ); +auto config = GetNewConfig( fn.GetFullPath() ); config->Write( HOTKEYS_CONFIG_KEY, msg ); -delete config; This has subtle potential for errors -- while I'm normally in favour of using "auto", spelling it

Re: [Kicad-developers] [PATCH] Fix memory leaks with improper wxBaseConfig* usage (model ownership and ownership-transfer with std::unique_ptr)

On 27.06.2016 23:47, Michael Steinberg wrote: > === modified file 'bitmap2component/bitmap2cmp_gui.cpp' > --- bitmap2component/bitmap2cmp_gui.cpp 2016-06-08 06:32:01 + > +++ bitmap2component/bitmap2cmp_gui.cpp 2016-06-27 19:02:56 + [...] > +// TODO: Should the config

[Kicad-developers] [PATCH] Fix memory leaks with improper wxBaseConfig* usage (model ownership and ownership-transfer with std::unique_ptr)

=== modified file 'bitmap2component/bitmap2cmp_gui.cpp' --- bitmap2component/bitmap2cmp_gui.cpp 2016-06-08 06:32:01 + +++ bitmap2component/bitmap2cmp_gui.cpp 2016-06-27 19:02:56 + @@ -80,7 +80,7 @@ wxStringm_ConvertedFileName; wxSize m_frameSize; wxPoint

Re: [Kicad-developers] Announcement, CERN trip.

On Mon, Jun 27, 2016 at 8:08 PM, Wayne Stambaugh wrote: > I believe you need to be either a student or a professor to stay at the > CERN hostel. You need to contact CERN directly for more information > about staying at the hostel. Javier may be able to help out on that >

[Kicad-developers] [PATCH 3/5] Check sorting of netlist during ERC

The ERC code depends on netlist items to be sorted by net code, so verify that in debug builds. While this condition is stricter than necessary, it should still hold with the current code, and provide a good canary if a change to the sorting code might break ERC. ---

[Kicad-developers] [PATCH 2/5] Cache netlist item during ERC

This adds a suffix "Idx" to the indexes into the list, and introduces local copies of the pointers to the objects we are looking at, in order to have a shorter way of addressing them. --- eeschema/dialogs/dialog_erc.cpp | 30 -- 1 file changed, 16 insertions(+), 14

[Kicad-developers] [PATCH 4/5] Drop extra copy ctors from IFSG_NODE

This is unnecessary -- explicitly specifying the regular copy ctor will inhibit any generated versions anyway. --- include/plugins/3dapi/ifsg_node.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/plugins/3dapi/ifsg_node.h b/include/plugins/3dapi/ifsg_node.h index 6b3641e..f949c80

[Kicad-developers] [PATCH 5/5] Replace boost::shared_ptr with std::shared_ptr

This is a simple 1:1 replacement for all cases where shared_ptr is not used to point at an array (array handling is not in C++11). --- 3d-viewer/3d_mesh_model.h | 4 ++-- common/gal/opengl/opengl_gal.cpp | 2 +- common/geometry/hetriang.cpp | 34

[Kicad-developers] [PATCH 1/5] Clarify ERC: we're iterating netlist items, not nets

This renames the "net", "lastNet" and "nextNet" variables to "item", "lastItem" and "nextItem", respectively, because these refer to netlist items, not nets. --- eeschema/dialogs/dialog_erc.cpp | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git

Re: [Kicad-developers] [PATCH 03/16] Clarify ERC: we're iterating netlist items, not nets

This patch and patches 0005 and 0006 of this patch set do not apply cleanly. Please rebase and resubmit them when you get a chance. FYI, the coding policy frowns upon mixing camel case and underscores. I know there are cases of this in the code but they are most likely left over from before the

Re: [Kicad-developers] [PATCH 13/16] Avoid static variable in wire merge

Hi Wayne, On 27.06.2016 20:21, Wayne Stambaugh wrote: > This patch and 0014-Reserve-appropriate-space-in-local-vector.patch have > been committed to the product branch r6950. I have an even better implementation by now, using std::min and std::max, that I posted a few days later. That patch,

Re: [Kicad-developers] [PATCH 13/16] Avoid static variable in wire merge

This patch and 0014-Reserve-appropriate-space-in-local-vector.patch have been committed to the product branch r6950. FYI, U fixed a coding policy violation. The line: candidates.reserve(4); should read: candidates.reserve( 4 ); Also, please update the copy right date as needed when modifying

Re: [Kicad-developers] Announcement, CERN trip.

On 6/27/2016 1:37 PM, Simon Richter wrote: > Hi, > > Wayne Stambaugh wrote: > >> I'm am excited to announce that I will be traveling to CERN to spend a > full week working on KiCad. I will arrive in Geneva on Saturday, July > 2nd and return on Sunday, July 10th. If anyone in that part of the >

[Kicad-developers] Announcement, CERN trip.

Hi, Wayne Stambaugh wrote: > I'm am excited to announce that I will be traveling to CERN to spend a full week working on KiCad. I will arrive in Geneva on Saturday, July 2nd and return on Sunday, July 10th. If anyone in that part of the world can find the time to get together, please let me

Re: [Kicad-developers] Remove curl dependency if github plugin not enabled

Patch committed in product branch r6949. Thanks. On 6/17/2016 6:24 PM, Simon Wells wrote: > Simple patch to if the required curl dependency in cmake if the github > plugin is disabled > > > > ___ > Mailing list: