[Kicad-developers] LIB_PART weak_ptr-technique

2016-07-04 Thread Michael Steinberg
Hello, in anticipation of the eeschema rework I'm looking through the source base to get a feeling for the current data model. A year or two ago I filed a bug report regarding the "weak_ptr"-technique that LIB_PART is using. The offending line reads: PART_SPTR m_me;

[Kicad-developers] [PATCH]v3 Fix memory leaks with improper wxBaseConfig* usage (model ownership and ownership-transfer with std::unique_ptr)

2016-07-04 Thread Michael Steinberg
Finally I catched up. Attached v3 of the patch, the auiManager part is removed. Sorry for misinterpreting the comments. Michael >From 46886bcccbbd4d99faaec9f374a1a5d1d5413c95 Mon Sep 17 00:00:00 2001 From: decimad Date: Tue, 5 Jul 2016 02:31:04 +0200 Subject: [PATCH] Fix

[Kicad-developers] Regarding [PATCH] refactor_profile.patch

2016-07-04 Thread Michael Steinberg
I was made aware that MinGW's implementation of std::chrono might be lacking, but my testbed is not including that yet, so I cannot double-check the implementation. Please see this as a motivation to hold the patch back or check MinGW. I'm sorry for the noise. Michael

[Kicad-developers] [PATCH] remove_boost_thread_dependency.patch

2016-07-04 Thread Michael Steinberg
Please excuse my stupidity #2. Remove dependency on boost::thread. >From b7e21ab681ba1ba27fb14c615838e7368f8eb58e Mon Sep 17 00:00:00 2001 From: decimad Date: Sat, 2 Jul 2016 04:37:40 +0200 Subject: [PATCH] remove boost::thread dependency --- CMakeLists.txt|

[Kicad-developers] [PATCH] refactor_profile.patch

2016-07-04 Thread Michael Steinberg
Please excuse my stupidity. Refactor profile code to use std::chrono instead of posix extensions. >From ddfcfece2ff1e8a7eb9d0f75806dce0da3196381 Mon Sep 17 00:00:00 2001 From: decimad Date: Sat, 2 Jul 2016 04:38:16 +0200 Subject: [PATCH] refactor profiling code to use

[Kicad-developers] [patch] refactor_profile.patch

2016-07-04 Thread Michael Steinberg
This patch reworks the profiling code in terms of std::chrono instead of relying on posix extensions. 0001-fix-overlength-string-literals.patch 0002-fix-for-msvc-only-supporting-OpenMP-v2.5.patch 0003-fix-object-slicing-bug-introduced-by-the-clone-seman.patch

[Kicad-developers] [PATCH] remove_boost_thread_dependency.patch

2016-07-04 Thread Michael Steinberg
This patch removes the dependency on boost::thread. 0001-refactor-profiling-code-to-use-std-chrono-instead-of.patch 0002-fix-overlength-string-literals.patch 0003-fix-for-msvc-only-supporting-OpenMP-v2.5.patch 0004-fix-object-slicing-bug-introduced-by-the-clone-seman.patch

Re: [Kicad-developers] 3D file name entry are doubled

2016-07-04 Thread Mário Luzeiro
It works now, thanks! Updated it on my branch too.. Mario From: jp charras [jp.char...@wanadoo.fr] Sent: 04 July 2016 17:24 To: Mário Luzeiro; kicad-developers@lists.launchpad.net Subject: Re: [Kicad-developers] 3D file name entry are doubled Le

Re: [Kicad-developers] 3D file name entry are doubled

2016-07-04 Thread jp charras
Le 04/07/2016 à 18:03, Mário Luzeiro a écrit : > Hi JP, > :) > > I checked the latest versions: > > 6962 <-- issue introduced here. The bug should be fixed in revision 6964. Sorry for this bug. -- Jean-Pierre CHARRAS ___ Mailing list:

Re: [Kicad-developers] 3D file name entry are doubled

2016-07-04 Thread Mário Luzeiro
Hi JP, :) I checked the latest versions: 6962 <-- issue introduced here. 6961.2.1 - works 6961.1.1 - works 6961 - works 6959 - works 6957 - works 6956 - works I didn't find anything suspicious in the source code, but it looks to be some kind of "double UI initialization" ? I was more afraid

Re: [Kicad-developers] 3D file name entry are doubled

2016-07-04 Thread jp charras
Le 04/07/2016 à 15:26, Mário Luzeiro a écrit : > Hi all, > > Maurice was testing my branch and find the following bug (see below). > I tested it with the main kicad branch and I experience the same issue. > > Additional, if you press OK and then edit again the footprint, you will > notice all

Re: [Kicad-developers] [PATCH] Menu text consistency

2016-07-04 Thread Fabrizio Tappero
Hi Simon, hum... I see. If we look at very cool tools like inkscape, they do have these types of icons (toggle icons) and the tooltip does still contain the verb Set. just my 2c cheers Fabrizio On Mon, Jul 4, 2016 at 10:55 AM, Simon Wells wrote: > The problem with changing

Re: [Kicad-developers] [PATCH] Menu text consistency

2016-07-04 Thread Simon Wells
The problem with changing the units icon tooltips is they actually are not only Set Units to blah they are also showing which one is selected by which one is active On Mon, Jul 4, 2016 at 8:22 PM, Fabrizio Tappero wrote: > Hello, > the Part Library Editor top File

[Kicad-developers] [PATCH] Menu text consistency

2016-07-04 Thread Fabrizio Tappero
Hello, the Part Library Editor top File Menu is File - Current Library Generally speaking I think it is missing the action verb and I would propose to change this entry in File - Set Current Library Following the same idea I would like to propose to change the following icon tool tips Units