Re: [Kicad-developers] Patch: Open Datasheet in Project Dir

2017-06-06 Thread Cheng Sheng
Ah, sorry for the error. Just happened to have the whole OS clean-reinstalled so didn't config Vim to get rid of all tabs. On 6 June 2017 at 14:54, Wayne Stambaugh wrote: > Cheng, > > I committed you patch to the master branch. Thank you for making the > changes I

Re: [Kicad-developers] [PATCH] Speed improvement for Duplicate functionality

2017-06-06 Thread Wayne Stambaugh
Orson, Are you still out there? I haven't heard from you in a while. Would you please take a look at this patch when you get a chance. It looks reasonable to me but you are the resident expert on the new tool framework. Thanks, Wayne On 6/5/2017 5:59 AM, Jean-Samuel Reynaud wrote: > Hi, >

Re: [Kicad-developers] BOM component table dialog (quasi-)modality in osx

2017-06-06 Thread Wayne Stambaugh
Hey Dan, I committed your patch to the master branch. Thank you for your contribution to KiCad. Cheers, Wayne On 6/6/2017 12:31 PM, Dan Green wrote: > Hi Wayne, here’s the patch. > > I appreciate your comments about the confusion over quasi-modal boxes. > In the future, what would be a good

Re: [Kicad-developers] pull default PDF viewer

2017-06-06 Thread Wayne Stambaugh
On 6/6/2017 4:17 AM, Fabrizio Tappero wrote: > ​Apologies for presenting this problem again and again > > I think this topic came up too many times but (on my linux system) the > default PDF viewer is not pulled correctly by kiCad. From the terminal: > > $ cat

Re: [Kicad-developers] [RFC] Standard field for manufacturer part number in schematic symbols

2017-06-06 Thread Wayne Stambaugh
I feel the same way. My guess is that some of this is new users coming from other EDA apps that provide default fields which we do not provide. I personally would rather let users configure fields in the way that works best for them rather than the KiCad project forcing defaults upon them. On

Re: [Kicad-developers] [RFC] Standard field for manufacturer part number in schematic symbols

2017-06-06 Thread Wayne Stambaugh
On 6/6/2017 12:51 PM, Kristoffer Ödmark wrote: > The main reason for the discussion ( From what i gather ) is that > external tools then have a field they know will be there and can all > gather around, since they know what it is called. > > I dont really think it needs to be hardcoded as such,

Re: [Kicad-developers] [RFC] Standard field for manufacturer part number in schematic symbols

2017-06-06 Thread Bernhard Stegmaier
And why shouldn’t just make all those external tools the field names they look for make configurable on their end? Instead of trying to satisfy them all with one field defined on KiCad side? I guess someone who wants to setup a serious BOM workflow should be able to configure field names on both

Re: [Kicad-developers] [RFC] Standard field for manufacturer part number in schematic symbols

2017-06-06 Thread Kristoffer Ödmark
The main reason for the discussion ( From what i gather ) is that external tools then have a field they know will be there and can all gather around, since they know what it is called. I dont really think it needs to be hardcoded as such, it could just be a default preference to the "JP

Re: [Kicad-developers] BOM component table dialog (quasi-)modality in osx

2017-06-06 Thread Dan Green
Hi Wayne, here’s the patch. I appreciate your comments about the confusion over quasi-modal boxes. In the future, what would be a good example to follow? Perhaps DIALOG_EESCHEMA_OPTIONS? thanks Dan 0001-Made-BOM-editor-dialog-quasi-modal.patch Description: Binary data > On Jun 6, 2017, at

Re: [Kicad-developers] BOM component table dialog (quasi-)modality in osx

2017-06-06 Thread Wayne Stambaugh
Dan, Would you please send your patch using `git format-patch` as an attachment or inline in an email directly to me so I can commit it? I tried using the response to your original message with `git am` but it didn't like it and I inadvertently deleted you original post. Thanks, Wayne On

Re: [Kicad-developers] [RFC] Standard field for manufacturer part number in schematic symbols

2017-06-06 Thread Wayne Stambaugh
Are the KiCad library developers planning on providing atomic symbol libraries? I'm guessing that is the end goal for reserving a name for an optional field. I cannot think of any other reason to do this. On 6/6/2017 9:22 AM, Kristoffer Ödmark wrote: > Hi! > > I will bump this issue again, but

Re: [Kicad-developers] menu icons

2017-06-06 Thread Marco Ciampa
On Tue, Jun 06, 2017 at 09:46:42AM -0400, Wayne Stambaugh wrote: > On 6/6/2017 3:14 AM, Marco Ciampa wrote: > > On Mon, Jun 05, 2017 at 05:37:32PM -0500, José Ignacio wrote: > >> Menu icons are disabled by default in gnome 3 in an effort to make it look > >> more like an Apple product. You can

Re: [Kicad-developers] [RFC] Standard field for manufacturer part number in schematic symbols

2017-06-06 Thread Fabrizio Tappero
​Hi there,​ Just in case somebody does not know what JP means here, I share my personal ​ preference setting​ : KiCad - Schematic - Preferences - Schematic Editor Options - Default Fields ​[image: Inline image 1]​ I personally think that JP suggestion is the solution to the basic problem that

Re: [Kicad-developers] [PATCH] Reunion of zoom toolbar buttons

2017-06-06 Thread Fabrizio Tappero
Hi Wayne, there are some little tiny quirks like this in kicad. It is just matter of time and we will fix them all ! cheers Fabrizio On Tue, Jun 6, 2017 at 3:41 PM, Wayne Stambaugh wrote: > Bernhard, > > I committed your patch. Good catch. I never even noticed this

Re: [Kicad-developers] menu icons

2017-06-06 Thread Wayne Stambaugh
On 6/6/2017 3:14 AM, Marco Ciampa wrote: > On Mon, Jun 05, 2017 at 05:37:32PM -0500, José Ignacio wrote: >> Menu icons are disabled by default in gnome 3 in an effort to make it look >> more like an Apple product. You can enable them (on gtk 3.10+) with: >> >> gsettings set

Re: [Kicad-developers] [PATCH] Reunion of zoom toolbar buttons

2017-06-06 Thread Wayne Stambaugh
Bernhard, I committed your patch. Good catch. I never even noticed this before but it definitely makes more sense to group all of the zoom buttons together. Thanks, Wayne On 6/5/2017 2:17 PM, Bernhard Stegmaier wrote: > Hi, > > I use KiCad for some while now, but I only recently noticed

Re: [Kicad-developers] [RFC] Standard field for manufacturer part number in schematic symbols

2017-06-06 Thread Kristoffer Ödmark
Hi! I will bump this issue again, but to avoid bikesheeding I will ask for a decision from leader Wayne. Should there be a default field in kicad for part number and if, what should it be named? From what i gather, a field for a part number is the only thing everyone agrees on, after that

Re: [Kicad-developers] Patch: Open Datasheet in Project Dir

2017-06-06 Thread Wayne Stambaugh
Cheng, I committed you patch to the master branch. Thank you for making the changes I suggested and your contribution to KiCad. One minor note, your revised patch had tabs which violate the KiCad Coding Policy[1]. I fixed them this time. In the future please make sure to have your editor

Re: [Kicad-developers] Patch: Open Datasheet in Project Dir

2017-06-06 Thread Cheng Sheng
Thanks, Wayne. See the new attachment with "wxURL" for testing URLs and updated AUTHORS.txt. Retested that both cases (http://... and ${KIPRJMOD}/...) still work. Regards, Cheng On 5 June 2017 at 20:30, Wayne Stambaugh wrote: > Hi Cheng, > > I just tested this patch and

Re: [Kicad-developers] [PATCH] More aggressive sheet-selection

2017-06-06 Thread Kristoffer Ödmark
Hello again! I understand that everyone is pretty busy, but I would appreciate if someone took a quick glance at this and said what they think. - Kristoffer On 2017-05-03 15:51, Kristoffer Ödmark wrote: Hello everyone! I made a small change to the "select hierarchical sheet" function. I

[Kicad-developers] pull default PDF viewer

2017-06-06 Thread Fabrizio Tappero
​Apologies for presenting this problem again and again I think this topic came up too many times but (on my linux system) the default PDF viewer is not pulled correctly by kiCad. From the terminal: $ cat /usr/share/applications/defaults.list | grep pdf

Re: [Kicad-developers] [PATCH] Reunion of zoom toolbar buttons

2017-06-06 Thread Fabrizio Tappero
totally needed patch! cheers Fabrizio On Mon, Jun 5, 2017 at 8:17 PM, Bernhard Stegmaier wrote: > Hi, > > I use KiCad for some while now, but I only recently noticed that there is > a “zoom to selection” function/button in the right toolbox. > Don’t know why, maybe

Re: [Kicad-developers] [PATCH] kicad right click menu corrections and few icons corrections

2017-06-06 Thread Fabrizio Tappero
Thank you for point it out. I am on it. cheers Fabrizio On Mon, Jun 5, 2017 at 6:40 PM, Wayne Stambaugh wrote: > I second this. The biggest offender that I can see is the new library > viewer icon. There are also a few images with a while border around > them as well

Re: [Kicad-developers] menu icons

2017-06-06 Thread Fabrizio Tappero
hi, on (probably last) linux mint, menu icons work well and are 100% controlled t the preference option. cheers Fabrizio On Tue, Jun 6, 2017 at 9:14 AM, Marco Ciampa wrote: > On Mon, Jun 05, 2017 at 05:37:32PM -0500, José Ignacio wrote: > > Menu icons are disabled by

Re: [Kicad-developers] menu icons

2017-06-06 Thread Marco Ciampa
On Mon, Jun 05, 2017 at 05:37:32PM -0500, José Ignacio wrote: > Menu icons are disabled by default in gnome 3 in an effort to make it look > more like an Apple product. You can enable them (on gtk 3.10+) with: > > gsettings set org.gnome.settings-daemon.plugins.xsettings overrides >