Re: [Kicad-developers] [Patch] Update PCB from Schematic hotkey in pcbnew and bug in schematic filename

Odd, on macOS the menu displays properly as the option symbol+F8. Yes I can look into tomorrow, I have kicad building on a linux machine at work. Looks like AddModifierToKey() in hotkeys_basic.cpp is adding an extra “Alt” to any accelerator key that’s not between ‘A’ - ‘Z’. Anyone know why

[Kicad-developers] [PATCH] Use wxImage instead of wxBitmap in COLOR4D picker (Fixes LP:1718389)

Hi all, The COLOR4D_PICKER_DLG has not been working on macOS [1]. Through some experimentation, I found that drawing to a wxBitmap in createRGBBitmap() / createHSVBitmap() just doesn't work on macOS. I am not sure how to fix it, but I did find out that drawing to a wxImage works just fine, so

[Kicad-developers] [PATCH] GerbView non-standard extensions

Attached is a patch to allow GerbView to "correctly" process %FSD commands. It also displays a warning message after processing the file that the Gerber is invalid. Background: - %FSD is used by older versions of Altium Designer [1], PADS, Allergro and ​CircuitCAM, among others, to denote that

Re: [Kicad-developers] GitHub Plugin (my nemesis)

I completely understand Oliver's view on maintaining every individual repo even if they are submodules of a kicad-footprint repo. Even from an a user perspective (which is clearly easier than the maintainer one), I like knowing what progress is being made, so I'd like to subscribe for updates of

Re: [Kicad-developers] latest GerbView doesn't display test file

Out of curiosity, how does one render an invalid gerber file? Are we to assume that %FSD will always have the same meaning between the applications that generated the gerbers? If not, then we have to determine the application that generated them and jump through hoops to get the rendering

Re: [Kicad-developers] latest GerbView doesn't display test file

I agree with your point that gerber viewers act as an important check. Toward that end displaying a warning message should alert the user that they have a problematic Gerber file that shouldn't go to a manufacturer. Fixing sounds dangerous to me as it modifies a file that explicitly doesn't

Re: [Kicad-developers] GitHub Plugin (my nemesis)

Just my 2 cents… I have seen some projects using submodules (open source and in my company). I have seen lots of problems and complaints (… doesn’t compile …) just because normal users or even normal developers (being no git experts) didn’t sync all submodules correctly. Thinking of how many

Re: [Kicad-developers] latest GerbView doesn't display test file

I don't know. If anything it would be the most useful to be able to try to repair broken files like that (maybe a script?). Displaying broken files "correctly" is dangerous. One of the main uses for a Gerber viewer is to do a pre-manufacturing check, and if your gerbers are broken and they work in

Re: [Kicad-developers] latest GerbView doesn't display test file

Looking at gerbv right now, it appears to silently handle decimal places if they exist. However, in the absence of an explicit decimal place, it treats %FSD as %FSL, which is probably why Clemens' file was correctly displayed, as opposed to being oversized by a factor of 100. Personally, I would

Re: [Kicad-developers] latest GerbView doesn't display test file

Hi! On 2017-09-28 18:17, jp charras wrote: > Le 28/09/2017 à 17:58, Jon Evans a écrit : >> Perhaps another route is to improve the messaging given to the user in these >> cases, so that it's >> easy for them to correct the file / report an issue to their tool vendor? > > Yes. > > In fact, %FSD

Re: [Kicad-developers] [PATCH] Fix some performance issues

On 9/26/2017 3:56 PM, Camille 019 wrote: > Hi, > > Ok, I'll keep the patchset synchronized with the master branch, for > future inclusion. When will the feature freeze take effect ? I was hoping it would be by the end of September but obviously that is not going to happen. I have my symbol

Re: [Kicad-developers] [PATCH] - Improve symbol library load speed

Oliver, Nice catch! I committed your patch to the master branch. Thank you for your contribution to KiCad. Cheers, Wayne On 9/28/2017 6:06 AM, Oliver Walters wrote: > Attached is a patch that provides a ~90% reduction in the time taken to > load symbol libraries when launching eeschema. > >

Re: [Kicad-developers] Deleting layers.

I recant my original position that it would not be a trivial fix. I just pushed the fix to the master branch. Please test it and let me know if you find any issues. I will be out of town over the weekend so I may not reply as quickly as I normally do. Please note that this fix isn't ideal.

Re: [Kicad-developers] [Patch] Update PCB from Schematic hotkey in pcbnew and bug in schematic filename

Dan, I found an issue but I don't think it's your issue but rather a bug in the AddHotKeyName() function. The menu accelerator for the "Update PCB from Schematic" menu entry ends up being "Alt + Alt + F8" instead of "Alt + F8" (see attached image). Do you have time to look at this and see if

Re: [Kicad-developers] latest GerbView doesn't display test file

Le 28/09/2017 à 17:58, Jon Evans a écrit : > Perhaps another route is to improve the messaging given to the user in these > cases, so that it's > easy for them to correct the file / report an issue to their tool vendor? Yes. In fact, %FSD is already supported by Gerbview because (a long time

Re: [Kicad-developers] latest GerbView doesn't display test file

Perhaps another route is to improve the messaging given to the user in these cases, so that it's easy for them to correct the file / report an issue to their tool vendor? On Thu, Sep 28, 2017 at 11:53 AM, Wayne Stambaugh wrote: > On 9/28/2017 10:32 AM, jp charras wrote: >

Re: [Kicad-developers] latest GerbView doesn't display test file

On 9/28/2017 10:32 AM, jp charras wrote: > Le 28/09/2017 à 16:13, Wayne Stambaugh a écrit : >> On 9/28/2017 9:45 AM, jp charras wrote: >>> Le 28/09/2017 à 01:27, Clemens Koller a écrit : On 2017-09-26 13:38, jp charras wrote: > The Gerber file is broken: > the line: >

Re: [Kicad-developers] latest GerbView doesn't display test file

Le 28/09/2017 à 16:13, Wayne Stambaugh a écrit : > On 9/28/2017 9:45 AM, jp charras wrote: >> Le 28/09/2017 à 01:27, Clemens Koller a écrit : >>> >>> On 2017-09-26 13:38, jp charras wrote: The Gerber file is broken: the line: %FSDAX33Y33*% is incorrect >>> >>> Thank you!

Re: [Kicad-developers] latest GerbView doesn't display test file

On 9/28/2017 9:45 AM, jp charras wrote: > Le 28/09/2017 à 01:27, Clemens Koller a écrit : >> >> On 2017-09-26 13:38, jp charras wrote: >>> The Gerber file is broken: >>> the line: >>> %FSDAX33Y33*% >>> >>> is incorrect >> >> Thank you! >> >> Since I cannot do anything about this proprietary non

Re: [Kicad-developers] GitHub Plugin (my nemesis)

I'd try to start with the simpler structure of having all the libraries as subdirectories of the same git repo. That doesn't mean that we could eventually add support for submodules, (for anyone that wants to make use of it)... But I agree that from the point of view of the librarians it's a

Re: [Kicad-developers] latest GerbView doesn't display test file

Le 28/09/2017 à 01:27, Clemens Koller a écrit : > > On 2017-09-26 13:38, jp charras wrote: >> The Gerber file is broken: >> the line: >> %FSDAX33Y33*% >> >> is incorrect > > Thank you! > > Since I cannot do anything about this proprietary non compliant EDA tool, > would it be possible to

Re: [Kicad-developers] [PATCH] Dark Theme Fixups

Thanks for digging this up. It looks awesome! I can test on macOS, Windows and Ubuntu Unity as soon as I fix my macOS build that was broken by the High Sierra update. Seppe On 28 September 2017 at 11:41:40, Marco Ciampa (ciam...@libero.it) wrote: On Wed, Sep 27, 2017 at 11:38:32PM +0200,

Re: [Kicad-developers] [BUG or FEATURE] Python action plugins updating

Hi, Mainly it's a bug. To be more precice, it's a missing feature. On plugin reloading, the plugin list is not cleanned but just updated. So if a plugin is renamed, it is assumed as a new one. This affect only use who change the plugin name. Regards, Le 28/09/2017 à 12:13, Константин Барановский

Re: [Kicad-developers] GitHub Plugin (my nemesis)

Simon, David, Thanks for the synopsis of your idea David, there are certainly some advantages to using the submodule approach. Is it github compatible? Simon, yes git-submodule is compatible with github. I have a test repository here - https://github.com/kicad/kicad-footprints - this contains

[Kicad-developers] [BUG or FEATURE] Python action plugins updating

Recently I noticed strange behaviour of the python action plugins list in menu. But I can't decide is it bug or a feature. To reproduce it and to understend what I mean, do the follows: 1) create python action plugin from Pcbnew manual "Add date on PCB"; 2) save it in acaptable place (for

[Kicad-developers] [PATCH] - Improve symbol library load speed

Attached is a patch that provides a ~90% reduction in the time taken to load symbol libraries when launching eeschema. Test case: Add all available libraries on my system to the search path. Prior to this patch, 40 seconds to load libraries. Now, 4 seconds! Essentially, each pin was being tested

Re: [Kicad-developers] [PATCH] Dark Theme Fixups

On Wed, Sep 27, 2017 at 11:38:32PM +0200, Maciej Sumiński wrote: > I am sure that responding to this message awards me the Golden Shovel > for digging out the oldest thread ever, but I think the patch indeed > makes the interface look better. 13 Dec 2015, that's a record! "Never give up, never

Re: [Kicad-developers] GitHub Plugin (my nemesis)

Thanks for your detailed description. I think it is a nice way to go. However two remarks: Does it simplify the maintenance of the kicad library by the librarians? Is it github compatible? If not, we would need to find another platform to host the libraries. If I look for git submodule, there

Re: [Kicad-developers] Deleting layers.

I agree as well, I've been hit by this bug once. And it was enough. I was actually planning to try and fix it similar to the way you are proposing right after the copypasta thingy is done. ( My ideal solution would be to add a "remove items on extra layers" button to the dialog that would