Re: [Kicad-developers] [PATCH] Remove dangling ends when switching sheets

Find ​can warp you to a new sheet ​ if the string matches a component that isn't on the current sheet​ . If that sheet hasn't ​yet ​ been shown ​ during the session , the dangling ends ​have not ​ been​ calculated ​, so we force it here.​ ​ ​Best- Seth​ On Dec 10, 2017 5:44 PM, "Wayne

Re: [Kicad-developers] [PATCH] Remove dangling ends when switching sheets

Seth, Why is it necessary to test for dangling end on a find? Find only searches for string matches so I'm having a hard time understanding why the dangling ends need to be cleaned up. Cheers, Wayne On 12/09/2017 11:45 PM, Seth Hillbrand wrote: > ​This patch fixes

Re: [Kicad-developers] [PATCH] Clean up unused junctions

Hi Wayne- Nope. It was part of the larger junction management patch set that was already merged. Best- Seth On Dec 10, 2017 3:33 PM, "Wayne Stambaugh" wrote: > Seth, > > Does this patch still needs to be applied? I'm getting buried with the > patch submissions. > >

Re: [Kicad-developers] [PATCH] Clean up unused junctions

Seth, Does this patch still needs to be applied? I'm getting buried with the patch submissions. Thanks, Wayne On 09/27/2017 07:57 PM, Seth Hillbrand wrote: > Hi Jon- > > Thanks for catching that.  The delete node/delete connection follow a > different path to deletion, so I missed them

Re: [Kicad-developers] [PATCH] Remove LAYER_WORKSHEET from forced visibility since it now has a control

Jon, I merged your patch into the master branch. Thanks, Wayne On 12/09/2017 01:08 PM, Jon Evans wrote: > Fixes: https://bugs.launchpad.net/kicad/+bug/1737315 > > -Jon > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to

[Kicad-developers] [PATCH] Bugfix: EDA_RECT to BOX2I generated wrong boxes

Dear Kicad developers, The "operator BOX2I() const" of EDA_RECT produced wrong boxes, usually much to big. It passed its end-position as second argument to the constructor of BOX2I. However, BOX2I expects its size as second argument. This caused a dramatic performance penalty in some cases. Took

[Kicad-developers] [PATCH] bugfix: OPENGL_GAL::DrawPolygon did not close closed polygons

Dear Kicad developers, The polygon drawing routing in the OpenGL-GAL did not plot polygons which are "closed", i.e. have a segment from their last point to their first point, correctly. That segment was omitted. The patch attached fixes this bug. Cheers, Andreas >From

Re: [Kicad-developers] Joining buses with junctions behavior

Jon- Thanks for catching this discrepancy. I had written the logic such that busses connect to other busses by a bus-to-bus entry. But clearly, that is historically not accurate and there needs to be a junction. -S On Sun, Dec 10, 2017 at 8:09 AM, Jon Evans wrote: > Hi

Re: [Kicad-developers] [PATCH] Remove outdated check on endAngle to fix GerbView arc draw direction

Just pushed this patch - thank you! On Sun, Dec 10, 2017 at 06:35:44PM +, Jon Evans wrote: > Hi all, > > Quick fix for an arc drawing path that still had some wrong logic in it. > > -Jon ___ Mailing list: https://launchpad.net/~kicad-developers

[Kicad-developers] [PATCH] Remove outdated check on endAngle to fix GerbView arc draw direction

Hi all, Quick fix for an arc drawing path that still had some wrong logic in it. -Jon From 318991f7202e42af73367be7f3ba4bf872efd4ce Mon Sep 17 00:00:00 2001 From: Jon Evans Date: Sun, 10 Dec 2017 13:35:00 -0500 Subject: [PATCH] Remove outdated check on endAngle to fix arc

[Kicad-developers] Joining buses with junctions behavior

Hi all, As I am working on bus features I have dived into all the ways you can use buses (that I haven't always known about myself). One thing I noticed was an example given on the docs: http://docs.kicad-pcb.org/stable/en/eeschema.html#wires-buses-labels-power-ports Under "Global connections