Re: [Kicad-developers] [PATCH] RFC: toolbar button support for action plugins

2018-08-16 Thread Andrey Kuznetsov
Please do not throw errors like unable to load icon to users, that is extremely annoying to users. It is the developer's responsibility to make sure the icon is loaded correctly, not the users, so users should not be bothered, since they cannot do anything about it anyway. On Thu, Aug 16, 2018 at

Re: [Kicad-developers] [PATCH] RFC: toolbar button support for action plugins

2018-08-16 Thread Seth Hillbrand
Hi Andrew- I like the idea. Aside from minor formatting (headers get 1 space between function defs, need a space before the if block), the patch looks good. However, I wouldn't want everything showing on my toolbar (speaking as someone who has 10 plugins installed, 5 of which get regular use).

Re: [Kicad-developers] [PATCH] RFC: toolbar button support for action plugins

2018-08-16 Thread Andrew Lutsenko
Hi Konstantin, Thanks for feedback. I like the idea that plugin writers can opt out of showing the button on toolbar, I will add this. Ultimately user should have control over it. If all plugin writers start adding icons top toolbar will run out of space. User should be able to choose which

Re: [Kicad-developers] [PATCH] RFC: toolbar button support for action plugins

2018-08-16 Thread Andrew Lutsenko
Hi Clemens, See sample plugin attached. Extract it into kicad's share/scripting/plugins folder. One of other scanned directories that are documented in kicadplugins.i should

Re: [Kicad-developers] Need help with menus and dialog modifications

2018-08-16 Thread Seth Hillbrand
Hi David- We're not generally wxWidgets support. If you are having a specific issue, there are a few people on the list who can probably help you debug it. But these sound like some pretty basic questions about working with wxWidgets. There are a number of good tutorials at

Re: [Kicad-developers] Joy of multi-platform development

2018-08-16 Thread Eeli Kaikkonen
If you don't have yet fun enough with joys of multi-platform development, I can give you more. Throw in different national keyboard layouts and it gets complicated. For example, I use Finnish layout in Kubuntu. The hotkeys editor in Preferences of pcbnew shows characters } and { as bind to

Re: [Kicad-developers] Joy of multi-platform development

2018-08-16 Thread jp charras
Le 16/08/2018 à 15:40, Jeff Young a écrit : > Cool. Let me know if you need any more OSX-assistance. > > Cheers, > Jeff. Thanks. I just committed a better fix in commit 6fdc5972. I am thinking the main issue was the use of the string "BkSp" instead of "Back" as accelerator in menu label. I

Re: [Kicad-developers] Joy of multi-platform development

2018-08-16 Thread Jeff Young
Cool. Let me know if you need any more OSX-assistance. Cheers, Jeff. > On 16 Aug 2018, at 12:05, jp charras wrote: > > Le 16/08/2018 à 12:11, Jeff Young a écrit : >> Hi JP, >> >> Your menu fix for LINUX does work for OSX as well. The problem is that >> because it didn’t understand the

Re: [Kicad-developers] [PATCH] RFC: toolbar button support for action plugins

2018-08-16 Thread Константин Барановский
чт, 16 авг. 2018 г. в 12:26, Andrew Lutsenko : > If icon file doesn't exist or can't be loaded (wrong format for example) > pcbnew will throw an error message > and will continue with no button for that plugin and generic hammer icon > in menu. > Hi Andrew! I think will be better to add the

Re: [Kicad-developers] [PATCH] get initial Python 3 support

2018-08-16 Thread mitjan696-ubu...@yahoo.co.uk
I've tested the windows version with the business logic of my action plugins and I am happy to report that I've had no issues and plugins produced the same results as with python2. On Tuesday, 14 August 2018, 23:26:06 CEST, Nick Østergaard wrote: Hi Thomas, I am happy to see that

Re: [Kicad-developers] [PATCH] RFC: toolbar button support for action plugins

2018-08-16 Thread Clemens Koller
Hello, Andrew! I am somehow missing the Python example you are giving in your patch. Can you add this a simple example to the sources to get a basic/dummy skeleton working right from scratch? Regards, Clemens On 15/08/2018 11.31, Andrew Lutsenko wrote: > Hi KiCad devs, > > I am proposing

Re: [Kicad-developers] Joy of multi-platform development

2018-08-16 Thread jp charras
Le 16/08/2018 à 12:11, Jeff Young a écrit : > Hi JP, > > Your menu fix for LINUX does work for OSX as well.  The problem is that > because it didn’t understand the hotkey *before* your fix it ends up > writing 0 (“”) into the hotkeys config, so you have to have > your fix *and* you have to reset

Re: [Kicad-developers] Joy of multi-platform development

2018-08-16 Thread Jeff Young
Hi JP, Your menu fix for LINUX does work for OSX as well. The problem is that because it didn’t understand the hotkey *before* your fix it ends up writing 0 (“”) into the hotkeys config, so you have to have your fix *and* you have to reset your hotkeys to default. Is there any way around

Re: [Kicad-developers] [PATCH] RFC: toolbar button support for action plugins

2018-08-16 Thread Andrew Lutsenko
Ok, tested this further and thought that it's silly that buttons on toolbar have icons but menu items have generic hammer. Second patch adds icons to menu and fixes compatibility with plugins that don't define icon. [image: actionmenu.png] If icon file doesn't exist or can't be loaded (wrong

[Kicad-developers] Vacation

2018-08-16 Thread Marco Ciampa
Saturday 18 morning I'll be leaving for vacation until sunday 26, this time without any laptop. To the admins: please keep an eye on the translations and docs pull requests. To the translators and contributors: please be patient, if there will be any contribution left hanging I'll see to those