Re: [Kicad-developers] [patch] GAL pixel alignment

2019-02-10 Thread Kevin Cozens
On 2019-02-10 5:26 p.m., Tomasz Wlostowski wrote: The 3 attached patches add pixel alignment while drawing strokes in GAL (both Cairo and OpenGL), resulting in sharp and uniform width lines regardless of the zoom level and antialiasing settings. Thank you, Tomasz. I just applied it to my copy

Re: [Kicad-developers] [patch] GAL pixel alignment

2019-02-10 Thread Andrew Lutsenko
Hi all, I just tested this on Win10 x64 and it's a huge improvement. Would love to see this in 5.1 since I'm basically forced to use fallback mode on current nightlies because opengl is plain ugly. And opengl performance is noticeably better than fallback (and a lot better than legacy). On Sun,

Re: [Kicad-developers] [patch] GAL pixel alignment

2019-02-10 Thread Seth Hillbrand
Am 2019-02-10 17:26, schrieb Tomasz Wlostowski: Hi, The 3 attached patches add pixel alignment while drawing strokes in GAL (both Cairo and OpenGL), resulting in sharp and uniform width lines regardless of the zoom level and antialiasing settings. Current GAL canvas does not round geometry to

Re: [Kicad-developers] [patch] GAL pixel alignment

2019-02-10 Thread Jeff Young
This hugely improves Fallback on Mac. Still doesn’t look as good as OpenGL (or Legacy), but it’s at least usable. OpenGL 2x Oversampling appears the same, but OpenGL with no antialiasing has caught up a lot. It’s now almost as good as 2X OS — in fact it would be usable if you wanted to

Re: [Kicad-developers] [patch] GAL pixel alignment

2019-02-10 Thread Wayne Stambaugh
Tom, It looks really good. I'm tempted to merge this but it's a fairly large change. I think we should merge it after 5.1 is released and cherry-pick it for 5.1.1 unless we can get a lot of testing in the next week or two to ensure that it's stable across all platforms. Cheers, Wayne On

Re: [Kicad-developers] [PATCH] Advanced config docs

2019-02-10 Thread Wayne Stambaugh
John, The dire warnings make sense to me. Go ahead and merge it when you get a chance. Cheers, Wayne On 2/10/19 5:01 PM, John Beard wrote: > Hi, > > Here's a patch for the advanced config dev-docs. Basically, it says > "here be dragons, use at your peril". I realise after re-reading the >

[Kicad-developers] [patch] GAL pixel alignment

2019-02-10 Thread Tomasz Wlostowski
Hi, The 3 attached patches add pixel alignment while drawing strokes in GAL (both Cairo and OpenGL), resulting in sharp and uniform width lines regardless of the zoom level and antialiasing settings. Current GAL canvas does not round geometry to integer pixel coordinates, resulting in sometimes

Re: [Kicad-developers] [PATCH] Advanced config docs

2019-02-10 Thread Nick Østergaard
The addition looks sane to me. On Sun, 10 Feb 2019 at 22:56, John Beard wrote: > Hi, > > Here's a patch for the advanced config dev-docs. Basically, it says > "here be dragons, use at your peril". I realise after re-reading the > docs I wrote before, that this is not clear. > > Sending to the

[Kicad-developers] [PATCH] Advanced config docs

2019-02-10 Thread John Beard
Hi, Here's a patch for the advanced config dev-docs. Basically, it says "here be dragons, use at your peril". I realise after re-reading the docs I wrote before, that this is not clear. Sending to the list as I don't want to introduce "policy" in this way without discussion. If anyone wishes

Re: [Kicad-developers] [PATCH] Add anchor for advanced configuration for doxygen docs

2019-02-10 Thread John Beard
Hi Nick, I have committed your patch. Thank you for noticing and your contribution! Cheers, John On Sun, Feb 10, 2019 at 9:01 PM Nick Østergaard wrote: > > Hello > > I would like to see the attached minor documentation change to be merged as > it makes it easier to link to the section from

[Kicad-developers] [PATCH] Add anchor for advanced configuration for doxygen docs

2019-02-10 Thread Nick Østergaard
Hello I would like to see the attached minor documentation change to be merged as it makes it easier to link to the section from the www. The patch should otherwise be self explanatory :) Regards Nick Østergaard From d95b0ff71ea3335e6c769b46479ec10ed7617c1c Mon Sep 17 00:00:00 2001 From:

Re: [Kicad-developers] environment checking in plugins (Re: 5.1.0-rc1)

2019-02-10 Thread Mitja Nemec
Hi Carsten Based on my experience I can only concur, that the code quality of the plugins could be better to say the least. But you have to remember where the plugins start. In general a KiCad user has an itch. That itch can sometimes be taken care of by writing a plugin. And since KiCad is

[Kicad-developers] environment checking in plugins (Re: 5.1.0-rc1)

2019-02-10 Thread Carsten Schoenert
Hello Mitja, Am 10.02.19 um 08:13 schrieb Mitja Nemec: > As a plugin developer I agree that KiCad is not responsible for third > party plugins, but as a developer I don't have any sane option to > detect the parameters of the system the plugin is running on. and what exactly you are missing?