[Kicad-developers] Linker Error (self made...)

2019-08-26 Thread Ian McInerney
I was trying to do a fresh build of master with the address sanitizer enabled in Clang, and I am receiving a strange linker error, and was curious if anyone else had any thoughts on it. When it tries to link the eeschema executable, it throws an error complaining about a missing Kiface symbol:

Re: [Kicad-developers] Patch: Fixing a compile error on Power PC

2019-08-26 Thread Seth Hillbrand
On 2019-08-26 16:05, Tomasz Wlostowski wrote: On 26/08/2019 17:24, Seth Hillbrand wrote: Agreed.  That looks like it may be have been a rebase issue as the commit was for MSVC and shouldn't affect PPC. @Tom, shout if you see an issue here.  I've pushed the patch to master in the meantime. I

Re: [Kicad-developers] Patch: Fixing a compile error on Power PC

2019-08-26 Thread Tomasz Wlostowski
On 26/08/2019 17:24, Seth Hillbrand wrote: > Agreed.  That looks like it may be have been a rebase issue as the > commit was for MSVC and shouldn't affect PPC. > > @Tom, shout if you see an issue here.  I've pushed the patch to master > in the meantime. > I don't see a technical issue, but

Re: [Kicad-developers] Development version string announcement

2019-08-26 Thread Ian McInerney
Dino, I believe this change was only to the version number that will appear in front of the string. It should still show the commit hash if you are compiling from source after checking out from the git repository. Is this not what you see? -Ian On Mon, Aug 26, 2019 at 7:20 PM Dino Ghilardi

Re: [Kicad-developers] Development version string announcement

2019-08-26 Thread Dino Ghilardi
Hallo everybody, Now that the old (sub)string related to the commit that has been compiled is not in the version string anymore, may be it should be added somewhere in the "version info" dialog to have that information easily available in the bug reports. P.S.: If this has yet been

Re: [Kicad-developers] Opinions on eeschema selection highlighting?

2019-08-26 Thread Wayne Stambaugh
Jeff, On 8/23/2019 1:19 PM, Jeff Young wrote: > While I wasn’t too happy with it at first, the new selection highlighting has > really grown on me. > > How do others feel about it? For the most part it seems OK to me. I have noticed at some zoom levels the highlighting seems heavier than

Re: [Kicad-developers] Patch: Fixing a compile error on Power PC

2019-08-26 Thread Seth Hillbrand
Agreed. That looks like it may be have been a rebase issue as the commit was for MSVC and shouldn't affect PPC. @Tom, shout if you see an issue here. I've pushed the patch to master in the meantime. Best- Seth On 2019-08-24 18:00, Steven A. Falco wrote: I have enabled compilation for

Re: [Kicad-developers] [Patch] Add ability to reset Pcbnew layer colors to default

2019-08-26 Thread Wayne Stambaugh
Ian, I merged your patch into the master branch. Thanks, Wayne On 8/22/2019 3:47 PM, Ian McInerney wrote: > Whoops, that wasn't supposed to be committed. This patch has it removed it. > > -Ian > > On Thu, Aug 22, 2019 at 7:00 PM Jon Evans > wrote: > > Yup,