Re: [Kicad-developers] Help needed

2020-09-25 Thread Franck Jullien
> references are invalidated. You will need to collect the items to delete in > a separate vector and delete them outside of the loop. > > Seth > > On Fri, Sep 25, 2020, 7:29 AM Franck Jullien wrote: >> >> Hi, >> >> I'm working on the intersheets references functionali

Re: [Kicad-developers] Help needed

2020-09-25 Thread Franck Jullien
ou run with ASAN on (KICAD_SANITIZE in CMake) and see if you get some > info about why you get a segfault? > > On Fri, Sep 25, 2020 at 10:28 AM Franck Jullien > wrote: >> >> Hi, >> >> I'm working on the intersheets references functionality and I'm >> strugg

[Kicad-developers] Help needed

2020-09-25 Thread Franck Jullien
Hi, I'm working on the intersheets references functionality and I'm struggling with a segfault. Until now, I didn't try to remove iref from sheets. Now, I do this with: void SCH_EDIT_FRAME::RemoveAllIntersheetsRefs() { SCH_SHEET_LIST sheets = Schematic().GetSheets(); SCH_GLOBALLABEL*

Re: [Kicad-developers] GitLab Jobs output

2019-12-05 Thread Franck Jullien
Ok, thanks. Le jeu. 5 déc. 2019 à 11:55, Ian McInerney a écrit : > > That was when we were first trying to figure out how to do the formatting > checks in the CI environment. It should be fixed in the current CI script in > master. > > -Ian > > On Thu, Dec 5, 2019 at

[Kicad-developers] GitLab Jobs output

2019-12-05 Thread Franck Jullien
Hi, I'm exploring GitLab. Here you can see a job marked "passed" with a strange output: https://gitlab.com/j_liljedahl/kicad/-/jobs/368453258 36 $ ./tools/check_coding.sh --diff --commit $CI_COMMIT_BEFORE_SHA 37 fatal: bad object 38 no modified files to

Re: [Kicad-developers] Fix lp:1849376

2019-11-27 Thread Franck Jullien
> I took a look at the intersheet reference patch and it looks like a nice > addition. It will need to wait until after the schematic file format > has been updated as it does introduce new functionality to the format. > We won't be adding new functionality to the existing, legacy schematic >

[Kicad-developers] Fix lp:1849376

2019-11-26 Thread Franck Jullien
17 00:00:00 2001 From: Franck Jullien Date: Tue, 26 Nov 2019 22:03:19 +0100 Subject: [PATCH] eechema: add junction if needed when component is placed Fixes: lp:1849376 * https://bugs.launchpad.net/kicad/+bug/1849376 --- eeschema/tools/sch_drawing_tools.cpp | 3 +++ 1 file changed, 3 insertions

Re: [Kicad-developers] GitLab issues

2019-11-26 Thread Franck Jullien
e will announce the > migration date (hopefully soon). The official group will be available > under https://gitlab.com/kicad. > > Cheers, > Orson > > On 11/26/19 1:01 PM, Franck Jullien wrote: > > Thanks. I did search here: https://gitlab.com/groups/kicad/-/issues > > N

[Kicad-developers] GitLab issues

2019-11-26 Thread Franck Jullien
Hi, I can't find this issue on GitLab: https://bugs.launchpad.net/kicad/+bug/1849376 Can you help me ? Franck. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe :

Re: [Kicad-developers] [PATCH v5] eeschema: Allow hierarchy navigator to stay open

2019-11-21 Thread Franck Jullien
Le mer. 20 nov. 2019 à 21:52, Franck Jullien a écrit : > > Le lun. 11 nov. 2019 à 16:59, Franck Jullien > a écrit : > > > > Hi again ! > > > > I now have fixed the commit message to include a tag (ADD). > > > > Franck. > > If it can help the r

Re: [Kicad-developers] [PATCH v5] eeschema: Allow hierarchy navigator to stay open

2019-11-20 Thread Franck Jullien
Le lun. 11 nov. 2019 à 16:59, Franck Jullien a écrit : > > Hi again ! > > I now have fixed the commit message to include a tag (ADD). > > Franck. If it can help the review, you can find this patch on github: https://github.com/fjullien/kicad/commit/350f5fc0ad7c128c3d1523

[Kicad-developers] [PATCH v5] eeschema: Allow hierarchy navigator to stay open

2019-11-11 Thread Franck Jullien
Hi again ! I now have fixed the commit message to include a tag (ADD). Franck. From 350f5fc0ad7c128c3d152317297468a7b9516e62 Mon Sep 17 00:00:00 2001 From: Franck Jullien Date: Thu, 24 Oct 2019 19:07:01 +0200 Subject: [PATCH v5] eeschema: Allow hierarchy navigator to stay open ADD: User can

Re: [Kicad-developers] [PATCH v3] [NEW] eeschema: Allow hierarchy navigator to stay open

2019-11-11 Thread Franck Jullien
gt; Orson > > 1. http://docs.kicad-pcb.org/doxygen/commit_messages.html > > On 11/10/19 7:36 PM, Franck Jullien wrote: > > Le dim. 10 nov. 2019 à 18:29, jp charras a écrit : > >> > >> Le 10/11/2019 à 17:33, Franck Jullien a écrit : > >>> Le je

[Kicad-developers] [PATCH v4] [NEW] eeschema: Allow hierarchy navigator to stay open

2019-11-10 Thread Franck Jullien
Hi, This is version 4 of this patch. Navigator now updates in real time when sheets are edited/removed/added. Franck. From 550f88483d598df41f38114fb4b24191f1442330 Mon Sep 17 00:00:00 2001 From: Franck Jullien Date: Thu, 24 Oct 2019 19:07:01 +0200 Subject: [PATCH v4] [NEW] eeschema: Allow

Re: [Kicad-developers] [PATCH v3] [NEW] eeschema: Allow hierarchy navigator to stay open

2019-11-10 Thread Franck Jullien
Le dim. 10 nov. 2019 à 18:29, jp charras a écrit : > > Le 10/11/2019 à 17:33, Franck Jullien a écrit : > > Le jeu. 7 nov. 2019 à 21:51, a écrit : > >> > >> From: Franck Jullien > >> > >> User can now decide to keep the hierarchy navigator open

Re: [Kicad-developers] [PATCH v3] [NEW] eeschema: Allow hierarchy navigator to stay open

2019-11-10 Thread Franck Jullien
Le jeu. 7 nov. 2019 à 21:51, a écrit : > > From: Franck Jullien > > User can now decide to keep the hierarchy navigator open while working > on a schematic. This behavior can be configured in > eeschema->preferences->eeschema->Editing options. > > Signed-off-by:

[Kicad-developers] [PATCH v3] [NEW] eeschema: Allow hierarchy navigator to stay open

2019-11-07 Thread franck . jullien
From: Franck Jullien User can now decide to keep the hierarchy navigator open while working on a schematic. This behavior can be configured in eeschema->preferences->eeschema->Editing options. Signed-off-by: Franck Jullien --- v2: fix coding style v3: fix memory leak after Way

Re: [Kicad-developers] [PATCH v2] eeschema: Allow hierarchy navigator to stay open

2019-11-04 Thread Franck Jullien
Le lun. 4 nov. 2019 à 13:19, Wayne Stambaugh a écrit : > > Hi Franck, > > There is a memory leak with your code. The Destroy() method is never > called when the hierarchy navigation dialog is closed. When using > modeless dialogs, you are responsible for cleaning up the dialog created > on the

[Kicad-developers] [PATCH v2] eeschema: Allow hierarchy navigator to stay open

2019-11-04 Thread franck . jullien
From: Franck Jullien Signed-off-by: Franck Jullien --- eeschema/dialogs/panel_eeschema_settings.cpp | 2 + .../dialogs/panel_eeschema_settings_base.cpp | 2 + .../dialogs/panel_eeschema_settings_base.fbp | 88 +++ .../dialogs/panel_eeschema_settings_base.h| 3

Re: [Kicad-developers] [PATCH] eeschema: Allow hierarchy navigator to stay open

2019-11-03 Thread Franck Jullien
Le jeu. 24 oct. 2019 à 19:29, a écrit : > > From: Franck Jullien > > Signed-off-by: Franck Jullien > --- > eeschema/dialogs/panel_eeschema_settings.cpp | 2 + > .../dialogs/panel_eeschema_settings_base.cpp | 2 + > .../dialogs/panel_eeschema

[Kicad-developers] [PATCH] eeschema: Allow hierarchy navigator to stay open

2019-10-24 Thread franck . jullien
From: Franck Jullien Signed-off-by: Franck Jullien --- eeschema/dialogs/panel_eeschema_settings.cpp | 2 + .../dialogs/panel_eeschema_settings_base.cpp | 2 + .../dialogs/panel_eeschema_settings_base.fbp | 88 +++ .../dialogs/panel_eeschema_settings_base.h| 3

Re: [Kicad-developers] [PATCH] Allow hierarchy navigator to stay open

2019-10-24 Thread Franck Jullien
Forget this, wrong patch. Sorry for the noise. I'm sending the new one. Le jeu. 24 oct. 2019 à 19:27, Franck Jullien a écrit : > > As discussed on the forum, it can be handy to let the navigator open > while working on a project. > I don't know if I choose the best place to add the

Re: [Kicad-developers] [PATCH] Allow hierarchy navigator to stay open

2019-10-24 Thread Franck Jullien
As discussed on the forum, it can be handy to let the navigator open while working on a project. I don't know if I choose the best place to add the new checkbox. Franck. Le jeu. 24 oct. 2019 à 19:25, a écrit : > > From: Franck Jullien > > Signed-off-by: Franck Jullien >

[Kicad-developers] [PATCH] Allow hierarchy navigator to stay open

2019-10-24 Thread franck . jullien
From: Franck Jullien Signed-off-by: Franck Jullien --- eeschema/dialogs/panel_eeschema_settings.cpp | 6 +- .../dialogs/panel_eeschema_settings_base.cpp | 6 +- .../dialogs/panel_eeschema_settings_base.fbp | 575 +++--- .../dialogs/panel_eeschema_settings_base.h| 5