Re: [Kicad-developers] 5.1 Hotkey problems

2019-06-11 Thread Ian McInerney
. Then it could only check for duplicates in the actions that could be activated. -Ian On Tue, Jun 11, 2019 at 7:40 PM Seth Hillbrand wrote: > Hi Ian- > > On 2019-06-11 12:56, Ian McInerney wrote: > > Somewhat in relation to the patch I just sent, 5.1 currently has some > > hotkey is

[Kicad-developers] 5.1 Hotkey problems

2019-06-11 Thread Ian McInerney
Somewhat in relation to the patch I just sent, 5.1 currently has some hotkey issues with the default hotkeys that are being shipped with it, namely with pcbnew where: Paste is a duplicate hotkey of Add Microvia (both have Ctrl-V) Add a similar zone has an invalid hotkey (it is currently

[Kicad-developers] [Patch] Hotkey validation/checking for 5.1

2019-06-11 Thread Ian McInerney
00:00:00 2001 From: Ian McInerney Date: Tue, 11 Jun 2019 17:38:00 +0100 Subject: [PATCH] Added hotkey validity checking to the preferences menu --- common/dialogs/panel_hotkeys_editor.cpp | 90 -- common/hotkey_store.cpp | 108 - common/widgets

Re: [Kicad-developers] CMake KICAD_SCRIPTING Options Hierarchy

2019-06-11 Thread Ian McInerney
on KICAD_SCRIPTING when they are enabled). I will put a patch for that together once I finish up some other work. -Ian On Thu, Jun 6, 2019 at 5:07 PM Wayne Stambaugh wrote: > Hey Ian > > On 6/5/19 1:03 PM, Ian McInerney wrote: > > I was just noticing based on a post on t

Re: [Kicad-developers] New package for macOS 5.1.2 stable including ngspice-30 ?

2019-06-09 Thread Ian McInerney
Is there a reason that pushing a change like this can't wait until the 5.1.3 release? Wayne had mentioned wanting to try to get it out the door in early July, which wouldn't be that far off. That would also give more uniformity in its roll out across the various platforms, and allow for easier

Re: [Kicad-developers] 5.1.3 stable release

2019-06-09 Thread Ian McInerney
To add on to this, the hotkey validation architecture that I have been building up to take care of the many issues surrounding the duplicate/invalid hotkeys (and also the fact that they can exist due to a user's hotkey settings from prior versions) will require new strings since I have error

Re: [Kicad-developers] PATCH pcbnew half-rotate actions and shortcuts

2019-06-08 Thread Ian McInerney
Just a note, the hotkey ctrl+shift+R is already assigned to "Differential Pair Dimensions" by default so this would introduce a duplicate hotkey conflict. It probably makes sense for this action to be ctrl+shift+R, but that means that the other needs to be changed. Also, as a side note to the

Re: [Kicad-developers] Error regarding mutex?

2019-06-05 Thread Ian McInerney
^~~~ >> > BUILDSTDERR: | flock >> > BUILDSTDERR: make[2]: *** >> [pcbnew/connectivity/CMakeFiles/connectivity.dir/build.make:66: >> pcbnew/connectivity/CMakeFiles/connectivity.dir/connectivity_algo.cpp.o] >> Er

[Kicad-developers] CMake KICAD_SCRIPTING Options Hierarchy

2019-06-05 Thread Ian McInerney
I was just noticing based on a post on the kicad forums that the CMake script will forcefully enable KICAD_SCRIPTING if either KICAD_SCRIPTING_ACTION_MENUS or KICAD_SCRIPTING_MODULES is turned on. This means to really disable scripting the user has to explicitly force all 3 to off (since they are

Re: [Kicad-developers] cvPCB Hotkey Handling

2019-06-03 Thread Ian McInerney
Key() today), and the > config files will just be {action-name, hotkey-sequence} tuples. > > Cheers, > Jeff. > > On 31 May 2019, at 23:26, Ian McInerney wrote: > > So, I have been able to implement the hotkeys I wanted (Jeff, thanks for > the pointers), and those changes were

Re: [Kicad-developers] cvPCB Hotkey Handling

2019-05-31 Thread Ian McInerney
PCB is just for the > Footprint Viewer window. > > Give a holler if you get stuck. > > Cheers, > Jeff. > > On 28 May 2019, at 19:17, Ian McInerney wrote: > > Jeff, > > Thanks for the pointer. I looked through the CVPCB_ACTIONS code last > night, and I cam

[Kicad-developers] [Patch] cvpcb Usability Improvements

2019-05-31 Thread Ian McInerney
on Sep 17 00:00:00 2001 From: Ian McInerney Date: Tue, 28 May 2019 00:21:22 +0100 Subject: [PATCH 1/3] cvpcb: Added library location to status bar Fixes: lp:1782805 * https://bugs.launchpad.net/kicad/+bug/1782805 --- cvpcb/cvpcb_mainframe.cpp | 32 cvpcb/cvpcb_mainf

Re: [Kicad-developers] cvPCB Hotkey Handling

2019-05-28 Thread Ian McInerney
an example. > > Cheers, > Jeff. > > > > On 28 May 2019, at 13:29, Ian McInerney > wrote: > > > > I am currently looking into adding some usability features to cvPCB > (copy/paste, single association delete, etc.) and want to also include the > relevan

[Kicad-developers] cvPCB Hotkey Handling

2019-05-28 Thread Ian McInerney
I am currently looking into adding some usability features to cvPCB (copy/paste, single association delete, etc.) and want to also include the relevant hotkey assignments for them. I am slightly confused where the hotkey handling for cvPCB is handled though, since I can't see any handling for it

Re: [Kicad-developers] Supported Python Versions

2019-05-24 Thread Ian McInerney
nch of > conditional python version code. There is already enough of that with > python2/3. > > Cheers, > > Wayne > > On 5/24/19 6:02 AM, Ian McInerney wrote: > > I am in the process of fixing a bug related to the importing of the > > plugins (https://bugs.launch

[Kicad-developers] Supported Python Versions

2019-05-24 Thread Ian McInerney
I am in the process of fixing a bug related to the importing of the plugins (https://bugs.launchpad.net/kicad/+bug/1828595), and the root cause is a change that was made between python 2 and 3 in which module contains the reload function. Unfortunately it isn't as simple for the python 3 side of

Re: [Kicad-developers] [Patch] Fixes for the github 3D library fetching dialog

2019-05-23 Thread Ian McInerney
s morning. > > -Seth > > Am 2019-05-23 12:55, schrieb Wayne Stambaugh: > > JP, > > > > This patch looks correct to me but this is your code so please take a > > look at this to see if it makes sense to you when you get a chance. > > > > Thanks, >

Re: [Kicad-developers] [PATCH] Replace remaining Boost Mutexes with std::mutex

2019-05-05 Thread Ian McInerney
be part of the overhaul for v6 with the new file formats. Whoever ends up working with those parts can do the replacements then and that will take care of all the parts in the C++11 technical todo list. -Ian On Sat, May 4, 2019 at 1:20 AM Seth Hillbrand wrote: > Am 2019-05-03 14:04, schrieb

[Kicad-developers] [Patch] Fixes for the github 3D library fetching dialog

2019-05-03 Thread Ian McInerney
fixes an issue where the library list was not populating when first visiting the second page (it would only populate if you tried searching or went back to page 1 and then page 2). -Ian From 5893a4a6c4e30d7eaa244e35ad7939757d582153 Mon Sep 17 00:00:00 2001 From: Ian McInerney Date: Sat, 4 May 2019

[Kicad-developers] [PATCH] Replace remaining Boost Mutexes with std::mutex

2019-05-03 Thread Ian McInerney
in the process). This was made against the master branch. It appears the kicad_curl.cpp file has diverged due to openssl changes between 5.1 and master, which makes this not apply cleanly to 5.1. Thanks, -Ian From 34e1977ef038d55baf03e73eda772f79d2f4fe9e Mon Sep 17 00:00:00 2001 From: Ian McInerney Date

<    1   2   3   4