suppose it wouldnt hurt. That would have to wait until V7 as it is
a new feature. The test cases look correct so I dont see any issues
here. - Wayne On 5/18/21 2:06 PM, Sylwester Kocjan wrote: Hello!
Ive noticed a minor bug in SPICE_VALUE class. Could you please let me
know if we should
Hello! Ive noticed a minor bug in SPICE_VALUE class. Could you please
let me know if we should parse SI units in SPICE strings or ignore them, so I
can fix it? I think ngspice accepts units like, V, I, Ohm, but this may be an
overkill. The easiest solution is to ignore everything after number
virtual
keyword before destructor of SCHEMATIC!) Best regards, Sylwester Dnia 21
stycznia 2021 16:38 Jeff Young j...@rokeby.ie napisał(a): Good point.
I have only used the Java one (which I guess is the original?). Cheers,
Jeff.On 20 Jan 2021, at 21:18, Sylwester Kocjans.koc...@o2.pl
, SK Dnia 17
stycznia 2021 16:45 Jeff Young j...@rokeby.ie napisał(a): I’ve used
Mockito. Can’t say I remember a thing about it, though (which could be good?).
Cheers, Jeff. On 17 Jan 2021, at 14:49, Sylwester Kocjan
s.koc...@o2.pl wrote: Hello, On 17/01/2021 09:47, Alex wrote
ect appears abandoned. If I'm incorrect here, can you
link to the current repository/documentation?
Thanks-
Seth
On Fri, Jan 15, 2021 at 2:49 PM Sylwester Kocjan
mailto:s.koc...@o2.pl>> wrote:
Hello,
I have two questions
Hello, I have two questions regarding QA code for KiCad and Id like to
ask for your comments about them: 1. I reviewed contents of qa directory in
KiCad repo and I saw some issues that can be fixed. Could you please take a
look at the summary and let me know if they are valid:
Hi Marco, Did you try to push your commit directly on master branch? If yes,
this is not correct gitlab workflow. For every change you need to create new
branch, which will be merged in pull request. Heres a summary:
gitlab.com gitlab.com I couldnt see exact error message. Could you
Hi Pepijn,
On 14/10/2020 20:00, pepijn de vos wrote:
I think there are a few ways to go about it, which don't exclude each
other. One is to extend the logic that adds the currents for voltage
sources and resistors to also add transistors.
Current release version of KiCad populates simulation
Thank you so much Dnia 2 września 2020 14:03 Ian McInerney
ian.s.mciner...@ieee.org napisał(a): I have added xvfb to the docker
images used for CI (both the Fedora 31 image and Ubuntu 18.04 image). -Ian
On Fri, Aug 28, 2020 at 8:36 PM Sylwester Kocjans.koc...@o2.pl
wrote: Hi again
to the main
unit test suite? If so, we should not use a VNC server to run them we
should use xvfb to emulate an X server interface.
-Ian
On Sat, Aug 22, 2020 at 11:31 PM Sylwester Kocjan <mailto:s.koc...@o2.pl>> wrote:
Hello,
Can I ask for updating docker images with a
2001
From: Sylwester Kocjan
Date: Sun, 23 Aug 2020 00:26:02 +0200
Subject: [PATCH] Add tigervnc to docker image
---
README.md | 7 ++-
scripts/install-dependencies.sh | 2 ++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/README.md b/README.md
index
Hello,
I noticed that simulation .wbk files have some limitations. I documented
my observations in following issue on Gitlab:
https://gitlab.com/kicad/code/kicad/-/issues/2283
As only KiCad Bot is watching that issue, I wanted to advertise it here.
Best regards,
Sylwester
.
Regards,
Sylwester
On 07/04/2020 20:26, Sylwester Kocjan wrote:
Hello,
I try to prepare a test where SIM_PLOT_FRAME() will be used.
Constructor of this frame requires Kiway, and I stumbled upon
a problem I cannot solve on my own. Could you please answer answer to
my questions, so I could move
Hello,
I try to prepare a test where SIM_PLOT_FRAME() will be used. Constructor
of this frame requires Kiway, and I stumbled upon
a problem I cannot solve on my own. Could you please answer answer to my
questions, so I could move on?
1. There is a Kiway object used in mocks_eeschema.cpp, in
it be possible for you to submit these are two merge requests to
the KiCad GitLab repository:
https://gitlab.com/kicad/code/kicad/-/tree/master. We have started to
use the merge requests to better track and review the patches that are
submitted.
Thanks,
-Ian
On Mon, Feb 10, 2020 at 5:27 PM Sylwester
Hi,
I have two patches to submit:
1. Three new types of sources have been implemented in dialog_spice_model.
2. One minor bug is fixed (removing less than zero rows from grid)
and one small improvement is added (ESC will close netlist window
in simulation).
I'd appreciate if you could take a
tures here. I thought this
might be
> > helpful when testing this patch
> >
> > It may also be useful to include the SPICE source simulation
as a
> demo.
> > If so, should I make a bug on launchpad?
> >
On 07/11/2019 21:14, Wayne Stambaugh wrote:
Ian's contributions have
earned him this privilege and we are grateful for his efforts.
Congratulations :)
Cheers,
Sylwester
___
Mailing list: https://launchpad.net/~kicad-developers
Post to :
Hi,
I was working too on pt.4 from 1814188, but frankly, I misunderstood
that and I added search textbox to filter signal list.
Do you think is it still worth any effort? My code is here:
https://github.com/skocjan/kicad_initialconditions/tree/SIM_FindSignalDlg
Interaction between searchCtrl
Hi Jonatan,
On 06/11/2019 13:29, Jonatan Liljedahl wrote:
useful for plotting calculated vectors ("let AB=V(a)*V(b)"),
see for example
https://forum.kicad.info/t/ac-analysis-of-op-amp-loop-gain-and-phase/19661/6
Just small remark to limit entropy in bug reports: it looks like you
have
Hi Seth,
On 23/10/2019 15:39, Seth Hillbrand wrote:
> This does bring up, however, that our simulator does not handle .op
> well. It won't probe the values or print them easily. LTSpice prints
> the DC Operating Point table for all nets after running in this mode.
I just looked into ngspice
Hi,
Thanks for pointing that. Maybe I'll try to prepare some tests in boost
for symulation to test my changes better.
However, I'd like to share my opinion during this occasion. I think that
parsing SPICE commands in KiCad is too much effort. Holger Vogt said
once that this is very
On 20/10/2019 20:53, Seth Hillbrand wrote:
On 2019-10-20 08:36, Sylwester Kocjan wrote:
Hi,
Here is a patch with three additional source models implemented: SFFM,
AM and Random.
I hope this looks ok, cause I had troubles with configuring
clang-format on Windows. If no, I can correct.
Best
2001
From: Sylwester Kocjan
Date: Sun, 20 Oct 2019 17:30:43 +0200
Subject: [PATCH] Eeschema: Adding new source types in SPICE model
NEW: Adds support in eeschema for three new source types
used in .TRAN simulation: single frequency FM, AM, and random.
---
eeschema/dialogs/dialog_spice_model.cpp
Hi,
I believe I will soon be ready to provide a patch with changes including
handling initial conditions in SPICE .tran simulation.
At the same time some new simulation parameters were prepared.
However recently I checked GNOME design principles:
attached, where this issue is prevented.
Best regards,
Sylwester
From 96dd3e764cf1a949f6720158c4c97bced6c6fe76 Mon Sep 17 00:00:00 2001
From: Sylwester Kocjan
Date: Sat, 19 Oct 2019 21:33:43 +0200
Subject: [PATCH] eeschema: fixed recognizing SPICE sim directive
---
eeschema/sim
Hi Wayne,
In the light of below finding, is this review comment still valid?
It belonged to my changes for initial conditions[1].
Dnia 27 czerwca 2019 21:04 Wayne Stambaugh
napisał(a):
> Get rid of DIALOG_SIM_SETTINGS::disableCtrlOnCheckboxEvent() and use the
> appropriate
wer window to the clipboard (a least on
linux) with your patch so I am reluctant to merge it because I'm sure
users will want to be able to copy and paste the generated netlist for
bug reporting purposes.
Cheers,
Wayne
On 6/23/19 4:45 PM, Sylwester Kocjan wrote:
Hello,
I noticed in simulatio
Hi KiCad-devs & Seth,
I was looking at the code for handling spice fields and I noticed
something that I either don't understand or is unnecessary. In this
commit:
https://github.com/KiCad/kicad-source-mirror/commit/170ff66cbbd4f17ebf6fddf24efa7b4d227c15a1
there was a change added in
:00 PM, Sylwester Kocjan wrote:
Hi,
I prepared some changes in KiCad simulation dialog. They are about
additional simulation parameters. According to tutorial, which Ive
found on website, I store them on GitHub repository in branch
Sim_InitialConditions_SK here:
github.com github.com
Could
for wxStyledTextCtrl. Thanks to this window can be dismissed
when pressing Escape.
Is it OK to share patch directly here or should I rather create bug
report?
Best regards,
Sylwek
>From 7d3fcfa1a96c95ddab71850db3175e528158a966 Mon Sep 17 00:00:00 2001
From: Sylwester Kocjan
Date: Sun, 23 Jun 2019 16:28
Thanks Seth,
> tabs being used instead of spaces and two blank lines between
> functions in .cpp files. It looks like retval in
> DIALOG_SIM_SETTINGS::TransferDataToWindow() isn't getting initialized
> properly.
Fixed in commit: e87ee2624892ad51e95cd9b8206e8d408de46939
> Are the ","
Hi,
I prepared some changes in KiCad simulation dialog. They are about
additional simulation parameters. According to tutorial, which I've
found on website, I store them on GitHub repository in branch
"Sim_InitialConditions_SK" here:
https://github.com/skocjan/kicad_initialconditions.git
Could
33 matches
Mail list logo
