Re: [Kicad-developers] [PATCH] Add background color for subsheets

2017-09-18 Thread Oliver Walters
It makes more sense to me to wait then, rather than duplicating efforts on non critical features. Thanks On 19 Sep 2017 01:03, "Wayne Stambaugh" wrote: > Hey Oliver, > > I just tested your updates it seems to work OK except for the fact that > the fill color cannot be set

Re: [Kicad-developers] [PATCH] Add background color for subsheets

2017-09-14 Thread Oliver Walters
Wayne, Good point. The attached patch set modifies the default sheet background to UNSPECIFIED. Regarding the ability to unset the color. Any suggestions on how best to do this? I have played around with a few options without success. The best I came up with: Add a checkbox to the color

Re: [Kicad-developers] [PATCH] Add background color for subsheets

2017-09-14 Thread Wayne Stambaugh
On 9/14/2017 11:40 AM, Andrey Kuznetsov wrote: > I hope there's an option to remove color as well, after color has been > added. That's why I asked if we could set the color to unspecified so users can turn off the fill and background color will displayed in the sheet. Otherwise, the user will

Re: [Kicad-developers] [PATCH] Add background color for subsheets

2017-09-14 Thread Andrey Kuznetsov
I hope there's an option to remove color as well, after color has been added. I can't remember, is text color modifiable? If not, that kind of limits the background color choices. On Thu, Sep 14, 2017 at 7:22 AM Wayne Stambaugh wrote: > Oliver, > > I just tested this

Re: [Kicad-developers] [PATCH] Add background color for subsheets

2017-09-14 Thread Wayne Stambaugh
Oliver, I just tested this patch and I like it. I would like you to please set the default color to COLOR4D::UNSPECIFIED if possible so that no filling occurs unless the user selects a color. It is rather jarring to suddenly have all of the sheets in your schematic turn blue. It might also be

Re: [Kicad-developers] [PATCH] Add background color for subsheets

2017-09-13 Thread Maciej Suminski
Hi Oliver, Seems good to me, I vote for merging. Regards, Orson On 09/12/2017 11:11 AM, Oliver Walters wrote: > This small patch adds a configurable background color for hierarchical > sheets. > > Image: http://i.imgur.com/53zgcy9.png > > Oliver > > > >

[Kicad-developers] [PATCH] Add background color for subsheets

2017-09-12 Thread Oliver Walters
This small patch adds a configurable background color for hierarchical sheets. Image: http://i.imgur.com/53zgcy9.png Oliver From b6f06edf51e0772c3a85917160d779e809388041 Mon Sep 17 00:00:00 2001 From: Oliver Walters Date: Tue, 12 Sep 2017 19:07:00 +1000 Subject: