Re: [Kicad-developers] [PATCH] Adjust Menubar of 3D Viewer to common style

Thomas, I merged your patches. Thank you for your contribution to KiCad. Cheers, Wayne On 05/05/2018 11:41 AM, Thomas Pointhuber wrote: Hi Wayne, I updated the patches accordingly. Regard, Thomas Am 2018-05-04 um 18:09 schrieb Wayne Stambaugh: Yes, please update your patch to use the

Re: [Kicad-developers] [PATCH] Adjust Menubar of 3D Viewer to common style

Hi Wayne, I updated the patches accordingly. Regard, Thomas Am 2018-05-04 um 18:09 schrieb Wayne Stambaugh: > Yes, please update your patch to use the terms "Clockwise" and > "Counterclockwise" which is consistent with the rest of kicad. > > Thanks, > > Wayne > From

Re: [Kicad-developers] [PATCH] Adjust Menubar of 3D Viewer to common style

Yes, please update your patch to use the terms "Clockwise" and "Counterclockwise" which is consistent with the rest of kicad. Thanks, Wayne On 05/04/2018 11:32 AM, Thomas Pointhuber wrote: > so I should change it to CW and CCW? I assume the tooltip text of the > panel should also be change

Re: [Kicad-developers] [PATCH] Adjust Menubar of 3D Viewer to common style

so I should change it to CW and CCW? I assume the tooltip text of the panel should also be change accordingly. Regards, Thomas Am 2018-05-03 um 19:44 schrieb Wayne Stambaugh: > On 5/3/2018 1:28 PM, jp charras wrote: >> Le 03/05/2018 à 18:44, Wayne Stambaugh a écrit : >>> I did notice one thing

Re: [Kicad-developers] [PATCH] Adjust Menubar of 3D Viewer to common style

On 5/3/2018 1:28 PM, jp charras wrote: > Le 03/05/2018 à 18:44, Wayne Stambaugh a écrit : >> I did notice one thing that is a bit odd in the first patch. The rotate >> menu entries use -> and <- to signify clockwise and counter-clockwise >> directions. I'm not sure this is clear to the user. If

Re: [Kicad-developers] [PATCH] Adjust Menubar of 3D Viewer to common style

Le 03/05/2018 à 18:44, Wayne Stambaugh a écrit : > I did notice one thing that is a bit odd in the first patch. The rotate > menu entries use -> and <- to signify clockwise and counter-clockwise > directions. I'm not sure this is clear to the user. If we need to > avoid the verbosity of CW and

Re: [Kicad-developers] [PATCH] Adjust Menubar of 3D Viewer to common style

I did notice one thing that is a bit odd in the first patch. The rotate menu entries use -> and <- to signify clockwise and counter-clockwise directions. I'm not sure this is clear to the user. If we need to avoid the verbosity of CW and CCW then maybe we should use + and - instead. On

Re: [Kicad-developers] [PATCH] Adjust Menubar of 3D Viewer to common style

I like removing them. I always found it odd that they were in a menu structure. > On 3 May 2018, at 15:58, Wayne Stambaugh wrote: > > Hi Thomas, > > The first patch is fine. Removing all of the settings from the > preferences menu that are in the configuration options

Re: [Kicad-developers] [PATCH] Adjust Menubar of 3D Viewer to common style

Hi Thomas, The first patch is fine. Removing all of the settings from the preferences menu that are in the configuration options dialog may not be acceptable to other users. Personally, I don't have a preference since I do not change these options very often. Other users may not share my

Re: [Kicad-developers] [PATCH] Adjust Menubar of 3D Viewer to common style

it would be cool to merge this before rc2 :) Regards, Thomas Am 2018-04-26 um 21:58 schrieb Thomas Pointhuber: > Hi, > > I did some rebase and rewrite of the patch and removed for now the > changes in "file" and "edit" to have something hopefully mergable. It > consists of two patches. The

Re: [Kicad-developers] [PATCH] Adjust Menubar of 3D Viewer to common style

Hi, I did some rebase and rewrite of the patch and removed for now the changes in "file" and "edit" to have something hopefully mergable. It consists of two patches. The first adds some new entries, the second one removes all those menus which are available in an already existing dialog and thus

Re: [Kicad-developers] [PATCH] Adjust Menubar of 3D Viewer to common style

Hi Thomas, It’s a bit of a mess. The 3D viewer isn’t a separate application, and so shouldn’t really have its own menus at all, and certainly not a File menu. But for 5.0, it is what it is, and we need somewhere to put the other two export options. Eeschema is different because it is (sort

Re: [Kicad-developers] [PATCH] Adjust Menubar of 3D Viewer to common style

Hi Jeff, I would still place the clipboard option into the file menu. Preferably below the Export Entry because it would be more logical to find. The current location of the clipboard item is because Eeschema also located this menu item in the exports menu and I simpily tried for consistency.

Re: [Kicad-developers] [PATCH] Adjust Menubar of 3D Viewer to common style

Hi Thomas, I don’t think I’d nest the two export options just for the sake of consistency. Nested menus are harder to use, and should only be resorted to when necessary (either when room on the menu is an issue, or when progressive disclosure is desired). Copy 3D Image goes to the clipboard,

[Kicad-developers] [PATCH] Adjust Menubar of 3D Viewer to common style

Hi, some time ago there were adjustments to have a common design of the menubar in all applications. This initial patch does some basic adjustions of the 3D-Viewer in this direction, but things like displaying Hotkeys was not added. One question regarding improvements based on that patch would