Re: [Kicad-developers] [PATCH] Component table view initial columns sizing

Bernhard, I tested your patch on windows and linux and everything looked fine so I merged it into the development branch. Thanks, Wayne On 12/5/2017 3:37 PM, Bernhard Stegmaier wrote: > Wayne, > > No problem… never used it before, but always good to learn something new… :) > Attached. > > >

Re: [Kicad-developers] [PATCH] Component table view initial columns sizing

Wayne,No problem… never used it before, but always good to learn something new… :)Attached.Regards,Bernhard 0001-Fix-initial-sizing-of-Fields-table-columns-in-compon.patch Description: Binary data On 5. Dec 2017, at 20:47, Wayne Stambaugh wrote:Bernhard,Please resend the

Re: [Kicad-developers] [PATCH] Component table view initial columns sizing

Bernhard, Please resend the patch using `git format-patch`. This makes it a lot easier to apply patches and push to master if they are ready to go. Thanks, Wayne On 12/5/2017 2:16 PM, Bernhard Stegmaier wrote: > Wayne, > > I created it just by directing a “git show” to a file. > I could

Re: [Kicad-developers] [PATCH] Component table view initial columns sizing

Wayne, I created it just by directing a “git show” to a file. I could apply it to master using “patch -p1 < xxx.patch”. Of course, I can also try to use “git formal-patch” and resend… Regards, Bernhard > On 5. Dec 2017, at 19:45, Wayne Stambaugh wrote: > > Bernhard, >

Re: [Kicad-developers] [PATCH] Component table view initial columns sizing

Bernhard, I just tried to merge this patch using `git am` and I'm getting this error: fatal: empty ident name (for <>) not allowed It looks like you didn't create this patch using `git format-patch` and/or you do not have your user name and/or user email set in your git config. Cheers, Wayne

Re: [Kicad-developers] [PATCH] Component table view initial columns sizing

Hi Simon, > On 5. Dec 2017, at 14:37, Simon Richter wrote: > > Unrelated to your patch: does it make sense to perhaps share some of the > grouping code between this and the component pin table? First: I didn’t write that piece of code and I only had a very quick look

Re: [Kicad-developers] [PATCH] Component table view initial columns sizing

Hi Bernhard, On 05.12.2017 14:02, Bernhard Stegmaier wrote: > attached patch fixes initial sizing of “Fields” table columns of component > table view. Unrelated to your patch: does it make sense to perhaps share some of the grouping code between this and the component pin table? Simon