Re: [Kicad-developers] [PATCH] Eeschema: add wildcard and regex support to component chooser

On 12/19/2015 7:40 PM, Henner Zeller wrote: > On 19 December 2015 at 16:32, Chris Pavlina wrote: >> I'm fine with this one, and it all works quite well so I'm assuming Henner >> considers it final. I'd commit it. > > Yes, considered final, ready to submit. Not a

Re: [Kicad-developers] [PATCH] Eeschema: add wildcard and regex support to component chooser

On 19 December 2015 at 16:32, Chris Pavlina wrote: > I'm fine with this one, and it all works quite well so I'm assuming Henner > considers it final. I'd commit it. Yes, considered final, ready to submit. (And yes, sorry if I screwed up code styles, I try to be more

Re: [Kicad-developers] [PATCH] Eeschema: add wildcard and regex support to component chooser

On 12/19/2015 2:57 AM, Henner Zeller wrote: > On 18 December 2015 at 21:57, Henner Zeller wrote: >> On 18 December 2015 at 21:50, Chris Pavlina wrote: >>> On Fri, Dec 18, 2015 at 09:40:29PM -0800, Henner Zeller wrote: On 18 December 2015 at 21:33,

Re: [Kicad-developers] [PATCH] Eeschema: add wildcard and regex support to component chooser

I'm fine with this one, and it all works quite well so I'm assuming Henner considers it final. I'd commit it. On Dec 19, 2015 7:21 PM, "Wayne Stambaugh" wrote: > On 12/19/2015 2:57 AM, Henner Zeller wrote: > > On 18 December 2015 at 21:57, Henner Zeller

Re: [Kicad-developers] [PATCH] Eeschema: add wildcard and regex support to component chooser

Since you went to the trouble to actually code this up, I figure I might as well try it - and I'm okay with this compromise. Still not exactly my favorite approach, but you made it work fairly well, and it looks useful enough. *thumbs up* On Fri, Dec 18, 2015 at 11:57:37PM -0800, Henner Zeller

Re: [Kicad-developers] [PATCH] Eeschema: add wildcard and regex support to component chooser

On 18 December 2015 at 21:33, Chris Pavlina wrote: > I'm not going to argue about search methods, it'll suffice to say I > disagree. I don't _want_ to search my library your way, and yes, I > understand that it can work. > > I'm unconvinced that adding one option box is

Re: [Kicad-developers] [PATCH] Eeschema: add wildcard and regex support to component chooser

On 18 December 2015 at 21:50, Chris Pavlina wrote: > On Fri, Dec 18, 2015 at 09:40:29PM -0800, Henner Zeller wrote: >> On 18 December 2015 at 21:33, Chris Pavlina wrote: >> > I'm not going to argue about search methods, it'll suffice to say I >>

[Kicad-developers] [PATCH] Eeschema: add wildcard and regex support to component chooser

As discussed earlier today, this patch adds support for both wildcard and regular expression search to the eeschema component chooser. An option is added to eeschema options to select the "Component search method", which defaults to "Simple" (the original behavior). Regular expression search

Re: [Kicad-developers] [PATCH] Eeschema: add wildcard and regex support to component chooser

On 18 December 2015 at 21:19, Henner Zeller wrote: > On 18 December 2015 at 20:16, Chris Pavlina wrote: >> As discussed earlier today, this patch adds support for both wildcard >> and regular expression search to the eeschema component chooser. An >>

Re: [Kicad-developers] [PATCH] Eeschema: add wildcard and regex support to component chooser

On 18 December 2015 at 20:16, Chris Pavlina wrote: > As discussed earlier today, this patch adds support for both wildcard > and regular expression search to the eeschema component chooser. An > option is added to eeschema options to select the "Component search >

Re: [Kicad-developers] [PATCH] Eeschema: add wildcard and regex support to component chooser

I'm not going to argue about search methods, it'll suffice to say I disagree. I don't _want_ to search my library your way, and yes, I understand that it can work. I'm unconvinced that adding one option box is excessive complexity. It's not in the main UI, it's in the preferences dialog.

Re: [Kicad-developers] [PATCH] Eeschema: add wildcard and regex support to component chooser

On Fri, Dec 18, 2015 at 09:40:29PM -0800, Henner Zeller wrote: > On 18 December 2015 at 21:33, Chris Pavlina wrote: > > I'm not going to argue about search methods, it'll suffice to say I > > disagree. I don't _want_ to search my library your way, and yes, I > >

Re: [Kicad-developers] [PATCH] Eeschema: add wildcard and regex support to component chooser

On 18 December 2015 at 21:57, Henner Zeller wrote: > On 18 December 2015 at 21:50, Chris Pavlina wrote: >> On Fri, Dec 18, 2015 at 09:40:29PM -0800, Henner Zeller wrote: >>> On 18 December 2015 at 21:33, Chris Pavlina wrote: