Re: [Kicad-developers] [PATCH] Fix drag wire issue

2017-11-29 Thread Wayne Stambaugh
Seth, If you have time, it would be nice to get this fixed. Thanks, Wayne On 11/28/2017 8:06 PM, Seth Hillbrand wrote: > Wayne- > > I see what is happening here.  This is a separate issue but I'm happy to > submit a second patch.  Because you are dragging a full wire, Eeschema's >

Re: [Kicad-developers] [PATCH] Fix drag wire issue

2017-11-29 Thread Wayne Stambaugh
Seth, I merged your patch in the development branch. Thank you for your contribution to KiCad. Cheers, Wayne On 11/27/2017 5:51 PM, Seth Hillbrand wrote: > ​In Eeschema, if you draw two lines on top of each other that are not > the same type, e.g. wire and bus; or bus and graphic line​, and

Re: [Kicad-developers] [PATCH] Fix drag wire issue

2017-11-28 Thread Seth Hillbrand
Wayne- I see what is happening here. This is a separate issue but I'm happy to submit a second patch. Because you are dragging a full wire, Eeschema's connectivity algorithm connects the ends of the bus with the ends of the wire. So dragging the full bus line grabbed all of the connected wires

Re: [Kicad-developers] [PATCH] Fix drag wire issue

2017-11-28 Thread Seth Hillbrand
Hi Wayne- Thanks for testing. Oddly, I do not observe either of the effects you describe on Mac or Linux (Debian), based off master (f992d144d). Are you running Windows? If so, I'll try to find a VM to replicate this. Best- Seth On Tue, Nov 28, 2017 at 12:43 PM, Wayne Stambaugh

Re: [Kicad-developers] [PATCH] Fix drag wire issue

2017-11-28 Thread Wayne Stambaugh
Seth, I just tested this. The disambiguation menu is shown but it still drags both lines and it breaks the undo as well. Maybe the undo part is fixed by your other patch set. Cheers, Wayne On 11/27/2017 5:51 PM, Seth Hillbrand wrote: > ​In Eeschema, if you draw two lines on top of each other

[Kicad-developers] [PATCH] Fix drag wire issue

2017-11-27 Thread Seth Hillbrand
​In Eeschema, if you draw two lines on top of each other that are not the same type, e.g. wire and bus; or bus and graphic line​, and then hover over the lines and use the 'drag' hotkey, both lines will drag at the same time. The correct behavior should show disambiguation. The attached patch