Re: [Kicad-developers] [PATCH] Improved zoom behavior on MacOS

2017-09-15 Thread Maciej Suminski
Hi Jon, I have just committed your patch, thank you! Regards, Orson On 09/12/2017 05:16 PM, Jon Evans wrote: > Hi, > > This patch changes the way middle wheel events are handled on MacOS. > In my testing, this new behavior feels way better when using Apple > trackpads, and also seems to work

Re: [Kicad-developers] [PATCH] Improved zoom behavior on MacOS

2017-09-14 Thread Bernhard Stegmaier
Hi Jon, thanks, worked. Change works fine for me. Regards, Bernhard > On 13. Sep 2017, at 15:14, Jon Evans wrote: > > Hi Bernhard, > > Please try the attached. > > Thanks, > Jon > > On Wed, Sep 13, 2017 at 6:56 AM, Bernhard Stegmaier

Re: [Kicad-developers] [PATCH] Improved zoom behavior on MacOS

2017-09-13 Thread Jon Evans
Hi Bernhard, Please try the attached. Thanks, Jon On Wed, Sep 13, 2017 at 6:56 AM, Bernhard Stegmaier wrote: > Hi, > > I am getting > patch: malformed patch at line 52: @@ -178,6 +181,7 @@ void > WX_VIEW_CONTROLS::onWheel( wxMouseEvent& aEvent ) > > Can you

Re: [Kicad-developers] [PATCH] Improved zoom behavior on MacOS

2017-09-13 Thread Bernhard Stegmaier
Hi, I am getting patch: malformed patch at line 52: @@ -178,6 +181,7 @@ void WX_VIEW_CONTROLS::onWheel( wxMouseEvent& aEvent ) Can you resend? Regards, Bernhard > On 13. Sep 2017, at 11:09, Maciej Suminski wrote: > > Hi Jon, > > The patch looks good to me.

Re: [Kicad-developers] [PATCH] Improved zoom behavior on MacOS

2017-09-13 Thread Maciej Suminski
Hi Jon, The patch looks good to me. I am willing to merge it as soon as it receives some positive feedback from the Mac users. Regards, Orson On 09/12/2017 05:16 PM, Jon Evans wrote: > Hi, > > This patch changes the way middle wheel events are handled on MacOS. > In my testing, this new

[Kicad-developers] [PATCH] Improved zoom behavior on MacOS

2017-09-12 Thread Jon Evans
Hi, This patch changes the way middle wheel events are handled on MacOS. In my testing, this new behavior feels way better when using Apple trackpads, and also seems to work fine with the normal wheel on my external mouse. Mac users, I'd appreciate some testing to see if the behavior is worse