Re: [Kicad-developers] [PATCH] Silence a ridiculous number of missing overrides warnings on clang

No problem. I think the original concern was abuse of virtual not the use of override. If Simon R doesn't have time to fix this, I'm not opposed to applying your patch temporarily until we can get it resolved. On 9/21/2016 4:57 PM, Simon Wells wrote: > Oh my apologies wayne, i vaguely

Re: [Kicad-developers] [PATCH] Silence a ridiculous number of missing overrides warnings on clang

Oh my apologies wayne, i vaguely remembered them being discussed on list and i thought that it was decided that it wasn't an issue or something On Thu, Sep 22, 2016 at 8:48 AM, Wayne Stambaugh wrote: > Simon, > > Simon Richter had a patch with all or most of the overrides

Re: [Kicad-developers] [PATCH] Silence a ridiculous number of missing overrides warnings on clang

Simon, Simon Richter had a patch with all or most of the overrides warnings fixed. I asked him to rebase it so I could get it merged because it was out of sync. That was a while ago. I haven't heard anything from him since then unless I missed it. I actually like the override since it

[Kicad-developers] [PATCH] Silence a ridiculous number of missing overrides warnings on clang

--- CMakeLists.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 5ff860b..1fd55e7 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -265,6 +265,11 @@ if( CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang" ) endif(