Re: [Kicad-developers] [PATCH] lib-cache-rescue: remove summary dialog, correct minor bug

2015-05-13 Thread Wayne Stambaugh
Patch committed in product branch r5653. Thank you for you contribution. On 5/4/2015 1:30 PM, Chris Pavlina wrote: I've got two changes here - they're a bit inadvertently intertwined, so I left them as one patch, otherwise one would depend on the other anyway. Let me know if you want me to

Re: [Kicad-developers] [PATCH] lib-cache-rescue: remove summary dialog, correct minor bug

2015-05-13 Thread Wayne Stambaugh
Chris, I just tested this and I like the changes. I believe I found a bug. I just rescued an old project and noticed all of the zener diodes were oriented 180 degrees from the unrescued version. When you get a chance, would you please verify the component orientation against the rescued

Re: [Kicad-developers] [PATCH] lib-cache-rescue: remove summary dialog, correct minor bug

2015-05-13 Thread Wayne Stambaugh
I'm not sure why swapped pins in the system libraries would be an issue since the cached components should product the correct schematic. Assuming the rescue library is properly fetching the components from the cache library, I can't see how any changes in the system libraries would cause this.

Re: [Kicad-developers] [PATCH] lib-cache-rescue: remove summary dialog, correct minor bug

2015-05-13 Thread Nick Østergaard
2015-05-13 21:22 GMT+02:00 Wayne Stambaugh stambau...@gmail.com: I'm not sure why swapped pins in the system libraries would be an issue since the cached components should product the correct schematic. Assuming the rescue library is properly fetching the components from the cache library, I

Re: [Kicad-developers] [PATCH] lib-cache-rescue: remove summary dialog, correct minor bug

2015-05-13 Thread Wayne Stambaugh
I found another schematic with the same problem. The changed zener diode is not getting detected or at least for me it doesn't show up in the list of components to rescue. Perhaps there is a bug in the component comparison code. It may be the LIB_PIN comparison is the issue. You should be able

Re: [Kicad-developers] [PATCH] lib-cache-rescue: remove summary dialog, correct minor bug

2015-05-13 Thread Wayne Stambaugh
On 5/13/2015 4:28 PM, Nick Østergaard wrote: 2015-05-13 21:22 GMT+02:00 Wayne Stambaugh stambau...@gmail.com: I'm not sure why swapped pins in the system libraries would be an issue since the cached components should product the correct schematic. Assuming the rescue library is properly

Re: [Kicad-developers] [PATCH] lib-cache-rescue: remove summary dialog, correct minor bug

2015-05-13 Thread Chris Pavlina
Hi Wayne, That's interesting. I can't really imagine what would cause that, and I haven't seen anything like that - I've tested it on many projects that should have stirred that bug up if it existed. Any chance you can share with me the problem project? Chris On Wed, May 13, 2015 at

Re: [Kicad-developers] [PATCH] lib-cache-rescue: remove summary dialog, correct minor bug

2015-05-13 Thread Chris Pavlina
I don't use the KiCad libraries usually, so I'm unaware - were the pin numbers swapped? If that's the case, I'm not sure of a way to handle that gracefully, as from the software's perspective, pin 1 is pin 1 is pin 1 - the fact that the cathode band is drawn elsewhere obviously doesn't factor

Re: [Kicad-developers] [PATCH] lib-cache-rescue: remove summary dialog, correct minor bug

2015-05-13 Thread Maciej Sumiński
Is it possible the problem is related to the recent diode pin swapping in KiCad library? Regards, Orson On 05/13/2015 05:35 PM, Chris Pavlina wrote: Hi Wayne, That's interesting. I can't really imagine what would cause that, and I haven't seen anything like that - I've tested it on many

[Kicad-developers] [PATCH] lib-cache-rescue: remove summary dialog, correct minor bug

2015-05-04 Thread Chris Pavlina
I've got two changes here - they're a bit inadvertently intertwined, so I left them as one patch, otherwise one would depend on the other anyway. Let me know if you want me to discard half. 1. Remove the summary dialog from lib-cache-rescue. I originally created it so the user would know what