Re: [Kicad-developers] [PATCH 1/4] Avoid bringing own definition of M_PI (MSVC warning C4005)

2015-07-03 Thread jp charras
Le 02/07/2015 23:56, Simon Richter a écrit : > --- > pcbnew/exporters/export_idf.cpp | 2 +- > utils/idftools/idf_common.cpp | 4 ++-- > utils/idftools/idf_common.h | 13 + > utils/idftools/idf_parser.cpp | 2 +- > 4 files changed, 5 insertions(+), 16 deletions(-) > Commit

Re: [Kicad-developers] [PATCH 1/4] Avoid bringing own definition of M_PI (MSVC warning C4005)

2015-07-02 Thread Cirilo Bernardo
Thanks Simon, It's good to see odd things like this cleaned up. The "vrml_layer" code also uses the same #ifndef .. #define for M_PI, M_PI2. M_PI4 (and M_PI4 is not used in any code I can find -I don't know why I put it there). - Cirilo On Fri, Jul 3, 2015 at 7:56 AM, Simon Richter wrote: > --

[Kicad-developers] [PATCH 1/4] Avoid bringing own definition of M_PI (MSVC warning C4005)

2015-07-02 Thread Simon Richter
--- pcbnew/exporters/export_idf.cpp | 2 +- utils/idftools/idf_common.cpp | 4 ++-- utils/idftools/idf_common.h | 13 + utils/idftools/idf_parser.cpp | 2 +- 4 files changed, 5 insertions(+), 16 deletions(-) diff --git a/pcbnew/exporters/export_idf.cpp b/pcbnew/exporters/ex