Re: [Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

Patch committed in product branch r6352. Thanks. On 12/1/2015 2:14 AM, Simon Richter wrote: > > CMake 3.0 defines two new variables, > > * CMAKE_CXX_VISIBILITY_PRESET and > * CMAKE_VISIBILITY_INLINES_HIDDEN > > to control whether symbols not explicitly tagged for export are implicitly >

Re: [Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

Hello! I managed to build everything without any downloaded deps on OS X. I’ve already updated my Portfile to build the 4.0.0 stable, and so far it builds and runs. I’ll try to use and test it some more later today. On 2 dicembre 2015 at 16:51:54, Wayne Stambaugh (stambau...@gmail.com) wrote:

Re: [Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

I can but I need to get the 4.0.0 build out first. If someone else can do it sooner than end of this week/weekend, please do :) On Wed, Dec 2, 2015 at 8:30 AM, Wayne Stambaugh wrote: > Would one of our OSX devs please confirm this doesn't break anything on > OSX builds

Re: [Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

Would one of our OSX devs please confirm this doesn't break anything on OSX builds before I commit it. Thanks, Wayne On 12/1/2015 2:14 AM, Simon Richter wrote: > > CMake 3.0 defines two new variables, > > * CMAKE_CXX_VISIBILITY_PRESET and > * CMAKE_VISIBILITY_INLINES_HIDDEN > > to control

Re: [Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

No hurry. The stable release OSX package has priority. I just need confirmation on OSX builds that the patch wont break anything. One other question: do you use the KICAD_BUILD_STATIC or KICAD_BUILD_DYNAMIC options for your build configuration? I can't see where they were used outside of

Re: [Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

O yea I was going to submit a patch to add a note along with some more elaboration on "hard way" building because its incomplete for a fresh install. i.e. missing make and cmake packages. Also the run "pacman -Syu" after fresh install is wrong as it will throw errors, theres a command you have to

Re: [Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

On 12/2/2015 11:03 AM, Mark Roszko wrote: >> In the not too distant future, you will have to build boost (probably >> version 1.59) > > If there's ever a recommendation written somewhere. There needs to be > a big note somewhere that 1.59 is broken on 64-bit windows in > boost::context. I

Re: [Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

I will see about pulling in Aljaž's work--not sure how much of it is Macports specific until I take a look. On Wed, Dec 2, 2015 at 10:05 AM, Wayne Stambaugh wrote: > On 12/2/2015 11:03 AM, Mark Roszko wrote: > >> In the not too distant future, you will have to build boost

Re: [Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

I am on a stock MacPorts boost since over a year now… 1.58 and now 1.59 (don’t know since when). I didn’t see any problems with it. Regards, Bernhard > On 02 Dec 2015, at 16:51, Wayne Stambaugh wrote: > > In the not too distant future, you will have to build boost

Re: [Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

Any way to make this patch less noisy? It seems to work fine on windows builds but it would be nice if it didn't spew so many cmake policy warnings. I wont bump the cmake version until it's available on Debian stable (currently cmake 3.0.2) which I use as my benchmark for version availability.

[Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

CMake 3.0 defines two new variables, * CMAKE_CXX_VISIBILITY_PRESET and * CMAKE_VISIBILITY_INLINES_HIDDEN to control whether symbols not explicitly tagged for export are implicitly exported. Because only version 3.3 and following also applies that to static libraries when in 3.3 mode,