Re: [Kicad-developers] [Patch] Update PCB from Schematic hotkey in pcbnew and bug in schematic filename

2017-10-03 Thread Wayne Stambaugh
On 10/2/2017 2:49 PM, Dan Green wrote: > > > On Friday, September 29, 2017 at 11:32 PM, jp charras wrote: > >> Le 29/09/2017 à 03:51, Dan Green a écrit : >>> Odd, on macOS the menu displays properly as the option symbol+F8. Yes I can >>> look into tomorrow, I >>> have kicad building on a linux

Re: [Kicad-developers] [Patch] Update PCB from Schematic hotkey in pcbnew and bug in schematic filename

2017-10-02 Thread Dan Green
On Friday, September 29, 2017 at 11:32 PM, jp charras wrote: > Le 29/09/2017 à 03:51, Dan Green a écrit : > > Odd, on macOS the menu displays properly as the option symbol+F8. Yes I can > > look into tomorrow, I > > have kicad building on a linux machine at work. > > > > Looks like

Re: [Kicad-developers] [Patch] Update PCB from Schematic hotkey in pcbnew and bug in schematic filename

2017-09-30 Thread jp charras
Le 29/09/2017 à 03:51, Dan Green a écrit : > Odd, on macOS the menu displays properly as the option symbol+F8. Yes I can > look into tomorrow, I > have kicad building on a linux machine at work. > > Looks like AddModifierToKey() in hotkeys_basic.cpp is adding an extra “Alt” > to any accelerator

Re: [Kicad-developers] [Patch] Update PCB from Schematic hotkey in pcbnew and bug in schematic filename

2017-09-29 Thread Jon Neal
Just a suggestion, since the "Update PCB from schematic" functionality hasn't been in a release yet maybe update the hotkey in eeschema so it matches the hotkey in pcbnew? Yes, people who have been using the nightlies will have to relearn the hotkey, but that is better than another UI

Re: [Kicad-developers] [Patch] Update PCB from Schematic hotkey in pcbnew and bug in schematic filename

2017-09-28 Thread Dan Green
Odd, on macOS the menu displays properly as the option symbol+F8. Yes I can look into tomorrow, I have kicad building on a linux machine at work. Looks like AddModifierToKey() in hotkeys_basic.cpp is adding an extra “Alt” to any accelerator key that’s not between ‘A’ - ‘Z’. Anyone know why

Re: [Kicad-developers] [Patch] Update PCB from Schematic hotkey in pcbnew and bug in schematic filename

2017-09-28 Thread Wayne Stambaugh
Dan, I found an issue but I don't think it's your issue but rather a bug in the AddHotKeyName() function. The menu accelerator for the "Update PCB from Schematic" menu entry ends up being "Alt + Alt + F8" instead of "Alt + F8" (see attached image). Do you have time to look at this and see if

Re: [Kicad-developers] [Patch] Update PCB from Schematic hotkey in pcbnew and bug in schematic filename

2017-09-26 Thread Dan Green
Ah yes, of course, all that makes sense. Thanks for explaining it. Alt+F8 is available, so attached is a patch using that as the default (and with IS_ACCELERATOR). thanks, Dan On Tuesday, September 26, 2017 at 6:57 AM, Wayne Stambaugh wrote: > Hey Dan, > > I have a few comments on your

Re: [Kicad-developers] [Patch] Update PCB from Schematic hotkey in pcbnew and bug in schematic filename

2017-09-26 Thread Wayne Stambaugh
Hey Dan, I have a few comments on your patches. The "Update PCB from Schematic" patch uses a duplicate hotkey. F8 is already assigned to the HK_SWITCH_LAYER_TO_INNER4 command ID. Check the pcbnew/hotkeys.cpp file for the list of assigned hotkey. Also, you are using F8 as a menu accelerator

[Kicad-developers] [Patch] Update PCB from Schematic hotkey in pcbnew and bug in schematic filename

2017-09-25 Thread Dan Green
Hi all, here are two patches to address some minor issues with the "Update PCB from Schematic” tool when called from pcbnew. The first adds the F8 hotkey to match eeschema. The second fixes a bug that happens if the project name contains a period (e.g.: MyProject_rev1.2). In this case, the