Re: [Kicad-developers] [RFC] Comments for a Layer Stack Manager in Pcbnew

2019-09-06 Thread Evan Shultz
Sorry if this is mixing things since Michael replied after me. Continuing on with the numbering I used above: 8. To clarify, I meant the material name in the Material column, not the layer name in the Name column. I assume this would fit in with adding custom materials which is to be done later.

Re: [Kicad-developers] [RFC] Comments for a Layer Stack Manager in Pcbnew

2019-09-06 Thread jp charras
Le 06/09/2019 à 12:04, Michael Kavanagh a écrit : > Hi JP, > > This will be a great addition to KiCad, and I'm excited to see this > progress. Now it's merged into master, would you prefer feedback on > the mailing list or bug reports? > > In any case, the panel display seems to be broken on

Re: [Kicad-developers] [RFC] Comments for a Layer Stack Manager in Pcbnew

2019-09-05 Thread jp charras
I just committed the Layer Stack Manager feature. Some comments below: Le 03/09/2019 à 20:47, Evan Shultz a écrit : > A few comments from the peanut gallery using Simon's "497" build... > > Some things Seth suggested that I support and don't see: > - Units could be shown once at the top of the

Re: [Kicad-developers] [RFC] Comments for a Layer Stack Manager in Pcbnew

2019-09-03 Thread Eeli Kaikkonen
ti 3. syysk. 2019 klo 21.48 Evan Shultz (evan.shu...@gmail.com) kirjoitti: > > 4. The "X" column is not salient. It is the only column header with a > popup, and that's required because the function is opaque. Along with the > comment above about expanding the table, using a more verbose term (or

Re: [Kicad-developers] [RFC] Comments for a Layer Stack Manager in Pcbnew

2019-09-03 Thread Evan Shultz
A few comments from the peanut gallery using Simon's "497" build... Some things Seth suggested that I support and don't see: - Units could be shown once at the top of the panel or in each column header instead of each cell of the table. That would reduce clutter a bit and shorten the string that

Re: [Kicad-developers] [RFC] Comments for a Layer Stack Manager in Pcbnew

2019-09-03 Thread Eeli Kaikkonen
Found it and it works. ti 3. syysk. 2019 klo 15.21 Simon Richter (simon.rich...@hogyros.de) kirjoitti: > Hi, > > > Are the binaries downloadable? I downloaded > > kicad-patched-495-762dabd75-x86_64.exe from > > > https://kicad-downloads.s3.cern.ch/index.html?prefix=windows/testing/patched/ > >

Re: [Kicad-developers] [RFC] Comments for a Layer Stack Manager in Pcbnew

2019-09-03 Thread Simon Richter
Hi, > Are the binaries downloadable? I downloaded > kicad-patched-495-762dabd75-x86_64.exe from > https://kicad-downloads.s3.cern.ch/index.html?prefix=windows/testing/patched/ > but pcbnew crashes before it opens. The binaries on the download server and on the Jenkins host (found under

Re: [Kicad-developers] [RFC] Comments for a Layer Stack Manager in Pcbnew

2019-09-02 Thread Eeli Kaikkonen
Are the binaries downloadable? I downloaded kicad-patched-495-762dabd75-x86_64.exe from https://kicad-downloads.s3.cern.ch/index.html?prefix=windows/testing/patched/ but pcbnew crashes before it opens. Eeli Kaikkonen ma 2. syysk. 2019 klo 15.06 Simon Richter (simon.rich...@hogyros.de) kirjoitti:

Re: [Kicad-developers] [RFC] Comments for a Layer Stack Manager in Pcbnew

2019-09-02 Thread jp charras
Le 02/09/2019 à 14:06, Simon Richter a écrit : > Hi, > >> Please test and comment. >> I want to commit this feature soon. > > Builds on msys2 and msvc are on the way: > > https://jenkins.simonrichter.eu/job/windows-kicad-msys2-patch/495/ >

Re: [Kicad-developers] [RFC] Comments for a Layer Stack Manager in Pcbnew

2019-09-02 Thread Simon Richter
Hi, > Please test and comment. > I want to commit this feature soon. Builds on msys2 and msvc are on the way: https://jenkins.simonrichter.eu/job/windows-kicad-msys2-patch/495/ https://jenkins.simonrichter.eu/job/windows-kicad-msvc-patch/142/ There should be binaries there for easier testing

Re: [Kicad-developers] [RFC] Comments for a Layer Stack Manager in Pcbnew

2019-09-02 Thread jp charras
I just finished the version of board stack manager that should fix all issues and remarks previously made, and has some tests to avoid incorrect parameters. The patch is against latest master branch version (5.99.0-48) The stackup settings is now in the board settings dialog. Note also the board

Re: [Kicad-developers] [RFC] Comments for a Layer Stack Manager in Pcbnew

2019-08-21 Thread José Ignacio
+1 on Wayne's comments. One of the nice things about the recent work on the board setup dialog is the centralization of board settings that were previously spread all over the place, we really shouldn't go back the other direction. On Wed, Aug 21, 2019 at 8:46 AM Wayne Stambaugh wrote: > Hi JP,

Re: [Kicad-developers] [RFC] Comments for a Layer Stack Manager in Pcbnew

2019-08-21 Thread Wayne Stambaugh
Hi JP, On 8/17/19 2:39 PM, jp charras wrote: > Le 13/08/2019 à 18:52, Wayne Stambaugh a écrit : >> JP, >> >> I took a look at your patch and I have a few comments. >> >> Shouldn't the stack up dialog just be another panel the the board setup >> dialog? I would think this information is part of

Re: [Kicad-developers] [RFC] Comments for a Layer Stack Manager in Pcbnew

2019-08-17 Thread jp charras
Le 13/08/2019 à 18:52, Wayne Stambaugh a écrit : > JP, > > I took a look at your patch and I have a few comments. > > Shouldn't the stack up dialog just be another panel the the board setup > dialog? I would think this information is part of the board setup but I > could be wrong. > > If the

Re: [Kicad-developers] [RFC] Comments for a Layer Stack Manager in Pcbnew

2019-08-13 Thread Seth Hillbrand
Hi JP- This looks like a good addition. I'm happy to see it being developed. A few notes: - "dielectric_constrains" maybe could be "dielectric_constraints" - It would be nice to see this replace the "Layers" panel in Board setup. We also set pcb thickness there as well as have our add/remove

Re: [Kicad-developers] [RFC] Comments for a Layer Stack Manager in Pcbnew

2019-08-13 Thread Wayne Stambaugh
JP, I took a look at your patch and I have a few comments. Shouldn't the stack up dialog just be another panel the the board setup dialog? I would think this information is part of the board setup but I could be wrong. If the stack up information is part of the board setup then it should be in

[Kicad-developers] [RFC] Comments for a Layer Stack Manager in Pcbnew

2019-08-10 Thread jp charras
Since a long time, I started (slowly...) a layer stack manager. The purpose is to allow users to define (for board fabrication) some important parameters like: - tech, copper and dielectric thickness - color of some tech layers - dielectric material - board constraints. All of these parameters