Re: [Kicad-developers] Context menu not shown in Pcbnew.

2019-05-15 Thread John Beard
On 15/05/2019 18:32, Jeff Young wrote: This is probably a good time for a few words about the new code. Looks nice! I'm seeing dozens (36 to be exact) of asserts on startup under GTK3: ./src/gtk/menu.cpp(729): assert "Assert failure" failed in SetBitmap(): only normal menu items can have

Re: [Kicad-developers] Context menu not shown in Pcbnew.

2019-05-15 Thread Jeff Young
Hi Michael, I’ve removed a bunch of the disabling on purpose. Some of them serve a purpose (such as undo/redo telling you when you’re at the start or end of the stack). Most of them are just noise in the UI. Could you log a bug for the icon scale thing? That’s not something I know how to

Re: [Kicad-developers] Context menu not shown in Pcbnew.

2019-05-15 Thread Michael Kavanagh
Hi Jeff, This is great! A few comments: - The icon scale doesn't seem to work - Eeschema: Leave sheet button is always enabled. - Libedit: the arc and polyline tools have the circle tool icon. Also these aren't disabled when there's no symbol loaded on startup. Cheers. Michael On

Re: [Kicad-developers] Context menu not shown in Pcbnew.

2019-05-15 Thread Jeff Young
This is probably a good time for a few words about the new code. CONDITIONAL_MENU (which we used to use just for context menus) has been expanded to also work in the main menu bar. You can insert either ACTIONs or wxWidgets’ style IDs into it. In either case, you no longer need UpdateUI

Re: [Kicad-developers] Context menu not shown in Pcbnew.

2019-05-15 Thread Jeff Young
I’ve just pushed new bits. I don’t have any expectation that they’ll fix this, but they do make changes in that area so they might. Oh, wait, you guys are just seeing this in PCBNew? In that case I do think my new bits will fix it. (The call to evaluate the conditions wasn’t getting

Re: [Kicad-developers] Context menu not shown in Pcbnew.

2019-05-15 Thread Jeff Young
I haven’t seen this on OSX, but Art and Laurent have reported it on MSW. > On 15 May 2019, at 17:46, Jon Evans wrote: > > I just checked, I see the same problem, Ubuntu / GTK3 (interesting that it > works for you, JP) > > On Wed, May 15, 2019 at 12:44 PM jp charras

Re: [Kicad-developers] Context menu not shown in Pcbnew.

2019-05-15 Thread jp charras
Le 15/05/2019 à 18:46, Jon Evans a écrit : > I just checked, I see the same problem, Ubuntu / GTK3 (interesting that > it works for you, JP) In fact my kicad/GTK3 build was too old (I was thinking it is up to date, but I was mistaken). I have the same issue on GTK3: context menu not shown

Re: [Kicad-developers] Context menu not shown in Pcbnew.

2019-05-15 Thread Jon Evans
I just checked, I see the same problem, Ubuntu / GTK3 (interesting that it works for you, JP) On Wed, May 15, 2019 at 12:44 PM jp charras wrote: > Is it just me, or it affects some other users? > > Since changes in commit ef5c69167, in Pcbnew, Linux Ubuntu / GTK2 (right > mouse click) is not

[Kicad-developers] Context menu not shown in Pcbnew.

2019-05-15 Thread jp charras
Is it just me, or it affects some other users? Since changes in commit ef5c69167, in Pcbnew, Linux Ubuntu / GTK2 (right mouse click) is not displayed: on Windows and Linux Ubuntu / GTK2 it is displayed only when the "Route track" tool is active. On Linux/ GTK2 a small rect is shown, like a