Re: [Kicad-developers] CvPcb Save

2018-03-25 Thread Jeff Young
I just merged a hybrid of the two: it makes CvPcb look and act like a dialog, but also has an “Apply, Save Schematic & Continue” button. Yes, it’s a bit of a mouthful, but it least it doesn’t leave anyone any questions. If you get a chance to take a look at it, let me know what you think.

Re: [Kicad-developers] CvPcb Save

2018-03-23 Thread Jeff Young
I implemented this one and played around with it a bit.  Surprisingly, I like the “blind save” version better.  It’s just a pain in the arse to OK, Save, re-enter CvPcb every time you want to check-point.Here’s the patch in case anyone wants to try it out (note that this is a minimal intervention

Re: [Kicad-developers] CvPcb Save

2018-03-21 Thread Wayne Stambaugh
I'm fine with getting rid of the save and updating the schematic footprint fields when closing cvpcb. Most of this is historical baggage from when cvpcb was a stand alone app and required intermediate files for assigning footprints. On 3/21/2018 9:41 AM, Jeff Young wrote: > But what’s the point

Re: [Kicad-developers] CvPcb Save

2018-03-21 Thread Jeff Young
But what’s the point of having ctrl-S at all if it just moves it to some other place in volatile memory? The user might as well just wait until they close CvPcb, as volatile is volatile, no? > On 21 Mar 2018, at 12:47, Wayne Stambaugh wrote: > > A possible short term

Re: [Kicad-developers] CvPcb Save

2018-03-21 Thread Wayne Stambaugh
A possible short term fix is to change the action from save to update schematic which is what really happens and is more analogous to clicking the OK button in a modal dialog. I don't know if saving the schematic from CvPcb makes a lot of sense. I would keep the ctrl+s shortcut. Changing this

Re: [Kicad-developers] CvPcb Save

2018-03-20 Thread Eeli Kaikkonen
2018-03-20 22:23 GMT+02:00 Russell Oliver : > Blind saving from CvPCB to memory or disk? > > IMO, saving the schematic to disk should be done consciously by the user, > from the main window of eeschema. Closing the CvPCB should silently update > the footprint links on the

Re: [Kicad-developers] CvPcb Save

2018-03-20 Thread Jeff Young
To disk. See the first email in the thread. > On 20 Mar 2018, at 20:23, Russell Oliver wrote: > > Blind saving from CvPCB to memory or disk? > > IMO, saving the schematic to disk should be done consciously by the user, > from the main window of eeschema. Closing the

Re: [Kicad-developers] CvPcb Save

2018-03-20 Thread Russell Oliver
Blind saving from CvPCB to memory or disk? IMO, saving the schematic to disk should be done consciously by the user, from the main window of eeschema. Closing the CvPCB should silently update the footprint links on the schematic in memory. On Wed, 21 Mar 2018 07:10 Jeff Young,

Re: [Kicad-developers] CvPcb Save

2018-03-20 Thread Jeff Young
In case anyone else wants to try it out: 0001-Save-schematic-after-back-annotating.patch Description: Binary data On 20 Mar 2018, at 20:10, Jeff Young wrote:FWIW, I implemented blind-saving the schematic from CvPcb’s Save command so I could play around with it, and it feels

Re: [Kicad-developers] CvPcb Save

2018-03-20 Thread Jeff Young
FWIW, I implemented blind-saving the schematic from CvPcb’s Save command so I could play around with it, and it feels natural enough... > On 20 Mar 2018, at 19:44, Jeff Young wrote: > > I think the cleanest user model would be to make both CvPcb and the Symbol > Table

Re: [Kicad-developers] CvPcb Save

2018-03-20 Thread Jeff Young
I think the cleanest user model would be to make both CvPcb and the Symbol Table alternative views of the document. However, that either suggests a tabbed presentation (where two views are not visible at once), or hooking up CvPcb and the Symbol Table to reflect changes made in the schema.

Re: [Kicad-developers] CvPcb Save

2018-03-20 Thread Bernhard Stegmaier
On a second thought it is basically just another special “Symbol Table” edit dialog. The problem of losing a lot of unsaved work in case of a crash is also there for the “Symbol Table” dialog. I could hack in a lot of valuable data in custom fields and although this dialog has an “Apply”

Re: [Kicad-developers] CvPcb Save

2018-03-20 Thread Jon Evans
Yeah I also agree that it should be basically a dialog of eeschema rather than a separate program, so I guess it makes sense to write changes immediately to the in-memory schematic, and mark it as unsaved for the user to consciously hit the save button later if desired. -Jon On Tue, Mar 20, 2018

Re: [Kicad-developers] CvPcb Save

2018-03-20 Thread Russell Oliver
I second Bernhard's comments. I think it shouldn't seem like a separate program, just another dialog of eeschema that takes the what you see is what you get approach. As long as the footprint references are valid the schematic should be updated when the dialog is closed, and marked modified if

Re: [Kicad-developers] CvPcb Save

2018-03-20 Thread Bernhard Stegmaier
Just my 2 cents… I would immediately write back any change in cvpcb to schematic. I never understood why I have to hit the button to do that. There is no PCB preview or something like that in cvpcb, so I have to apply all changes anyway to check them directly in the PCB. Then, keep the button

Re: [Kicad-developers] CvPcb Save

2018-03-20 Thread Jeff Young
Hi Jon, Just because it’s a bit of a side-effect. It’s not clear to the user that her schematic is going to be saved. She could theoretically have changes there that she wasn’t sure about yet. (Although it seems like a long-shot that she’d then go spend some time in CvPcb, I guess.) Still,

Re: [Kicad-developers] CvPcb Save

2018-03-20 Thread Jon Evans
Why don't you like the idea of saving the schematic when you hit the save button? That seems like a reasonable expected behavior to me at least. (I dislike nag dialogs especially when they seem to have no purpose) -Jon On Tue, Mar 20, 2018 at 1:26 PM, Jeff Young wrote: > CvPcb

[Kicad-developers] CvPcb Save

2018-03-20 Thread Jeff Young
CvPcb has a Save command (complete with disk icon). Only it doesn’t do that. (It simply writes the changes back to eeschema.) If it were a dialog, I’d say that’s not good. But this is CvPcb, where you could easily spend an hour making associations (hitting save every few minutes), only to