Re: [Kicad-developers] DRC changes

In my simple test, the round-off errors are no longer an issue. But I don’t have that exact footprint. Could someone make the testcase (which fails on master) and send me the project + board? Thanks, Jeff. > On 26 Apr 2020, at 16:58, Ian McInerney wrote: > > Is it still subject to the round

Re: [Kicad-developers] DRC changes

Is it still subject to the round-off errors ( https://gitlab.com/kicad/code/kicad/-/issues/4139)? -Ian On Sun, Apr 26, 2020 at 4:30 PM Jeff Young wrote: > New bits up here: https://gitlab.com/kicad/code/kicad/-/merge_requests/193 > > I claim this fixes the rotation problems and should markedly

Re: [Kicad-developers] DRC changes

New bits up here: https://gitlab.com/kicad/code/kicad/-/merge_requests/193 I claim this fixes the rotation problems and should markedly improve performance. Cheers, Jeff. > On 26 Apr 2020, at 15:48, Jeff Young wrote: > > Yeah, rotat

Re: [Kicad-developers] DRC changes

Yeah, rotated rectangles report negative clearances too…. > On 26 Apr 2020, at 15:40, Jeff Young wrote: > > Cool, I’ll look into that. > > I’ve also got some performance improvements to upload. > > Cheers, > Jeff. > >> On 26 Apr 2020, at 15:35, jp charras wrote: >> >> Le 26/04/2020 à 16:15,

Re: [Kicad-developers] DRC changes

—force does the trick. > On 26 Apr 2020, at 15:43, Jeff Young wrote: > > OK, I’ve turned mirroring off. Anyone know how to delete all the other > branches? (I tried through git, but of course run into the same “protected” > issue.) > >> On 26 Apr 2020, at 15:35, Seth Hillbrand >

Re: [Kicad-developers] DRC changes

OK, I’ve turned mirroring off. Anyone know how to delete all the other branches? (I tried through git, but of course run into the same “protected” issue.) > On 26 Apr 2020, at 15:35, Seth Hillbrand wrote: > > Hi Jeff- > > You do not want your fork to mirror KiCad. You don't need the KiCad

Re: [Kicad-developers] DRC changes

Cool, I’ll look into that. I’ve also got some performance improvements to upload. Cheers, Jeff. > On 26 Apr 2020, at 15:35, jp charras wrote: > > Le 26/04/2020 à 16:15, Jeff Young a écrit : >> Hi JP, >> >> Did they report the same number of errors? >> >> Thanks, >> Jeff. >> > > No: > The o

Re: [Kicad-developers] DRC changes

Le 26/04/2020 à 16:15, Jeff Young a écrit : > Hi JP, > > Did they report the same number of errors? > > Thanks, > Jeff. > No: The old algo reports 0 error. The new reports a lot. I am thinking there is an issue with rectangular or round/rect pads rotated by +- 90 deg. -- Jean-Pierre CHARRAS

Re: [Kicad-developers] DRC changes

Hi Jeff- You do not want your fork to mirror KiCad. You don't need the KiCad code mirrored in your fork. You just keep branches there to do personal work. The mirror is prevented you from pushing. -Seth KiCad Services Corporation Seth Hillbrand LEAD DEVELO

Re: [Kicad-developers] DRC changes

Hi Ian, Yeah, I tried just pushing the branch first, but it does the same thing. I think I need to either delete all the other branches by hand, or turn off the “mirror” property (as that might force pushing of all branches). Cheers, Jeff. > On 26 Apr 2020, at 15:21, Ian McInerney wrote: >

Re: [Kicad-developers] DRC changes

Did you clone your personal fork to you computer? If so you should be able to just use `git push` to push to push to your remote fork. You should also add a remote link to the main repo by running the following command: git remote add upstream g...@gitlab.com:kicad/code/kicad.git When you want

Re: [Kicad-developers] DRC changes

Try pushing only the branch you are actively working on to your personal repo. In my setup, I have 2 remotes: 1) product - this is the main KiCad repo 2) personal - this is my personal fork When I am working on a feature branch (called im/featurebranch) I push it to my personal repo like this: `g

Re: [Kicad-developers] DRC changes

Hi JP, Did they report the same number of errors? Thanks, Jeff. > On 26 Apr 2020, at 15:03, jp charras wrote: > > Le 26/04/2020 à 14:27, Jeff Young a écrit : >> I have added code to many DRC errors which shows the minimum clearance, its >> source, and the actual clearance. >> >> The old DRC

Re: [Kicad-developers] DRC changes

So I set jeffyoung/kicad as a remote named “public” and set as a mirror. But when I push to it I get a bunch of errors: Jeffs-MBP:kicad jeff$ git push public Enter passphrase for key '/Users/jeff/.ssh/id_rsa': Enumerating objects: 3601, done. Counting objects: 100% (2535/2535), done. Delta comp

Re: [Kicad-developers] DRC changes

Le 26/04/2020 à 14:27, Jeff Young a écrit : > I have added code to many DRC errors which shows the minimum clearance, its > source, and the actual clearance. > > The old DRC code was pretty heavily optimised around the idea of only needing > to know if the clearance was violated (and not by how

Re: [Kicad-developers] DRC changes

Never mind. That page explains how to do the later. > On 26 Apr 2020, at 14:56, Jeff Young wrote: > > And then the merge request, is that from jeff/kicad:jeffDRC to > jeff/kicad:master, or is there some way to do a merge request from > jeff/kicad:jeffDRC to kicad/code/kicad:master? > >> On

Re: [Kicad-developers] DRC changes

And then the merge request, is that from jeff/kicad:jeffDRC to jeff/kicad:master, or is there some way to do a merge request from jeff/kicad:jeffDRC to kicad/code/kicad:master? > On 26 Apr 2020, at 14:50, Ian McInerney wrote: > > Jeff, > > From the main repository page, simply click on "Fork"

Re: [Kicad-developers] DRC changes

Jeff, >From the main repository page, simply click on "Fork" at the top of the page. Then you create it inside your Personal namespace. Once you do that, the fork can just become a new remote in your git repository. https://docs.gitlab.com/ee/user/project/repository/forking_workflow.html#creating

Re: [Kicad-developers] DRC changes

Do I fork the project and put it in my “namespace”? > On 26 Apr 2020, at 14:47, Jeff Young wrote: > > I don’t have a personal repo. Is it (reasonably) obvious how to create one? > >> On 26 Apr 2020, at 14:32, Wayne Stambaugh wrote: >> >> Hi Jeff, >> >> Would you please move your working bra

Re: [Kicad-developers] DRC changes

I don’t have a personal repo. Is it (reasonably) obvious how to create one? > On 26 Apr 2020, at 14:32, Wayne Stambaugh wrote: > > Hi Jeff, > > Would you please move your working branch from the main repo to your > personal repo and create a merge request? This will make it much easier > to t

Re: [Kicad-developers] DRC changes

Hi Jeff, Would you please move your working branch from the main repo to your personal repo and create a merge request? This will make it much easier to test and avoid poluting the main repo with developers personal working branches. Thanks, Wayne On 4/26/20 8:27 AM, Jeff Young wrote: > I have

[Kicad-developers] DRC changes

I have added code to many DRC errors which shows the minimum clearance, its source, and the actual clearance. The old DRC code was pretty heavily optimised around the idea of only needing to know if the clearance was violated (and not by how much), so a lot of it has been re-written. For this