Re: [Kicad-developers] Datasheet confusion

2017-10-23 Thread Wayne Stambaugh
Kristoffer, I merged your patch into the master branch. Thank you for your contribution to KiCad. Cheers, Wayne On 10/19/2017 11:53 AM, Kristoffer Ödmark wrote: > I tested the GetAssociatedDocument, works much better and has more > features so i took the freedom of updating the dialog windows

Re: [Kicad-developers] Datasheet confusion

2017-10-23 Thread Wayne Stambaugh
On 10/23/2017 3:52 PM, Kevin Cozens wrote: > On 2017-10-13 06:01 AM, Oliver Walters wrote: >> Very interesting history JP! I think we are all looking forward to the >> new library format :) > > When I read about a new library format I start wondering (worrying?) > what impact the change will have

Re: [Kicad-developers] Datasheet confusion

2017-10-23 Thread Kevin Cozens
On 2017-10-13 06:01 AM, Oliver Walters wrote: Very interesting history JP! I think we are all looking forward to the new library format :) When I read about a new library format I start wondering (worrying?) what impact the change will have on my existing schematics. I have already seen

Re: [Kicad-developers] Datasheet confusion

2017-10-23 Thread Wayne Stambaugh
Kristoffer, Sorry about the delay. I applied your patch and did some testing last night but I just ran out of time. I should get it pushed this evening barring anything unexpected. Wayne On 10/23/2017 3:52 AM, Kristoffer Ödmark wrote: > Seems there are no major objections :) Bumping this so

Re: [Kicad-developers] Datasheet confusion

2017-10-23 Thread Kristoffer Ödmark
Seems there are no major objections :) Bumping this so it doesnt get lost in history :) On 10/19/2017 09:57 PM, Wayne Stambaugh wrote: Looks good to me. If there are no major objections I will merge this patch. On 10/19/2017 11:53 AM, Kristoffer Ödmark wrote: I tested the

Re: [Kicad-developers] Datasheet confusion

2017-10-19 Thread Wayne Stambaugh
Looks good to me. If there are no major objections I will merge this patch. On 10/19/2017 11:53 AM, Kristoffer Ödmark wrote: > I tested the GetAssociatedDocument, works much better and has more > features so i took the freedom of updating the dialog windows to use > that instead of the

Re: [Kicad-developers] Datasheet confusion

2017-10-19 Thread Kristoffer Ödmark
I tested the GetAssociatedDocument, works much better and has more features so i took the freedom of updating the dialog windows to use that instead of the wxLaunchDefaultBrowser as well attaching patch :) - Kristoffer On 10/19/2017 02:07 PM, Wayne Stambaugh wrote: On 10/19/2017 7:09 AM,

Re: [Kicad-developers] Datasheet confusion

2017-10-19 Thread Wayne Stambaugh
On 10/19/2017 7:09 AM, Kristoffer Ödmark wrote: > Yes indeed it breaks that, I would argue that having an "invisible" > field opened when using the context field is the source of the > confusion. So I am aware it breaks the context menu for old schematics > but think it is necessary anyway. I'm

Re: [Kicad-developers] Datasheet confusion

2017-10-19 Thread Kristoffer Ödmark
Yes indeed it breaks that, I would argue that having an "invisible" field opened when using the context field is the source of the confusion. So I am aware it breaks the context menu for old schematics but think it is necessary anyway. I can of course use GetAssociatedDocument instead. On Oct

Re: [Kicad-developers] Datasheet confusion

2017-10-19 Thread jp charras
Le 18/10/2017 à 20:20, Kristoffer Ödmark a écrit : > Glad to hear it, I fixed a patch up that will highlight the differences a bit > better than I explain it. > > Basically it will fill the field from the properties if the field is empty > when adding components to > the schematic. > > It will

Re: [Kicad-developers] Datasheet confusion

2017-10-18 Thread Kristoffer Ödmark
Glad to hear it, I fixed a patch up that will highlight the differences a bit better than I explain it. Basically it will fill the field from the properties if the field is empty when adding components to the schematic. It will also use the Field to determine when to show the context menu

Re: [Kicad-developers] Datasheet confusion

2017-10-16 Thread Fabrizio Tappero
Hi Kristoffer, I am a big supporter of this option. I am often in need of showing a datasheet with a right click on component. It would be great to be able to do it in the completed schematic as well as in the completed pcb layout. cheers Fabrizio On Fri, Oct 13, 2017 at 2:18 PM, Kristoffer

Re: [Kicad-developers] Datasheet confusion

2017-10-13 Thread Kristoffer Ödmark
There is a "show documentation" context field, but it only uses the documentation string, so if i put a value into the datasheet field. The menu doesnt show, I do not think that adding a "Show documentation" and a "Show Datasheet" is a good solution. I will create a patch, probably this

Re: [Kicad-developers] Datasheet confusion

2017-10-13 Thread Wayne Stambaugh
On 10/13/2017 6:19 AM, Kristoffer Ödmark wrote: > Thanks you very much for that clarification, I for one would really > enjoy a clarification of the documentation and Datasheet string. KiCad > has been around for quite a while now, interesting how technology has > changed during that time. > >

Re: [Kicad-developers] Datasheet confusion

2017-10-13 Thread Wayne Stambaugh
On 10/13/2017 2:51 AM, jp charras wrote: > Le 13/10/2017 à 00:23, Wayne Stambaugh a écrit : >> On 10/12/2017 1:52 PM, Kristoffer Ödmark wrote: >>> >>> On 10/12/2017 06:56 PM, Wayne Stambaugh wrote: Kristoffer, There is no confusion and there is nothing to fix.  The document field

Re: [Kicad-developers] Datasheet confusion

2017-10-13 Thread Kristoffer Ödmark
Thanks you very much for that clarification, I for one would really enjoy a clarification of the documentation and Datasheet string. KiCad has been around for quite a while now, interesting how technology has changed during that time. For another question, would It be okay to redirect the

Re: [Kicad-developers] Datasheet confusion

2017-10-13 Thread Oliver Walters
Very interesting history JP! I think we are all looking forward to the new library format :) On 13 Oct 2017 17:51, "jp charras" wrote: > Le 13/10/2017 à 00:23, Wayne Stambaugh a écrit : > > On 10/12/2017 1:52 PM, Kristoffer Ödmark wrote: > >> > >> On 10/12/2017 06:56 PM,

Re: [Kicad-developers] Datasheet confusion

2017-10-13 Thread jp charras
Le 13/10/2017 à 00:23, Wayne Stambaugh a écrit : > On 10/12/2017 1:52 PM, Kristoffer Ödmark wrote: >> >> On 10/12/2017 06:56 PM, Wayne Stambaugh wrote: >>> Kristoffer, >>> >>> There is no confusion and there is nothing to fix.  The document field >>> is just like any other field.  It is initially

Re: [Kicad-developers] Datasheet confusion

2017-10-12 Thread Wayne Stambaugh
On 10/12/2017 1:52 PM, Kristoffer Ödmark wrote: > > On 10/12/2017 06:56 PM, Wayne Stambaugh wrote: >> Kristoffer, >> >> There is no confusion and there is nothing to fix.  The document field >> is just like any other field.  It is initially imported from the library >> symbol to the schematic

Re: [Kicad-developers] Datasheet confusion

2017-10-12 Thread Kristoffer Ödmark
On 10/12/2017 06:56 PM, Wayne Stambaugh wrote: Kristoffer, There is no confusion and there is nothing to fix. The document field is just like any other field. It is initially imported from the library symbol to the schematic symbol (they are *not* the same nor should they be) when a symbol

Re: [Kicad-developers] Datasheet confusion

2017-10-12 Thread Wayne Stambaugh
Kristoffer, There is no confusion and there is nothing to fix. The document field is just like any other field. It is initially imported from the library symbol to the schematic symbol (they are *not* the same nor should they be) when a symbol is added to the schematic. Once you modify a field

Re: [Kicad-developers] Datasheet confusion

2017-10-12 Thread Rene Pöschl
On 12/10/17 15:12, Kristoffer Ödmark wrote: Sorry for double messages but one solution could be to use the Library stored documentation to autofill the FIELD variable IF it is empty. And then base all the functionality on the field variable? I could probably fix this if it seems an okay

Re: [Kicad-developers] Datasheet confusion

2017-10-12 Thread Kristoffer Ödmark
Sorry for double messages but one solution could be to use the Library stored documentation to autofill the FIELD variable IF it is empty. And then base all the functionality on the field variable? I could probably fix this if it seems an okay solution to everyone? This would basically be

[Kicad-developers] Datasheet confusion

2017-10-12 Thread Kristoffer Ödmark
Hey! I noticed today that there are two places to store the datasheet information, one is in the Mandatory Field "Datasheet", and one is in the porperty of the part in the lib. These have different functionality in the schematic editor and in the library part editor. I think these should