Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

Hi Metacollin, Sorry about that. I thought this was already merged. I merged you patch. Thank you for your contribution to KiCad. Cheers, Wayne On 4/26/2018 3:25 AM, metacollin wrote: > Yes, it causes cmake to recursively consume all free disk space unless killed > if the user happens to

Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

Yes, it causes cmake to recursively consume all free disk space unless killed if the user happens to set their install path to the current working directory. This is actually required for integration with certain package managers (well, ok, one package manager, homebrew). I should have mate

Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

Yes, that one should be merged. Wayne On 03/23/2018 08:37 AM, Adam Wolf wrote: > Please note, one of the pull requests, the packages3d one I think, has > an unrelated change bundled with it that I think should definitely be > merged in. > > Adam > > On Fri, Mar 23, 2018 at 7:29 AM, Wayne

Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

Please note, one of the pull requests, the packages3d one I think, has an unrelated change bundled with it that I think should definitely be merged in. Adam On Fri, Mar 23, 2018 at 7:29 AM, Wayne Stambaugh wrote: > On 03/22/2018 04:51 PM, Mathias Grimmberger wrote: >> >>

Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

On 03/22/2018 04:51 PM, Mathias Grimmberger wrote: > > Hi everybody, > > Wayne Stambaugh writes: > >> If someone would pin down the exact version of cmake where this >> available, I would appreciated it. My benchmark (Debian stable) is >> currently shipping with 3.7.2

Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

Hi everybody, Wayne Stambaugh writes: > If someone would pin down the exact version of cmake where this > available, I would appreciated it. My benchmark (Debian stable) is > currently shipping with 3.7.2 although that seems like a pretty current > version. I don't want

Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

Hello Rene, Am 22.03.18 um 15:13 schrieb Rene Pöschl: > Dear developers, > > we lib maintainers might be good at checking symbols and footprints > against datasheets, the KLC and industry standards but we are a bit lost > with the requirements of installation scripts. > > Could one of you

Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

What do you mean with “Xcode to build KiCad” (or, what do you want to do)? Usually KiCad is built with clang from Xcode, so yes. Xcode itself is only an IDE. You definitely can use Xcode to edit source files or to debug KiCad built with usual cmake command line (just create an “empty" project

Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

I Have a question for the OS X developers here. Are you using Xcode to build KiCAD? I would like to get started on building KiCAD with Xcode, so I am looking for some clues or advice if this is not possible/practical. Thanks to all of you for a great product. Jean-Paul N1JPL > On Mar 22,

Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

If someone would pin down the exact version of cmake where this available, I would appreciated it. My benchmark (Debian stable) is currently shipping with 3.7.2 although that seems like a pretty current version. I don't want to bump the cmake version too high and drop a bunch of linux distros

Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

This will break the nightlies for macOS, as the packaging scripts currently work around the fact that they didn't previously work on macOS with modifications. Is this something Nick or I can adjust the current nightlies to over the weekend, and then we make the cutover in the middle of next week?

Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

​CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT​ is a relatively recent addition to cmake. Maybe 3.7 or so? I'd hesitate using that in the install script yet but maybe that's overly cautious. If you do use it, we need to bump the minimum version at the top as well. -S 2018-03-22 7:20 GMT-07:00

Re: [Kicad-developers] Lib maintainers request help for reviewing installation script changes

Looks fine to me but I would like one of our macos packagers to confirm the install path changes that are specific to macos before we merge them. On 3/22/2018 10:13 AM, Rene Pöschl wrote: > Dear developers, > > we lib maintainers might be good at checking symbols and footprints > against

[Kicad-developers] Lib maintainers request help for reviewing installation script changes

Dear developers, we lib maintainers might be good at checking symbols and footprints against datasheets, the KLC and industry standards but we are a bit lost with the requirements of installation scripts. Could one of you take a look at the changes in the following pull requests? -