Re: [Kicad-developers] disable icons in menus by default on osx

The correct way to fix this would be to leave the #ifdef in place and put m_useIconsInMenus in the Read() setting function as the default so the correct default value is used the first time kicad is run. Your change makes off the default for all platforms which doesn't fix the underlying issue.

Re: [Kicad-developers] disable icons in menus by default on osx

Doesn't matter to me (although I personally always turn them off). I was just pointing out that the code didn't appear to work as it was intended to on macOS and provided an alternative. Michael On 12 September 2017 at 16:28, Wayne Stambaugh wrote: > Do we really need to

Re: [Kicad-developers] disable icons in menus by default on osx

Do we really need to change the default? All this will do is change which group of users complains about the default setting. The reason we changed this is that some users wanted the menu bitmaps even on platforms where it is recommended not to use them. I just don't see any benefit to making

Re: [Kicad-developers] disable icons in menus by default on osx

On 9/11/2017 1:51 PM, Diogo Condeço wrote: > While personally I won't use icons in the menus if that option is > available to me, I can see why someone would like to use them.  > > I can see it being useful to identify actions visually, but with that in > mind, I can't understand why having icons

Re: [Kicad-developers] disable icons in menus by default on osx

Hi Diogo, thanks for point it our. This has been fixed in a patch that is currently in the pipeline. Cheers Fabrizio On Mon, Sep 11, 2017 at 7:51 PM, Diogo Condeço wrote: > While personally I won't use icons in the menus if that option is > available to me, I can see

Re: [Kicad-developers] disable icons in menus by default on osx

While personally I won't use icons in the menus if that option is available to me, I can see why someone would like to use them. I can see it being useful to identify actions visually, but with that in mind, I can't understand why having icons and reusing them on different functions would help

Re: [Kicad-developers] disable icons in menus by default on osx

I personally (as a user) find the icons visually more intuitive. Specially for newcomers and better adoption of KiCad. I know it's out of some guidelines, but this is a very complex software. My feeling is that it's better with a "on" by default setting, as long as people already used to the

Re: [Kicad-developers] disable icons in menus by default on osx

Hi, Sorry to bring this up again, but for me icons are still enabled by default on macOS (and Windows unsurprisingly). I deleted /Library/Application Support/kicad, ~/Library/Preferences/kicad and /Applications/Kicad, reinstalled from most recent nightly (07-Sep-2017) and the icons were there

Re: [Kicad-developers] disable icons in menus by default on osx

Simon, I committed your patch since osx expects the icons to be disabled by default. Thanks, Wayne On 4/8/2017 6:42 AM, Simon Wells wrote: > Please see attached patch to disable icons in the menus by default on osx > > > > ___ > Mailing list:

Re: [Kicad-developers] disable icons in menus by default on osx

> On Apr 10, 2017, at 12:12 PM, Wayne Stambaugh wrote: > > I thought the reason that we added this option is so that users could > choose if they wanted to show the icons in menus. I seem to remember > from the original discussion that some of our osx users didn't like

Re: [Kicad-developers] disable icons in menus by default on osx

this is only a single #ifdef to default it to off as osx has been as long as i have been using it, its not compiling the icons out or anything On 11 April 2017 at 07:12, Wayne Stambaugh wrote: > I thought the reason that we added this option is so that users could > choose

Re: [Kicad-developers] disable icons in menus by default on osx

I thought the reason that we added this option is so that users could choose if they wanted to show the icons in menus. I seem to remember from the original discussion that some of our osx users didn't like the fact that they were compiled out of osx builds. Do we really need to add the ugly #if

[Kicad-developers] disable icons in menus by default on osx

Please see attached patch to disable icons in the menus by default on osx kicad_iconsmenu_disable_osx.patch Description: Binary data ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net