[Kicad-developers] [PATCH v2] Make EDA_ITEM::Clone() abstract

2016-04-26 Thread Simon Richter
--- 3d-viewer/3d_material.h| 3 +++ 3d-viewer/3d_struct.h | 2 ++ common/base_struct.cpp | 7 --- eeschema/class_libentry.h | 6 ++ eeschema/class_sch_screen.h| 3 +++ gerbview/class_gbr_screen.h

[Kicad-developers] Optimization

2016-04-26 Thread Chris Pavlina
Hi, I hope I don't sound ranty - but really, I think we need to put in place some policy about well-meaning but ineffective optimizations. They're one of the quickest ways to screw up maintainability and introduce the possibility of errors. I strongly suspect 6711 "Optimize VECTOR2::Rotation for

Re: [Kicad-developers] Optimization

2016-04-26 Thread Chris Pavlina
Okay, the numbers aren't quite so nice. I posted the wrong ones and now have egg on my face. That's what I get for playing around with git too much. I still stand by what I said about needing to show improvement, though. While the new code *does* improve things by about 15% on my computer when I

Re: [Kicad-developers] Optimization

2016-04-26 Thread Javier Loureiro Varela
I was a vfx render engine engenieer for years, and I can tell you that it is really easy to mess up things with "optimization". I didnt check the code for this particular case, but a simple test with a loop is not enough to tell you if an optimization means something. - It can make the funcion