[Kicad-developers] [PATCH] Fix for bug/1754049

https://bugs.launchpad.net/kicad/+bug/1754049 This patch follows the edict (stated in dialog_layers_setup.cpp) that items on a layer that is removed must be deleted. From 2a77ec7609cccf70f17d7e830237006c1d72d528 Mon Sep 17 00:00:00 2001 From: hauptmech Date: Wed, 14 Mar 2018

Re: [Kicad-developers] who's responsible for translations?

Marco Ciampa led the effort for our current translation setup but I haven't heard from him for a while. Then again that could be because I've been inactive with kicad for almost 2 years. Cirilo On Wed, Mar 14, 2018 at 3:43 AM, Tomasz Wlostowski wrote: > Hi all, > >

Re: [Kicad-developers] who's responsible for translations?

On Tue, Mar 13, 2018 at 05:43:02PM +0100, Tomasz Wlostowski wrote: > Hi all, > > Sorry for a possibly dumb question - I've been recently contacted by a > Polish translator who localized the V5 RC and submitted his > contributions to me. Who is officially responsible for managing > translations of

Re: [Kicad-developers] [PATCH] Fix for bug/1754049

If I read your patch correctly it's only halfway there. You should possibly modify getRemovedLayersWithItems(), too. Otherwise it looses even more data without a warning. Am I correct? 2018-03-14 11:54 GMT+02:00 hauptmech : > https://bugs.launchpad.net/kicad/+bug/1754049 > >

[Kicad-developers] wxGrid boolean changes

Hi all, I recently (2f86b497) changed the behavior of the wxGrid in the footprint wizard dialog to fix some issues with boolean (checkbox) parameters. The default behavior from wxWidgets (at least in 3.0) is buggy in that the update events don't get sent out when you'd expect from the

Re: [Kicad-developers] wxGrid boolean changes

Hi Jon, I implemented (1), (3) and (4) in 6.0. It was tweaky enough that I don’t recommend it for 5.0 (but I don’t fee strongly). You can see my implementation here: https://git.launchpad.net/~jeyjey/kicad/commit/?h=6.0=7dda85fdae21f162bd7413fdceb16e49698f31bf

Re: [Kicad-developers] compil warning in eagle plugin.

Hi Jean-Pierre, I have just fixed it. Fortunately, 'radius' is used in a while loop that requires the preceding if clause to be true. 'Radius' is initialized in the mentioned if clause body, so it should never run with an uninitialized value. Regards, Orson On 03/14/2018 03:21 PM, jp charras

Re: [Kicad-developers] Making typed-in unit support more obvious

I'm just wondering if this will make typed in unit support more obvious or if it will lead to more confusion. I guess we could try it and see what happens. On 3/14/2018 11:19 AM, Jeff Young wrote: > Hi Wayne, > > The units would still be displayed, just in the box instead of out of it. We >

Re: [Kicad-developers] Need guidance/hints on accessing list of available pcbnew footprints from python

On 3/14/2018 11:04 AM, miles mccoo wrote: > Thanks for the tips, Orson. That gave me what I needed, sort of. > Additional guidance needed. > > > > Let me describe what I have working and everyone can tell me if I > understood everything correctly. You may want things moved around a bit > as

Re: [Kicad-developers] wxGrid boolean changes

I gave it a try and there is some strange behavior on Linux :-( Clicks on the checkboxes seem to sometimes get handled twice so the box quickly toggles between states. So, I don't think it should be merged as-is. Can you guys confirm that the behavior is good from my version (as implemented in

Re: [Kicad-developers] [PATCH] Fix for bug/1754049

On 15 Mar 2018 05:17, "Seth Hillbrand" wrote: Hi hautmech- Looks good. Two comments: - Code style. There are a couple of small issues: one line is too long, there should be spaces in parentheses for pad->GetParent()->Remove(pad) and no space before parentheses in

Re: [Kicad-developers] [PATCH] Fix for bug/1754049

Hi hautmech- Looks good. Two comments: - Code style. There are a couple of small issues: one line is too long, there should be spaces in parentheses for pad->GetParent()->Remove(pad) and no space before parentheses in "if ( pad->GetLayerSet()..." - We need to handle the case where all items

Re: [Kicad-developers] Why do current nightlies report that they are kicad 5.0.0-rc2?

Here is what I will do that should work. I will leave the current version tag and version string as is until rc2 is released. From there on I will only update the version string in KiCadVersion.cmake to 5.0.0-rc2-unknown in the next commit after the tag. This way the version string will will be

Re: [Kicad-developers] [PATCH] Fix for bug/1754049

Wrong alert, the compilation completed and it seems to work. Apparently "collector" handles it. 2018-03-14 15:41 GMT+02:00 Eeli Kaikkonen : > If I read your patch correctly it's only halfway there. You should > possibly modify getRemovedLayersWithItems(), too. Otherwise

Re: [Kicad-developers] Making typed-in unit support more obvious

On 3/13/2018 5:58 AM, Jeff Young wrote: > There’s a wishlish item to make support for typed-in units more discoverable. > > I think the easiest way to do this is to adopt a policy of removing unit > static-texts following a value textCtrl in favour of displaying the current > units in the text.

Re: [Kicad-developers] wxGrid boolean changes

IIRC, it was tricky to get right because you can’t fire it when the cell *does* have focus or wxWidgets gets itself tied in knots. (It turns out that’s OK because when it does have focus wxWidgets toggles it with a single-click anyway.) It was also a bit tricky around reference counting. The

Re: [Kicad-developers] Need guidance/hints on accessing list of available pcbnew footprints from python

Thanks for the tips, Orson. That gave me what I needed, sort of. Additional guidance needed. Let me describe what I have working and everyone can tell me if I understood everything correctly. You may want things moved around a bit as well. *high level view* is that I added

Re: [Kicad-developers] wxGrid boolean changes

Thanks Jeff, it doesn't look like that big a change but if you think it should wait I don't feel strongly, except that it might make maintenance more annoying if we have one implementation in 5.0 and one in 6.0. Anyone else have opinions on this? I think (2) should be added to Jeff's

[Kicad-developers] compil warning in eagle plugin.

Could a Eagle guru have a look into the code creating this compil warning: F:/kicad-launchpad/zone_on_grid/pcbnew/eagle_plugin.cpp:1811:50: warning: 'radius' may be used uninitialized in this function [-Wmaybe-uninitialized] wxPoint end( int( radius * cos( end_angle +

Re: [Kicad-developers] Making typed-in unit support more obvious

Hi Wayne, The units would still be displayed, just in the box instead of out of it. We already do this for some grids (for instance Edit > Edit All Tracks and Vias). Cheers, Jeff > On 14 Mar 2018, at 13:59, Wayne Stambaugh wrote: > > On 3/13/2018 5:58 AM, Jeff Young

Re: [Kicad-developers] Need guidance/hints on accessing list of available pcbnew footprints from python

from Jeff: *wxArrayString footprintNames;* *fp_table->FootprintEnumerate( footprintNames, nullptr )* *will load footprintNames with all the footprints.* That method doesn't take a nullptr. From fp_lib_table.h: void FootprintEnumerate( wxArrayString& aFootprintNames, *const wxString&* aNickname

Re: [Kicad-developers] Need guidance/hints on accessing list of available pcbnew footprints from python

Sorry, I meant wxEmptyString, not nullptr. The string argument tells the routine to enumerate only the one .pretty file; if you pass the empty string then it will enumerate all of the .pretty files in the fp-lib-table. > On 14 Mar 2018, at 21:17, miles mccoo wrote: > >

Re: [Kicad-developers] Need guidance/hints on accessing list of available pcbnew footprints from python

footprint enumerate doesn't like wxnullstring (see hang below) and it only looks at one row. No iterator in there. *How do I iterate over the rows?* note that there is also PCB_IO::FootprintEnumerate (some would call it a plugin) that behaves different. It's the one used in footprint.i. void

Re: [Kicad-developers] Procedure for notifying devs of upstream requirement change?

We've just used the list. I wouldn't mind a subject tag for things aimed at packagers, but I am also just fine without it. Adam On Mar 14, 2018 2:26 PM, "Jeff Young" wrote: > I’ve got a bug fix to https://bugs.launchpad.net/kicad/+bug/1754741 that’s > going to require a change

Re: [Kicad-developers] wxGrid boolean changes

@Wayne, any opinion on this one? Should I merge it or play it safe and leave it in 6.0? > On 14 Mar 2018, at 14:12, Jeff Young wrote: > > IIRC, it was tricky to get right because you can’t fire it when the cell > *does* have focus or wxWidgets gets itself tied in knots.

Re: [Kicad-developers] [RFC] Experimental grid pattern in zone fill

it might be usefull to have a look at 3D slicer softwares, they all implement something similar to generate inner structure of objects, with a very large set of options to control density, direction, pattern and so on Le 14/03/2018 à 20:17, Vesa Solonen a écrit : jp charras kirjoitti

Re: [Kicad-developers] [RFC] Experimental grid pattern in zone fill

Apropos manufacturability. It would be good if the zone fill pattern options included copper thieving patterns too. http://speedingedge.com/files/2415/1077/5209/What_is_Thieving.pdf Cheers, Piotr > On Mar 14, 2018, at 12:17

Re: [Kicad-developers] [RFC] Experimental grid pattern in zone fill

jp charras kirjoitti 13/03/18 klo 22:25: > The zone as polygon is the best way for me. > > Removing holes in filled areas is not time consuming. It might be beneficial to include corner radius or chamfer to grid cutouts. The idea is to avoid sharp corners that cause problems with etching and

[Kicad-developers] Procedure for notifying devs of upstream requirement change?

I’ve got a bug fix to https://bugs.launchpad.net/kicad/+bug/1754741 that’s going to require a change to our Mac wxWidgets branch. So for this one, I only need to notify Mac developers that they need to pull the latest wxWidgets or they’ll get a

Re: [Kicad-developers] Need guidance/hints on accessing list of available pcbnew footprints from python

Wayne said: *The footprint library table internally handles fallback library tablesso you can iterate over all of the same information available no matterhow deeply nested the fallback tables are from the project library tablewithout exposing the fallback table pointer. If you cannot access

Re: [Kicad-developers] Need guidance/hints on accessing list of available pcbnew footprints from python

Hi Miles, wxArrayString footprintNames; fp_table->FootprintEnumerate( footprintNames, nullptr ) will load footprintNames with all the footprints. So in GDB you need to be looking at the size of aFootprintNames, not fp_table. Cheers, Jeff. > On 14 Mar 2018, at 20:01, miles mccoo

Re: [Kicad-developers] wxGrid boolean changes

Yep, only tested on OSX.Patch attached.Cheers,Jeff. 0019-Don-t-make-users-click-twice-on-wxGrid-checkboxes.patch Description: Binary data On 14 Mar 2018, at 19:56, Wayne Stambaugh wrote:I'm assuming you only tested this on macos correct?  If so, pleasesubmit a patch so we

Re: [Kicad-developers] Need guidance/hints on accessing list of available pcbnew footprints from python

Yeah, I think you’re below the level I thought you were at. You can use: fp_table->GetLogicalLibs() to return a list of nicknames that you can then pass to FootprintEnumerate(). Don’t use the one in PCB_IO: that only works for the current kicad format and won’t handle legacy footprints, eagle