[Kicad-developers] [PATCH] Hide Power component value text cannot be modified in libedit
When I submitted the patch to allow editing power component value text properties, I didn't realize that the edit dialog base class was subclassed /twice/ - I missed a required edit to the libedit subclass of it, so the Power component value text cannot be modified! warning is not properly hidden when editing texts in libedit. Here's a quick patch to fix that. -- Chris diff --git a/eeschema/dialogs/dialog_lib_edit_text.cpp b/eeschema/dialogs/dialog_lib_edit_text.cpp index 778fa89..8d8a519 100644 --- a/eeschema/dialogs/dialog_lib_edit_text.cpp +++ b/eeschema/dialogs/dialog_lib_edit_text.cpp @@ -134,6 +134,10 @@ void DIALOG_LIB_EDIT_TEXT::initDlg( ) // Hide the select button as the child dialog classes use this m_TextValueSelectButton-Hide(); + +// Hide the Power component value text cannot be modified! warning +m_PowerComponentValues-Show( false ); +Fit(); } ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] Hide Power component value text cannot be modified in libedit
Le 17/04/2015 16:40, Chris Pavlina a écrit : When I submitted the patch to allow editing power component value text properties, I didn't realize that the edit dialog base class was subclassed /twice/ - I missed a required edit to the libedit subclass of it, so the Power component value text cannot be modified! warning is not properly hidden when editing texts in libedit. Here's a quick patch to fix that. -- Chris Committed. Thanks. -- Jean-Pierre CHARRAS ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Fwd: Documentation update
I'm nearly ready for a pull request. I've just committed changes to my repo so that PDF and HTML can be built on Windows and Linux. Both dblatex and FOP are supported for PDF generation on Linux and Windows, however I cannot get the dblatex PDF build to complete on Windows because of a problem with the xlstproc I'm using. Perhaps someone will have better luck than me. Because of that, I've noted in cmake-readme.adoc in my repo that only FOP is suppored under Windows. CMake just does feature checking, not platform checking, so you can give anything that's supported a go. Getting the full dblatex tool chain seutp on Windows is a bit of a pain! Best Regards, Brian. On 14 April 2015 at 00:52, Nick Østergaard oe.n...@gmail.com wrote: Great. Den 13/04/2015 22.57 skrev Brian Sidebotham brian.sidebot...@gmail.com: I sync'd with Marco's repo so that's now reflected in my repo. I just need to do the po update stuff I think and then I'll do a pull request to get the repo's aligned. Best Regards, Brian. On 12 April 2015 at 23:12, Nick Østergaard oe.n...@gmail.com wrote: I have now done this. 2015-04-11 13:48 GMT+02:00 Nick Østergaard oe.n...@gmail.com: So now is a good time to remove the src/markdown and src/rest and move src/asciidoc to src? If so, I can do that now, such that you can pull those changes. 2015-04-11 13:43 GMT+02:00 Brian Sidebotham brian.sidebot...@gmail.com: On 11 April 2015 at 12:32, Brian Sidebotham brian.sidebot...@gmail.com wrote: On 11 April 2015 at 12:11, Nick Østergaard oe.n...@gmail.com wrote: Great. I just looked briefly on the cmake setup. It seems to me like you intend to include a CMakeLists.txt inside each doc dir with the only change being the name or path of the root adoc file. Would it not mere more sense to have a common CMakeLists.txt in the src/asciidoc dir (to be renamed just src when we remove the markdown and rest variants), which searches the folders or is just given an array of root doc files? Things will change, I've just begun the start of adding macros to create pdf and html targets. There's plenty more work to do yet. Certainly there'll be a lot of common code that can be shared through higher level cmake files. The initial plan was to get CvPcb translation and generation complete. Once the repo achieves that, I can pull request it into Marco's repo and then hopefully there'll be plenty of resource to complete the CMake stuff, then Marco's repo will come under the KiCad umbrella. Best Regards, Brian. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] V4 Rectangular pads with rounded corners
I don't think so. Me myself have not even got around to test the patch. Since little to no response has been seen from the main developers, I guess thaty have not yet found the time. I doubt it will be in the release, but that is mainly Wayne that decides that. It probably needs some testing, so you could try to see if you can make it fail. 2015-04-18 0:40 GMT+02:00 Kaspar Emanuel kaspar.eman...@gmail.com: Was this applied, will it be in stable? I am interested mainly because of my library that works with .kicad_mod files. On 2 March 2015 at 01:57, LordBlick lordbl...@gmail.com wrote: In response to a message written on 02.03.2015, 02:41, from Jon Neal: Any chance you can attach this a patch file? Maybe is it ? -- Best Regards, LordBlick ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] [PATCH] V4 Rectangular pads with rounded corners
Was this applied, will it be in stable? I am interested mainly because of my library that works with .kicad_mod files. On 2 March 2015 at 01:57, LordBlick lordbl...@gmail.com wrote: In response to a message written on 02.03.2015, 02:41, from Jon Neal: Any chance you can attach this a patch file? Maybe is it ? -- Best Regards, LordBlick ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
