Re: [Kicad-developers] [PATCH] add missing parentheses in page layout templates

On 2016-09-08 20:56, Werner Almesberger wrote: > The default and logo page layout templates are missing some opening > parentheses. Eeschema's parser accepts them anyway, but it tripped > my s-expr parser. Is accepting a wrong syntax without a warning not a bug worth fixing? Regards, Clemens

[Kicad-developers] [PATCH] make pagelayout_default.kicad_wks match defaultPageLayout

The pagelayout_default.kicad_wks template differs slightly from common/page_layout/page_layout_default_description.cpp:defaultPageLayout Not sure if this is intentional or a bug. In any case, here is a patch that changes pagelayout_default.kicad_wks to match defaultPageLayout. This patch is

[Kicad-developers] [PATCH v2] Add KICAD_INSTALL_DEMOS CMake option

It is ON by default, determines wether to install the bundled demos and examples. --- This version has the required documentation changes. --- CMakeLists.txt | 6 ++ Documentation/development/compiling.md | 7 +++ 2 files changed, 13 insertions(+) diff --git

[Kicad-developers] [PATCH] add missing parentheses in page layout templates

The default and logo page layout templates are missing some opening parentheses. Eeschema's parser accepts them anyway, but it tripped my s-expr parser. The gost templates and the built-in default in common/page_layout/page_layout_default_description.cpp are both correct. - Werner commit

Re: [Kicad-developers] announcing eeshow (schematics renderer and viewer)

Eldar Khayrullin wrote: > Now projects are opening from another places Great ! > (maybe I was confused with > message like this one "../kicad-gost-library/linear-gost.lib: not found") Yes, there can be quite a lot of complaints like this, and they can be confusing at times. I still need to tame

Re: [Kicad-developers] [PATCH] Add KICAD_INSTALL_DEMOS CMake option

@Nick, good catch! @Jose: please update the Documentation/development/compiling.md document with your proposed option and resubmit your patch. On 9/8/2016 1:28 PM, Nick Østergaard wrote: > The proposed patch does not document the option in the devdocs. > > 2016-09-08 19:15 GMT+02:00 Wayne

Re: [Kicad-developers] [PATCH] Add KICAD_INSTALL_DEMOS CMake option

As this doesn't affect the program at all, and on some platforms it will be installed seperately anyway i don't think there is any point not having this option On Fri, Sep 9, 2016 at 5:15 AM, Wayne Stambaugh wrote: > Anyone object to this? I don't really have an opinion

Re: [Kicad-developers] [PATCH] Add KICAD_INSTALL_DEMOS CMake option

The proposed patch does not document the option in the devdocs. 2016-09-08 19:15 GMT+02:00 Wayne Stambaugh : > Anyone object to this? I don't really have an opinion one way or the > other since it defaults to the current behavior. I guess there is a > reason not to install

Re: [Kicad-developers] [PATCH] Add KICAD_INSTALL_DEMOS CMake option

Anyone object to this? I don't really have an opinion one way or the other since it defaults to the current behavior. I guess there is a reason not to install the demos. What's one more option at this point. ;) On 9/8/2016 3:04 AM, José Ignacio Romero wrote: > > It is ON by default,

Re: [Kicad-developers] [RFC] [PATCH] simple C++ tests

On 9/7/2016 5:39 PM, Tomasz Wlostowski wrote: > On 07.09.2016 21:24, Wayne Stambaugh wrote: >> Tom, >> >> I also forgot to mention there were tabs in the CMakeLists.txt file. >> > Hi Wayne, > > Here's a (hopefully) fixed version. > > Cheers, > Tom Hey Tom, Here is the patch that fixes the

[Kicad-developers] [PATCH] Print layer names in pcbnew

This patch allows for printing layer names in pcbnew using a %L formater. This is helpful when printing 1 layer per page. Ian Print-layer-name-in-pcbnew.patch Description: Binary data ___ Mailing list: https://launchpad.net/~kicad-developers Post to

Re: [Kicad-developers] [RFC] Nix sheet pin disambiguation menu

I pushed this patch. Thanks. I noticed it only effects the move operation so I don't know if many users will notice the change. I'm wondering if it wouldn't have been better to disambiguate all operations when selecting a sheet pin. That's a discussion for another day. On 9/6/2016 1:03 AM,

Re: [Kicad-developers] [PATCH] Add KICAD_INSTALL_DEMOS CMake option

What is the reasoning for doing this? 2016-09-08 9:04 GMT+02:00 José Ignacio Romero : > > It is ON by default, determines wether to install the bundled demos > and examples. > --- > CMakeLists.txt | 6 ++ > 1 file changed, 6 insertions(+) > > >

[Kicad-developers] [PATCH] Add KICAD_INSTALL_DEMOS CMake option

It is ON by default, determines wether to install the bundled demos and examples. --- CMakeLists.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index bfeaac5..9fba017 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -49,6 +49,10 @@ option(

Re: [Kicad-developers] announcing eeshow (schematics renderer and viewer)

Eldar Khayrullin wrote: > Now eeshow search relative path relative current directory ($PWD) but should > to search relative project file path. Errors if $PWD not equal to project > file path. Hmm, that seems to work here. For example: ~/t$ grep Lib test.pro LibDir=y LibName1=test ~/t$ ls