[Kicad-developers] Jenkins build is back to normal : linux-kicad-full-gcc-head #3586

[Miguel Angel Ajo]

See 



___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Slash character in fp-lib-table nick names?

[Kaspar Emanuel]

Thanks Wayne, this will save me (and anyone else using
monostable/kicad_footprints
) quite a bit of
time!
​

On 19 June 2018 at 19:13, Wayne Stambaugh  wrote:

> I took a second look at this and you are correct.  The library table
> nickname character filter was changed to include the library item
> (symbol or footprint) name characters which is incorrect.  The valid
> library nickname characters are different from the valid library item
> name characters.  I will fix this as soon as I get a chance.
>
> On 6/13/2018 4:59 PM, Kaspar Emanuel wrote:
> > Those are good reasons for not allowing slashes in the footprint names
> > but I don’t see any reason for not allowing them in /library/ nick
> > names. As far as I can tell any character except |:| could be allowed
> > before the |:|. It’s a pretty long standing “bug” so we could view it as
> > standard. It will break "compatibility" with fp-lib-tables that use the
> > slash character and users were never warned about using it.
> >
> > If it /will/ be allowed in v6 why make people change it when going from
> > v4 to v5?
> >
> > ​
> >
> > On 13 June 2018 at 18:35, Wayne Stambaugh  > > wrote:
> >
> > AFAIK you cannot use slashes ('/') or colons (':') in either a
> library
> > (footprint or symbol) table nickname or a footprint or symbol name.
> If
> > you could use a slash in a footprint library nickname in the past,
> this
> > was a bug and the fact that it worked was a fluke.  The reason is
> that
> > the library ID format is NICKNAME:FP_OR_SYM_NAME/REV.  The other
> issue
> > is that footprint names are actually the filename sans extension.
> Using
> > a slash in a footprint name would render it unusable.  I am going to
> fix
> > this as part of the new schematic and symbol library file format v6
> > work.  The reason this was not done for v5 the fix will require
> > schematic, board, and footprint file format changes which I didn't
> not
> > want to do for v5 as we were already late into the development cycle.
> >
> > On 6/13/2018 2:19 PM, Kaspar Emanuel wrote:
> > > Sorry to bring this up again but it just strikes me as a bit odd.
> Can we
> > > not allow slash characters in the fp-lib-table as before and not
> break
> > > backwards compatibility? It seems to read fp-lib-tables with
> slashes
> > > fine but current KiCad nightly won't let me edit it. I am up for
> making
> > > a patch if there's a chance it could make it into v5.
> > >
> > >
> > > On 10 May 2018 at 12:07, Wayne Stambaugh  
> > > >>
> wrote:
> > >
> > > On 5/8/2018 6:27 PM, Kaspar Emanuel wrote:
> > > > I see, thanks for the info Wayne. So enforcing this for
> names in
> > > > _footprint_ lib-tables is simply done for code sharing?
> > > >
> > > > If I understand you correctly short-lived means for the
> lifetime of v5?
> > >
> > > This is correct.  The plan is to fix this after the new
> schematic file
> > > formats are implemented so it should happen some time during v6
> > > development.
> > >
> > > >
> > > > On 8 May 2018 at 22:10, Wayne Stambaugh <
> stambau...@gmail.com 
> > >
> > > > 
> >  > > >
> > > > This was done because the schematic file format parser
> > would break
> > > > with the forward slash character.  I hope to fix this
> > early in the
> > > > v6 development but it's a pain we are going to have to
> > live with
> > > > until the new schematic file format is complete.  I wish
> > I had the
> > > > time to do it all at once but it's just wasn't in the
> > cards.
> > > I have
> > > > to implement this one piece at a time.  There was an
> > > announcement on
> > > > this mailing list about it.  I apologize for the
> > inconvenience.
> > > > Hopefully it will be short lived.
> > > >
> > > > Cheers,
> > > >
> > > > Wayne
> > > >
> > > > On 05/08/2018 04:40 PM, Kaspar Emanuel wrote:
> > > >
> > > > Hi,
> > > >
> > > > looks like a forward slash character in nick names
> > in the
> > > > fp-lib-table is not supported any more (it can be
> > read but it
> > > > cannot be saved).
> > > >
> > > > This breaks compatibility with older fp-lib-tables
> > somewhat. I
> > > > have been 

Re: [Kicad-developers] Slash character in fp-lib-table nick names?

[Wayne Stambaugh]

I took a second look at this and you are correct.  The library table
nickname character filter was changed to include the library item
(symbol or footprint) name characters which is incorrect.  The valid
library nickname characters are different from the valid library item
name characters.  I will fix this as soon as I get a chance.

On 6/13/2018 4:59 PM, Kaspar Emanuel wrote:
> Those are good reasons for not allowing slashes in the footprint names
> but I don’t see any reason for not allowing them in /library/ nick
> names. As far as I can tell any character except |:| could be allowed
> before the |:|. It’s a pretty long standing “bug” so we could view it as
> standard. It will break "compatibility" with fp-lib-tables that use the
> slash character and users were never warned about using it.
> 
> If it /will/ be allowed in v6 why make people change it when going from
> v4 to v5?
> 
> ​
> 
> On 13 June 2018 at 18:35, Wayne Stambaugh  > wrote:
> 
> AFAIK you cannot use slashes ('/') or colons (':') in either a library
> (footprint or symbol) table nickname or a footprint or symbol name.  If
> you could use a slash in a footprint library nickname in the past, this
> was a bug and the fact that it worked was a fluke.  The reason is that
> the library ID format is NICKNAME:FP_OR_SYM_NAME/REV.  The other issue
> is that footprint names are actually the filename sans extension.  Using
> a slash in a footprint name would render it unusable.  I am going to fix
> this as part of the new schematic and symbol library file format v6
> work.  The reason this was not done for v5 the fix will require
> schematic, board, and footprint file format changes which I didn't not
> want to do for v5 as we were already late into the development cycle.
> 
> On 6/13/2018 2:19 PM, Kaspar Emanuel wrote:
> > Sorry to bring this up again but it just strikes me as a bit odd. Can we
> > not allow slash characters in the fp-lib-table as before and not break
> > backwards compatibility? It seems to read fp-lib-tables with slashes
> > fine but current KiCad nightly won't let me edit it. I am up for making
> > a patch if there's a chance it could make it into v5.
> > 
> > 
> > On 10 May 2018 at 12:07, Wayne Stambaugh  
> > >> wrote:
> > 
> >     On 5/8/2018 6:27 PM, Kaspar Emanuel wrote:
> >     > I see, thanks for the info Wayne. So enforcing this for names in
> >     > _footprint_ lib-tables is simply done for code sharing?
> >     > 
> >     > If I understand you correctly short-lived means for the lifetime 
> of v5?
> > 
> >     This is correct.  The plan is to fix this after the new schematic 
> file
> >     formats are implemented so it should happen some time during v6
> >     development.
> > 
> >     > 
> >     > On 8 May 2018 at 22:10, Wayne Stambaugh  
> >
> >     > 
>  >     >
> >     >     This was done because the schematic file format parser
> would break
> >     >     with the forward slash character.  I hope to fix this
> early in the
> >     >     v6 development but it's a pain we are going to have to
> live with
> >     >     until the new schematic file format is complete.  I wish
> I had the
> >     >     time to do it all at once but it's just wasn't in the
> cards. 
> >     I have
> >     >     to implement this one piece at a time.  There was an
> >     announcement on
> >     >     this mailing list about it.  I apologize for the
> inconvenience. 
> >     >     Hopefully it will be short lived.
> >     >
> >     >     Cheers,
> >     >
> >     >     Wayne
> >     >
> >     >     On 05/08/2018 04:40 PM, Kaspar Emanuel wrote:
> >     >
> >     >         Hi,
> >     >
> >     >         looks like a forward slash character in nick names
> in the
> >     >         fp-lib-table is not supported any more (it can be
> read but it
> >     >         cannot be saved).
> >     >
> >     >         This breaks compatibility with older fp-lib-tables
> somewhat. I
> >     >         have been using slashes in names to namespace
> fp-lib-tables
> >     >         created for my footprint collection
> >     >          
> >      >
> >     >          

Re: [Kicad-developers] Worksheet templates for KiCad

[Wayne Stambaugh]

Hi Erasmo,

I see you have submitted your worksheets to the KiCad template repo.
The worksheets look good.  I'm sure users who require ISO standard
worksheet templates will appreciate your efforts.  Thank you for your
contribution to KiCad.

Cheers,

Wayne

On 6/17/2018 4:35 PM, Erasmo Alonso Iglesias wrote:
> Hello,
> 
> I am Erasmo, I am working as a telecommunication engineer from the city
> of Vigo, in Spain. I have been using KiCad for long time and I am proud
> to participate in this mailing list. 
> 
> I have recently published in GitHub a set of worksheet templates
> according to standards ISO 5457 and ISO 7200, which may be interesting
> for other users. I would like to offer my contribution, you can get it
> in  the following link:
> 
> https://github.com/erasmo1982/kicad-templates/tree/erasmo1982-patch-1/ISO5457
> 
> Best regards,
> Erasmo
> 
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Add logo to documentation

[Wayne Stambaugh]

I concur.  The small KiCad logo would look better.

https://github.com/KiCad/kicad-source-mirror/blob/master/bitmaps_png/sources/kicad_logo_small.svg

On 6/18/2018 6:06 AM, Nick Østergaard wrote:
> Mmm, I think I would prefer the Ki logo
> 
> man. 18. jun. 2018 10.11 skrev John Beard  >:
> 
> In that case, here is the patch with the 48px app logo in the top
> left. Doxygen recommends 55px max height, so 48px seems a handy size.
> 
> Screenshot for reference.
> 
> Cheers,
> 
> John
> 
> On Sun, Jun 17, 2018 at 5:58 PM, Wayne Stambaugh
> mailto:stambau...@gmail.com>> wrote:
> 
> I'm OK with the short logo image.  This would probably look
> better than
> the redundant KiCad.
> 
> On 06/17/2018 08:53 AM, John Beard wrote:
> > Sadly I don't think there is a way to set the logo alt text in 
> doxygen
> > (so it would still read "KiCad" when the image is not displayed, for
> > screen readers, when copy-pasted and it when search engines index 
> it).
> > 
> > Alternatively, use the square icon rather than the text logo and 
> keep
> > the title as it is?
> > 
> > Cheers,
> > 
> > John
> > 
> > On Wed, Jun 13, 2018 at 11:18 PM, Wayne Stambaugh 
> mailto:stambau...@gmail.com>
> > >> wrote:
> > 
> >     I agree.  The double KiCad does look a bit odd but I do like the
> >     KiCad logo embedded in the docs.
> > 
> >     On 06/13/2018 06:00 PM, Nick Østergaard wrote:
> > 
> >         Maybe we need to remove the word KiCad from the title, as  
> it
> >         essentially reads  "[KiCad] KiCad Pcbnew Python Scripting"
> > 
> > 
> >         2018-06-13 21:12 GMT+02:00 John Beard 
> mailto:john.j.be...@gmail.com>
> >          >  
> >           > 
> >             Sorry, I had a line commented in a local commit to 
> avoid a
> >         costly
> >             re-build of the docstrings when I didn't need them to be
> >         (the doc
> >             dependencies aren't managed by CMake, it just always 
> runs the
> >             targets, which is fine for CI).
> > 
> >             The attached should be better (difference is a lack of 
> a "#
> >         " before
> >             DEPENDS xml-to-docstrings)
> > 
> >             Cheers,
> > 
> >             John
> > 
> >             On Wed, Jun 13, 2018 at 8:04 PM, Wayne Stambaugh
> >             mailto:stambau...@gmail.com>
> >
> >             >
> >                 John,
> >
> >                 I am getting the following error when I try to
> apply
> >         your patch:
> >
> >                 $ git am --ignore-whitespace <
> >                
> >       
>  
> /c/Users/wstambaugh/Documents/Archive/temp/kicad/patches/0001-Documentation-add-logo-to-Doxygen-pages.patch
> >                 Applying: Documentation: add logo to Doxygen pages
> >                 error: patch failed: pcbnew/CMakeLists.txt:533
> >                 error: pcbnew/CMakeLists.txt: patch does not apply
> >                 Patch failed at 0001 Documentation: add logo
> to Doxygen
> >         pages
> >                 Use 'git am --show-current-patch' to see the
> failed patch
> >                 When you have resolved this problem, run "git am
> >         --continue".
> >                 If you prefer to skip this patch, run "git am
> --skip"
> >         instead.
> >                 To restore the original branch and stop
> patching, run
> >         "git am
> >                 --abort".
> >
> >                 It appears to be choking on the
> pcbnew/CMakeFile.txt.  Is it
> >                 possible
> >                 that you have other changes to this file that
> are not in the
> >                 master branch?
> >
> >                 Cheers,
> >
> >                 Wayne
> >
> >                 On 6/13/2018 1:50 PM, John Beard wrote:
> >