Re: [Kicad-developers] [PATCH] Replace remaining Boost Mutexes with std::mutex

[Seth Hillbrand]

Am 2019-05-05 18:18, schrieb Wayne Stambaugh:

Seth,

On 5/3/19 8:20 PM, Seth Hillbrand wrote:

This looks good Ian.  I had been meaning to get around to this but you
beat me to it!  Nice work.  Thank you for your contribution!

I don't think we need to push this to 5.1 but it's nice to have in 
master.


-Seth


We might want to consider cherry-picking this into 5.1 just to keep the
code bases as close as possible.  This may help prevent some conflicts
down the road.


Fair point.  I'll give this a couple weeks to surface any issues and 
then push it down.


-Seth

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] Replace remaining Boost Mutexes with std::mutex

[Wayne Stambaugh]

Seth,

On 5/3/19 8:20 PM, Seth Hillbrand wrote:
> Am 2019-05-03 14:04, schrieb Ian McInerney:
>> This patch series removes the last uses of MUTEX and MUTLOCK from the
>> code base, so now everything is using std::mutex and std::lock_guard
>> instead of the Boost provided classes. I have also removed the
>> ki_mutex.h header file since this is no longer needed (and found an
>> extraneous inclusion in the process).
>>
>> This was made against the master branch. It appears the kicad_curl.cpp
>> file has diverged due to openssl changes between 5.1 and master, which
>> makes this not apply cleanly to 5.1.
> 
> 
> This looks good Ian.  I had been meaning to get around to this but you
> beat me to it!  Nice work.  Thank you for your contribution!
> 
> I don't think we need to push this to 5.1 but it's nice to have in master.
> 
> -Seth

We might want to consider cherry-picking this into 5.1 just to keep the
code bases as close as possible.  This may help prevent some conflicts
down the road.

Wayne

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] eemodern branch

[Michael Kavanagh]

Sounds good.

Another minor heads up, the leave hierarchical sheet menu/toolbar icon
seems to not be hooked up.

Cheers,
Michael

On Sun, 5 May 2019 at 21:22, Jeff Young  wrote:

> Yeah, I had to move around a couple of the hotkeys for consistency with
> PCBNew.  Note that these debug warnings are just so we don’t ship a default
> set that already has collisions; we gracefully handle them if users create
> them.
>
> Cheers,
> Jeff.
>
> On 5 May 2019, at 20:59, Michael Kavanagh 
> wrote:
>
> Ah, they're duplicated, both Cmd+D (I should have read the message, duh!).
> A "Set to Defaults" fixed it.
>
> Cheers,
> Michael
>
> On Sun, 5 May 2019 at 20:50, Jeff Young  wrote:
>
>> HI Michael,
>>
>> Can you go into List Hotkeys and tell me what your assignments are for
>> those two commands?
>>
>> Thanks,
>> Jeff.
>>
>>
>> On 5 May 2019, at 20:44, Michael Kavanagh 
>> wrote:
>>
>> Great work Jeff!
>>
>> Minor issue, I'm getting an assert when trying to open an example
>> project. See attached screenshot. If I "Cancel to suppress further
>> warnings" everything seems to work fine in my limited testing.
>>
>> Cheers,
>> Michael
>>
>> On Sun, 5 May 2019 at 19:57, Jeff Young  wrote:
>>
>>> Branch is in.  Please let me know if you see anything funny….
>>>
>>> Cheers,
>>> Jeff.
>>>
>>> PS: most of the ordering in the tool context menus is just a first
>>> guess.  If you see something that should move, holler.
>>>
>>>
>>> On 5 May 2019, at 18:46, Tomasz Wlostowski 
>>> wrote:
>>>
>>> ++
>>>
>>> 05.05.2019 11:40 Seth Hillbrand  napisał(a):
>>> +1
>>>
>>> Am 2019-05-05 13:33, schrieb Jon Evans:
>>> > +1
>>> > Merge it and get more testing.  It's already worlds better than the
>>> > status quo.
>>> >
>>> > On Sun, May 5, 2019 at 12:12 PM Jeff Young  wrote:
>>> >
>>> >> I think this is ready to merge.  Any objections?
>>> >>
>>> >> ___
>>> >> Mailing list: https://launchpad.net/~kicad-developers
>>> >> Post to : kicad-developers@lists.launchpad.net
>>> >> Unsubscribe : https://launchpad.net/~kicad-developers
>>> >> More help   : https://help.launchpad.net/ListHelp
>>> > ___
>>> > Mailing list: https://launchpad.net/~kicad-developers
>>> > Post to : kicad-developers@lists.launchpad.net
>>> > Unsubscribe : https://launchpad.net/~kicad-developers
>>> > More help   : https://help.launchpad.net/ListHelp
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>> 
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] eemodern branch

[Jeff Young]

Yeah, I had to move around a couple of the hotkeys for consistency with PCBNew. 
 Note that these debug warnings are just so we don’t ship a default set that 
already has collisions; we gracefully handle them if users create them.

Cheers,
Jeff.

> On 5 May 2019, at 20:59, Michael Kavanagh  wrote:
> 
> Ah, they're duplicated, both Cmd+D (I should have read the message, duh!). A 
> "Set to Defaults" fixed it.
> 
> Cheers,
> Michael
> 
> On Sun, 5 May 2019 at 20:50, Jeff Young  > wrote:
> HI Michael,
> 
> Can you go into List Hotkeys and tell me what your assignments are for those 
> two commands?
> 
> Thanks,
> Jeff.
> 
> 
>> On 5 May 2019, at 20:44, Michael Kavanagh > > wrote:
>> 
>> Great work Jeff!
>> 
>> Minor issue, I'm getting an assert when trying to open an example project. 
>> See attached screenshot. If I "Cancel to suppress further warnings" 
>> everything seems to work fine in my limited testing.
>> 
>> Cheers,
>> Michael
>> 
>> On Sun, 5 May 2019 at 19:57, Jeff Young > > wrote:
>> Branch is in.  Please let me know if you see anything funny….
>> 
>> Cheers,
>> Jeff.
>> 
>> PS: most of the ordering in the tool context menus is just a first guess.  
>> If you see something that should move, holler.
>> 
>> 
>>> On 5 May 2019, at 18:46, Tomasz Wlostowski >> > wrote:
>>> 
>>> ++
>>> 
>>> 05.05.2019 11:40 Seth Hillbrand >> > napisał(a):
>>> +1
>>> 
>>> Am 2019-05-05 13:33, schrieb Jon Evans:
>>> > +1
>>> > Merge it and get more testing.  It's already worlds better than the
>>> > status quo.
>>> > 
>>> > On Sun, May 5, 2019 at 12:12 PM Jeff Young >> > > wrote:
>>> > 
>>> >> I think this is ready to merge.  Any objections?
>>> >> 
>>> >> ___
>>> >> Mailing list: https://launchpad.net/~kicad-developers 
>>> >> 
>>> >> Post to : kicad-developers@lists.launchpad.net 
>>> >> 
>>> >> Unsubscribe : https://launchpad.net/~kicad-developers 
>>> >> 
>>> >> More help   : https://help.launchpad.net/ListHelp 
>>> >> 
>>> > ___
>>> > Mailing list: https://launchpad.net/~kicad-developers 
>>> > 
>>> > Post to : kicad-developers@lists.launchpad.net 
>>> > 
>>> > Unsubscribe : https://launchpad.net/~kicad-developers 
>>> > 
>>> > More help   : https://help.launchpad.net/ListHelp 
>>> > 
>>> 
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers 
>>> 
>>> Post to : kicad-developers@lists.launchpad.net 
>>> 
>>> Unsubscribe : https://launchpad.net/~kicad-developers 
>>> 
>>> More help   : https://help.launchpad.net/ListHelp 
>>> 
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers 
>>> 
>>> Post to : kicad-developers@lists.launchpad.net 
>>> 
>>> Unsubscribe : https://launchpad.net/~kicad-developers 
>>> 
>>> More help   : https://help.launchpad.net/ListHelp 
>>> 
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers 
>> 
>> Post to : kicad-developers@lists.launchpad.net 
>> 
>> Unsubscribe : https://launchpad.net/~kicad-developers 
>> 
>> More help   : https://help.launchpad.net/ListHelp 
>> 
>> > 20.40.08.png>___
>> Mailing list: https://launchpad.net/~kicad-developers 
>> 
>> Post to : kicad-developers@lists.launchpad.net 
>> 
>> Unsubscribe : https://launchpad.net/~kicad-developers 
>> 
>> More help   : https://help.launchpad.net/ListHelp 
>> 
> 

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Unfolding a bus....

[Jon Evans]

Looks good on my end!

-Jon

On Sun, May 5, 2019 at 2:55 PM Jeff Young  wrote:

> Hi Jon,
>
> Doing a bus unfold leaves you *completely* in the wire tool state.  I’ve
> fixed that.
>
> The halfway state is produced when you cancel a bus unfold by clicking
> outside the popup menu to dismiss it.  I’ve fixed that too.
>
> Cheers,
> Jeff.
>
>
> On 5 May 2019, at 17:16, Jon Evans  wrote:
>
> Thanks a lot, Jeff!
> I gave a try and it seems very good. I found one remaining issue:
>
> When I unfold a bus (using hotkey or context menu) and complete the wire
> by double-clicking, I am left in a weird state.
> I can press ESC or use context menu to exit the wire tool, but the cursor
> remains a crosshair, and I can no longer select or right-click anything (so
> it seems like I am still "halfway" in the wire tool)
> The only way to get out of this state is to enter a tool again (using
> context menu or hotkey, any tool works) and then exit again.
>
> Thanks,
> Jon
>
>
> On Sun, May 5, 2019 at 12:01 PM Jeff Young  wrote:
>
>> I’ve pushed fixes for these.
>>
>> Cheers,
>> Jeff.
>>
>> On 5 May 2019, at 00:37, Jeff Young  wrote:
>>
>> Hi Jon,
>>
>> I must have overlooked this in my email.  I’ll get these patched up
>> tomorrow.
>>
>> Cheers,
>> Jeff.
>>
>>
>> On 3 May 2019, at 01:31, Jon Evans  wrote:
>>
>> Hi Jeff,
>> Thanks for cranking through all these features!  It's quite impressive
>> seeing the progress :-)
>>
>> I gave bus unfolding a try and noticed a few issues:
>>
>> 1) It looks like in your branch, bus unfolding is only possible while
>> already in the "draw bus" tool.  It was originally intended to be something
>> that you could trigger from a selected bus, just like the other immediate
>> commands (move/rotate/etc)
>>
>> 2) When I start unfolding a bus, I get the following assertion when I
>> place the bus label:
>> eeschema/tools/sch_line_drawing_tool.cpp(561): assert "aType ==
>> LAYER_WIRE" failed in doDrawSegments().
>> I think this is because the doDrawSegments() of the "draw bus" tool is
>> still called even after the unfold starts (and another doDrawSegments is
>> running to place the unfolded wires)
>>
>> 3) The keyboard shortcut doesn't seem to do anything anymore, I can only
>> unfold from the context menu.  Does it work for you?
>>
>> Unfortunately I don't have time tonight to look more closely at any of
>> these issues, but I can look at them tomorrow if you don't find them first.
>>
>> I like your implementation of BUS_UNFOLD_MENU to handle the dynamic
>> checks -- this pattern will probably be useful for other things in the
>> future!
>>
>> Best,
>> Jon
>>
>> On Thu, May 2, 2019 at 4:05 PM Jeff Young  wrote:
>>
>>> Bits pushed.
>>>
>>> Main parts are now in sch_line_drawing_tool.cpp.  BUS_UNFOLD_MENU starts
>>> on line 96, it’s added to the context menu at line 222, and the commands
>>> are dispatched starting at line 674.
>>>
>>> BTW: there are some synthetic KICAD_T types that can be used for fishing
>>> out sub-types of KICAD_T.  Of interest will be SCH_LINE_LOCATE_BUS_T and
>>> SCH_LINE_LOCATE_WIRE_T.  (There have been similar ones for reference,
>>> value, footprint and datasheet SCH_FIELD_Ts for some time.)
>>>
>>> Cheers,
>>> Jeff.
>>>
>>> On 2 May 2019, at 20:41, Jeff Young  wrote:
>>>
>>> (I also got my simple test working by renaming my bus label from
>>> "D0..31" to "D[0..31]”.)
>>>
>>> On 2 May 2019, at 20:39, Jeff Young  wrote:
>>>
>>> Ha!  Works right out of the box.
>>>
>>> I’ll push it to origin/eemodern shortly so you can have a look.
>>>
>>> Cheers,
>>> Jeff.
>>>
>>>
>>> On 2 May 2019, at 20:07, Jon Evans  wrote:
>>>
>>> Hi Jeff,
>>> You can test unfolding using one of the demo projects that uses buses
>>> (for example: video)
>>>
>>> -Jon
>>>
>>> On Thu, May 2, 2019 at 2:57 PM Jeff Young  wrote:
>>>
 Hi Jon,

 I’ve moved the bus unfolding menu to the modern toolkit and I’m trying
 to test it.  How do I give a bus connections?  I tried a wire2bus entry
 with a label on the wire, and connecting the wire to an annotated
 component, and giving the bus a label of “D0..D31”, but none of those
 worked.  (Or one of them did but I’ve got a bug somewhere.)

 Thanks,
 Jeff.
 ___
 Mailing list: https://launchpad.net/~kicad-developers
 Post to : kicad-developers@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~kicad-developers
 More help   : https://help.launchpad.net/ListHelp

>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : 

Re: [Kicad-developers] eemodern branch

[Michael Kavanagh]

Ah, they're duplicated, both Cmd+D (I should have read the message, duh!).
A "Set to Defaults" fixed it.

Cheers,
Michael

On Sun, 5 May 2019 at 20:50, Jeff Young  wrote:

> HI Michael,
>
> Can you go into List Hotkeys and tell me what your assignments are for
> those two commands?
>
> Thanks,
> Jeff.
>
>
> On 5 May 2019, at 20:44, Michael Kavanagh 
> wrote:
>
> Great work Jeff!
>
> Minor issue, I'm getting an assert when trying to open an example project.
> See attached screenshot. If I "Cancel to suppress further warnings"
> everything seems to work fine in my limited testing.
>
> Cheers,
> Michael
>
> On Sun, 5 May 2019 at 19:57, Jeff Young  wrote:
>
>> Branch is in.  Please let me know if you see anything funny….
>>
>> Cheers,
>> Jeff.
>>
>> PS: most of the ordering in the tool context menus is just a first
>> guess.  If you see something that should move, holler.
>>
>>
>> On 5 May 2019, at 18:46, Tomasz Wlostowski 
>> wrote:
>>
>> ++
>>
>> 05.05.2019 11:40 Seth Hillbrand  napisał(a):
>> +1
>>
>> Am 2019-05-05 13:33, schrieb Jon Evans:
>> > +1
>> > Merge it and get more testing.  It's already worlds better than the
>> > status quo.
>> >
>> > On Sun, May 5, 2019 at 12:12 PM Jeff Young  wrote:
>> >
>> >> I think this is ready to merge.  Any objections?
>> >>
>> >> ___
>> >> Mailing list: https://launchpad.net/~kicad-developers
>> >> Post to : kicad-developers@lists.launchpad.net
>> >> Unsubscribe : https://launchpad.net/~kicad-developers
>> >> More help   : https://help.launchpad.net/ListHelp
>> > ___
>> > Mailing list: https://launchpad.net/~kicad-developers
>> > Post to : kicad-developers@lists.launchpad.net
>> > Unsubscribe : https://launchpad.net/~kicad-developers
>> > More help   : https://help.launchpad.net/ListHelp
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] eemodern branch

[Reece R. Pollack]

I got a bunch of those last night on a build based on the then-current eemodern 
branch, all or most related to duplicate hotkey definitions. I've pasted the 
console log from that below. Note that I opened both a schematic AND a board 
developed using v5, and obviously some of this spew is from pcbnew rather than 
eechema.

This reminds me of the v4->v5 transition, where I had a similar experience. 
Having continued through all of the asserts I no longer get these when restarting 
the v6 apps.


20:22:12: Debug: Adding duplicate image handler for 'PNG file'
20:22:12: Debug: Adding duplicate image handler for 'JPEG file'
20:22:12: Debug: Adding duplicate image handler for 'TIFF file'
20:22:12: Debug: Adding duplicate image handler for 'GIF file'
20:22:12: Debug: Adding duplicate image handler for 'PNM file'
20:22:12: Debug: Adding duplicate image handler for 'PCX file'
20:22:12: Debug: Adding duplicate image handler for 'IFF file'
20:22:12: Debug: Adding duplicate image handler for 'Windows icon file'
20:22:12: Debug: Adding duplicate image handler for 'Windows cursor file'
20:22:12: Debug: Adding duplicate image handler for 'Windows animated cursor 
file'
20:22:12: Debug: Adding duplicate image handler for 'TGA file'
20:22:12: Debug: Adding duplicate image handler for 'XPM file'
20:22:12: Debug: Unrecognized accel key '', accel string ignored.
/home/reece/MyProjects/KiCad/kicad-v6/common/tool/action_manager.cpp(214): assert 
"Assert failure" failed in UpdateHotKeys(): Duplicate hotkey definitions for 
Back: pcbnew.InteractiveEdit.remove and pcbnew.InteractiveDrawing.deleteLastPoint
/home/reece/MyProjects/KiCad/kicad-v6/common/tool/action_manager.cpp(214): assert 
"Assert failure" failed in UpdateHotKeys(): Duplicate hotkey definitions for X: 
pcbnew.InteractiveRouter.SingleTrack and pcbnew.InteractiveRouter.NewTrack
/home/reece/MyProjects/KiCad/kicad-v6/common/tool/action_manager.cpp(214): assert 
"Assert failure" failed in UpdateHotKeys(): Duplicate hotkey definitions for 
Back: pcbnew.InteractiveEdit.remove and pcbnew.InteractiveDrawing.deleteLastPoint
/home/reece/MyProjects/KiCad/kicad-v6/common/tool/action_manager.cpp(214): assert 
"Assert failure" failed in UpdateHotKeys(): Duplicate hotkey definitions for X: 
pcbnew.InteractiveRouter.SingleTrack and pcbnew.InteractiveRouter.NewTrack
/home/reece/MyProjects/KiCad/kicad-v6/common/tool/action_manager.cpp(214): assert 
"Assert failure" failed in UpdateHotKeys(): Duplicate hotkey definitions for 
Back: pcbnew.InteractiveEdit.remove and pcbnew.InteractiveDrawing.deleteLastPoint
/home/reece/MyProjects/KiCad/kicad-v6/common/tool/action_manager.cpp(214): assert 
"Assert failure" failed in UpdateHotKeys(): Duplicate hotkey definitions for X: 
pcbnew.InteractiveRouter.SingleTrack and pcbnew.InteractiveRouter.NewTrack
20:22:20: Debug: Unrecognized accel key '', accel string ignored.
20:22:20: Debug: Unrecognized accel key '', accel string ignored.
/home/reece/MyProjects/KiCad/kicad-v6/common/tool/action_manager.cpp(214): assert 
"Assert failure" failed in UpdateHotKeys(): Duplicate hotkey definitions for 
Back: pcbnew.InteractiveEdit.remove and pcbnew.InteractiveDrawing.deleteLastPoint
/home/reece/MyProjects/KiCad/kicad-v6/common/tool/action_manager.cpp(214): assert 
"Assert failure" failed in UpdateHotKeys(): Duplicate hotkey definitions for X: 
pcbnew.InteractiveRouter.SingleTrack and pcbnew.InteractiveRouter.NewTrack
20:22:22: Debug: Loading project 
'/home/reece/MyProjects/MCS-4/Recreation/P170-DH/pcb/P170-DH 
Replacement/P170-DH Replacement.pro' settings.
/home/reece/MyProjects/KiCad/kicad-v6/common/tool/action_manager.cpp(214): assert 
"Assert failure" failed in UpdateHotKeys(): Duplicate hotkey definitions for 
Back: pcbnew.InteractiveEdit.remove and pcbnew.InteractiveDrawing.deleteLastPoint
/home/reece/MyProjects/KiCad/kicad-v6/common/tool/action_manager.cpp(214): assert 
"Assert failure" failed in UpdateHotKeys(): Duplicate hotkey definitions for X: 
pcbnew.InteractiveRouter.SingleTrack and pcbnew.InteractiveRouter.NewTrack
OpenGL WARNING: Buffer performance warning: Buffer object 2 (bound to 
GL_ARRAY_BUFFER_ARB, usage hint is GL_DYNAMIC_DRAW) is being copied/moved from 
VIDEO memory to DMA CACHED memory.

** (kicad:16791): WARNING **: Invalid borders specified for theme pixmap:
    /usr/share/themes/Breeze/gtk-2.0/../assets/line-h.png,
borders don't fit within the image

(kicad:16791): Gtk-CRITICAL **: IA__gtk_widget_set_size_request: assertion 'width 
>= -1' failed

(kicad:16791): Gtk-CRITICAL **: IA__gtk_widget_set_size_request: assertion 'width 
>= -1' failed

(kicad:16791): Gtk-WARNING **: gtk_widget_size_allocate(): attempt to allocate 
widget with width -5 and height 19

(kicad:16791): Gtk-WARNING **: gtk_widget_size_allocate(): attempt to allocate 
widget with width -5 and height 19

(kicad:16791): Gtk-WARNING **: gtk_widget_size_allocate(): attempt to allocate 
widget with width -5 and height 19

Re: [Kicad-developers] eemodern branch

[Jeff Young]

HI Michael,

Can you go into List Hotkeys and tell me what your assignments are for those 
two commands?

Thanks,
Jeff.


> On 5 May 2019, at 20:44, Michael Kavanagh  wrote:
> 
> Great work Jeff!
> 
> Minor issue, I'm getting an assert when trying to open an example project. 
> See attached screenshot. If I "Cancel to suppress further warnings" 
> everything seems to work fine in my limited testing.
> 
> Cheers,
> Michael
> 
> On Sun, 5 May 2019 at 19:57, Jeff Young  > wrote:
> Branch is in.  Please let me know if you see anything funny….
> 
> Cheers,
> Jeff.
> 
> PS: most of the ordering in the tool context menus is just a first guess.  If 
> you see something that should move, holler.
> 
> 
>> On 5 May 2019, at 18:46, Tomasz Wlostowski > > wrote:
>> 
>> ++
>> 
>> 05.05.2019 11:40 Seth Hillbrand > > napisał(a):
>> +1
>> 
>> Am 2019-05-05 13:33, schrieb Jon Evans:
>> > +1
>> > Merge it and get more testing.  It's already worlds better than the
>> > status quo.
>> > 
>> > On Sun, May 5, 2019 at 12:12 PM Jeff Young > > > wrote:
>> > 
>> >> I think this is ready to merge.  Any objections?
>> >> 
>> >> ___
>> >> Mailing list: https://launchpad.net/~kicad-developers 
>> >> 
>> >> Post to : kicad-developers@lists.launchpad.net 
>> >> 
>> >> Unsubscribe : https://launchpad.net/~kicad-developers 
>> >> 
>> >> More help   : https://help.launchpad.net/ListHelp 
>> >> 
>> > ___
>> > Mailing list: https://launchpad.net/~kicad-developers 
>> > 
>> > Post to : kicad-developers@lists.launchpad.net 
>> > 
>> > Unsubscribe : https://launchpad.net/~kicad-developers 
>> > 
>> > More help   : https://help.launchpad.net/ListHelp 
>> > 
>> 
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers 
>> 
>> Post to : kicad-developers@lists.launchpad.net 
>> 
>> Unsubscribe : https://launchpad.net/~kicad-developers 
>> 
>> More help   : https://help.launchpad.net/ListHelp 
>> 
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers 
>> 
>> Post to : kicad-developers@lists.launchpad.net 
>> 
>> Unsubscribe : https://launchpad.net/~kicad-developers 
>> 
>> More help   : https://help.launchpad.net/ListHelp 
>> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers 
> 
> Post to : kicad-developers@lists.launchpad.net 
> 
> Unsubscribe : https://launchpad.net/~kicad-developers 
> 
> More help   : https://help.launchpad.net/ListHelp 
> 
>  20.40.08.png>___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] eemodern branch

[Jeff Young]

Branch is in.  Please let me know if you see anything funny….

Cheers,
Jeff.

PS: most of the ordering in the tool context menus is just a first guess.  If 
you see something that should move, holler.


> On 5 May 2019, at 18:46, Tomasz Wlostowski  wrote:
> 
> ++
> 
> 05.05.2019 11:40 Seth Hillbrand  > napisał(a):
> +1
> 
> Am 2019-05-05 13:33, schrieb Jon Evans:
> > +1
> > Merge it and get more testing.  It's already worlds better than the
> > status quo.
> > 
> > On Sun, May 5, 2019 at 12:12 PM Jeff Young  wrote:
> > 
> >> I think this is ready to merge.  Any objections?
> >> 
> >> ___
> >> Mailing list: https://launchpad.net/~kicad-developers 
> >> 
> >> Post to : kicad-developers@lists.launchpad.net
> >> Unsubscribe : https://launchpad.net/~kicad-developers 
> >> 
> >> More help   : https://help.launchpad.net/ListHelp 
> >> 
> > ___
> > Mailing list: https://launchpad.net/~kicad-developers 
> > 
> > Post to : kicad-developers@lists.launchpad.net
> > Unsubscribe : https://launchpad.net/~kicad-developers 
> > 
> > More help   : https://help.launchpad.net/ListHelp 
> > 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers 
> 
> Post to : kicad-developers@lists.launchpad.net 
> 
> Unsubscribe : https://launchpad.net/~kicad-developers 
> 
> More help   : https://help.launchpad.net/ListHelp 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers 
> 
> Post to : kicad-developers@lists.launchpad.net 
> 
> Unsubscribe : https://launchpad.net/~kicad-developers 
> 
> More help   : https://help.launchpad.net/ListHelp 
> 
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Unfolding a bus....

[Jeff Young]

Hi Jon,

Doing a bus unfold leaves you completely in the wire tool state.  I’ve fixed 
that.

The halfway state is produced when you cancel a bus unfold by clicking outside 
the popup menu to dismiss it.  I’ve fixed that too.

Cheers,
Jeff.


> On 5 May 2019, at 17:16, Jon Evans  wrote:
> 
> Thanks a lot, Jeff!
> I gave a try and it seems very good. I found one remaining issue:
> 
> When I unfold a bus (using hotkey or context menu) and complete the wire by 
> double-clicking, I am left in a weird state.
> I can press ESC or use context menu to exit the wire tool, but the cursor 
> remains a crosshair, and I can no longer select or right-click anything (so 
> it seems like I am still "halfway" in the wire tool)
> The only way to get out of this state is to enter a tool again (using context 
> menu or hotkey, any tool works) and then exit again.
> 
> Thanks,
> Jon
> 
> 
> On Sun, May 5, 2019 at 12:01 PM Jeff Young  > wrote:
> I’ve pushed fixes for these.
> 
> Cheers,
> Jeff.
> 
>> On 5 May 2019, at 00:37, Jeff Young mailto:j...@rokeby.ie>> 
>> wrote:
>> 
>> Hi Jon,
>> 
>> I must have overlooked this in my email.  I’ll get these patched up tomorrow.
>> 
>> Cheers,
>> Jeff.
>> 
>> 
>>> On 3 May 2019, at 01:31, Jon Evans >> > wrote:
>>> 
>>> Hi Jeff,
>>> Thanks for cranking through all these features!  It's quite impressive 
>>> seeing the progress :-)
>>> 
>>> I gave bus unfolding a try and noticed a few issues:
>>> 
>>> 1) It looks like in your branch, bus unfolding is only possible while 
>>> already in the "draw bus" tool.  It was originally intended to be something 
>>> that you could trigger from a selected bus, just like the other immediate 
>>> commands (move/rotate/etc)
>>> 
>>> 2) When I start unfolding a bus, I get the following assertion when I place 
>>> the bus label:
>>> eeschema/tools/sch_line_drawing_tool.cpp(561): assert "aType == LAYER_WIRE" 
>>> failed in doDrawSegments().
>>> I think this is because the doDrawSegments() of the "draw bus" tool is 
>>> still called even after the unfold starts (and another doDrawSegments is 
>>> running to place the unfolded wires)
>>> 
>>> 3) The keyboard shortcut doesn't seem to do anything anymore, I can only 
>>> unfold from the context menu.  Does it work for you?
>>> 
>>> Unfortunately I don't have time tonight to look more closely at any of 
>>> these issues, but I can look at them tomorrow if you don't find them first.
>>> 
>>> I like your implementation of BUS_UNFOLD_MENU to handle the dynamic checks 
>>> -- this pattern will probably be useful for other things in the future!
>>> 
>>> Best,
>>> Jon
>>> 
>>> On Thu, May 2, 2019 at 4:05 PM Jeff Young >> > wrote:
>>> Bits pushed.
>>> 
>>> Main parts are now in sch_line_drawing_tool.cpp.  BUS_UNFOLD_MENU starts on 
>>> line 96, it’s added to the context menu at line 222, and the commands are 
>>> dispatched starting at line 674.
>>> 
>>> BTW: there are some synthetic KICAD_T types that can be used for fishing 
>>> out sub-types of KICAD_T.  Of interest will be SCH_LINE_LOCATE_BUS_T and 
>>> SCH_LINE_LOCATE_WIRE_T.  (There have been similar ones for reference, 
>>> value, footprint and datasheet SCH_FIELD_Ts for some time.)
>>> 
>>> Cheers,
>>> Jeff.
>>> 
 On 2 May 2019, at 20:41, Jeff Young >>> > wrote:
 
 (I also got my simple test working by renaming my bus label from "D0..31" 
 to "D[0..31]”.)
 
> On 2 May 2019, at 20:39, Jeff Young  > wrote:
> 
> Ha!  Works right out of the box.
> 
> I’ll push it to origin/eemodern shortly so you can have a look.
> 
> Cheers,
> Jeff.
> 
> 
>> On 2 May 2019, at 20:07, Jon Evans > > wrote:
>> 
>> Hi Jeff,
>> You can test unfolding using one of the demo projects that uses buses 
>> (for example: video)
>> 
>> -Jon
>> 
>> On Thu, May 2, 2019 at 2:57 PM Jeff Young > > wrote:
>> Hi Jon,
>> 
>> I’ve moved the bus unfolding menu to the modern toolkit and I’m trying 
>> to test it.  How do I give a bus connections?  I tried a wire2bus entry 
>> with a label on the wire, and connecting the wire to an annotated 
>> component, and giving the bus a label of “D0..D31”, but none of those 
>> worked.  (Or one of them did but I’ve got a bug somewhere.)
>> 
>> Thanks,
>> Jeff.
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers 
>> 
>> Post to : kicad-developers@lists.launchpad.net 
>> 
>> Unsubscribe : https://launchpad.net/~kicad-developers 
>> 
>> More help   : https://help.launchpad.net/ListHelp 
>> 
> 
> 

Re: [Kicad-developers] eemodern branch

[Tomasz Wlostowski]

++

05.05.2019 11:40 Seth Hillbrand  napisał(a):
+1

Am 2019-05-05 13:33, schrieb Jon Evans:
> +1
> Merge it and get more testing.  It's already worlds better than the
> status quo.
>
> On Sun, May 5, 2019 at 12:12 PM Jeff Young  wrote:
>
>> I think this is ready to merge.  Any objections?
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] eemodern branch

[Seth Hillbrand]

+1

Am 2019-05-05 13:33, schrieb Jon Evans:

+1
Merge it and get more testing.  It's already worlds better than the
status quo.

On Sun, May 5, 2019 at 12:12 PM Jeff Young  wrote:


I think this is ready to merge.  Any objections?

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] eemodern branch

[Jon Evans]

+1
Merge it and get more testing.  It's already worlds better than the status
quo.

On Sun, May 5, 2019 at 12:12 PM Jeff Young  wrote:

> I think this is ready to merge.  Any objections?
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Unfolding a bus....

[Jon Evans]

Thanks a lot, Jeff!
I gave a try and it seems very good. I found one remaining issue:

When I unfold a bus (using hotkey or context menu) and complete the wire by
double-clicking, I am left in a weird state.
I can press ESC or use context menu to exit the wire tool, but the cursor
remains a crosshair, and I can no longer select or right-click anything (so
it seems like I am still "halfway" in the wire tool)
The only way to get out of this state is to enter a tool again (using
context menu or hotkey, any tool works) and then exit again.

Thanks,
Jon


On Sun, May 5, 2019 at 12:01 PM Jeff Young  wrote:

> I’ve pushed fixes for these.
>
> Cheers,
> Jeff.
>
> On 5 May 2019, at 00:37, Jeff Young  wrote:
>
> Hi Jon,
>
> I must have overlooked this in my email.  I’ll get these patched up
> tomorrow.
>
> Cheers,
> Jeff.
>
>
> On 3 May 2019, at 01:31, Jon Evans  wrote:
>
> Hi Jeff,
> Thanks for cranking through all these features!  It's quite impressive
> seeing the progress :-)
>
> I gave bus unfolding a try and noticed a few issues:
>
> 1) It looks like in your branch, bus unfolding is only possible while
> already in the "draw bus" tool.  It was originally intended to be something
> that you could trigger from a selected bus, just like the other immediate
> commands (move/rotate/etc)
>
> 2) When I start unfolding a bus, I get the following assertion when I
> place the bus label:
> eeschema/tools/sch_line_drawing_tool.cpp(561): assert "aType ==
> LAYER_WIRE" failed in doDrawSegments().
> I think this is because the doDrawSegments() of the "draw bus" tool is
> still called even after the unfold starts (and another doDrawSegments is
> running to place the unfolded wires)
>
> 3) The keyboard shortcut doesn't seem to do anything anymore, I can only
> unfold from the context menu.  Does it work for you?
>
> Unfortunately I don't have time tonight to look more closely at any of
> these issues, but I can look at them tomorrow if you don't find them first.
>
> I like your implementation of BUS_UNFOLD_MENU to handle the dynamic checks
> -- this pattern will probably be useful for other things in the future!
>
> Best,
> Jon
>
> On Thu, May 2, 2019 at 4:05 PM Jeff Young  wrote:
>
>> Bits pushed.
>>
>> Main parts are now in sch_line_drawing_tool.cpp.  BUS_UNFOLD_MENU starts
>> on line 96, it’s added to the context menu at line 222, and the commands
>> are dispatched starting at line 674.
>>
>> BTW: there are some synthetic KICAD_T types that can be used for fishing
>> out sub-types of KICAD_T.  Of interest will be SCH_LINE_LOCATE_BUS_T and
>> SCH_LINE_LOCATE_WIRE_T.  (There have been similar ones for reference,
>> value, footprint and datasheet SCH_FIELD_Ts for some time.)
>>
>> Cheers,
>> Jeff.
>>
>> On 2 May 2019, at 20:41, Jeff Young  wrote:
>>
>> (I also got my simple test working by renaming my bus label from "D0..31"
>> to "D[0..31]”.)
>>
>> On 2 May 2019, at 20:39, Jeff Young  wrote:
>>
>> Ha!  Works right out of the box.
>>
>> I’ll push it to origin/eemodern shortly so you can have a look.
>>
>> Cheers,
>> Jeff.
>>
>>
>> On 2 May 2019, at 20:07, Jon Evans  wrote:
>>
>> Hi Jeff,
>> You can test unfolding using one of the demo projects that uses buses
>> (for example: video)
>>
>> -Jon
>>
>> On Thu, May 2, 2019 at 2:57 PM Jeff Young  wrote:
>>
>>> Hi Jon,
>>>
>>> I’ve moved the bus unfolding menu to the modern toolkit and I’m trying
>>> to test it.  How do I give a bus connections?  I tried a wire2bus entry
>>> with a label on the wire, and connecting the wire to an annotated
>>> component, and giving the bus a label of “D0..D31”, but none of those
>>> worked.  (Or one of them did but I’ve got a bug somewhere.)
>>>
>>> Thanks,
>>> Jeff.
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : 

Re: [Kicad-developers] eemodern branch

[Jeff Young]

I think this is ready to merge.  Any objections?

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] eemodern merge request

[Jeff Young]

Hi Nick,

Could these be out-of-memory errors or something?  I ran two of them:

FAILURE  * 2d722bebb  Remove extra Show Datasheet menu item.  
and

FAILURE  * 642d08798  Add modern toolset notification to eeschema undo/redo.  

and they built fine. 

(Those two are also simple enough that I don’t think it’s a compiler issue, 
although I’ve been wrong about that before.)

Cheers,
Jeff.


> On 4 May 2019, at 22:44, Nick Østergaard  wrote:
> 
> Hello Jeff,
> 
> I ran my "evaluate" script on your branch and there are a couple of
> commits that are not buildable, see
> https://jenkins.simonrichter.eu/job/windows-kicad-msys2-evaluate/107/artifact/build-report.txt
> 
> As usual the builds logs are available on the jenkins job if you need
> them. (You may want to "save as" the plain text build log if you wan
> it)
> 
> Nick
> 
> On Sat, 4 May 2019 at 18:18, Jeff Young  wrote:
>> 
>> OK, my re-factor is in.
>> 
>>> On 4 May 2019, at 16:03, Jeff Young  wrote:
>>> 
>>> Give me a bit to merge first, though.  I’ve re-arranged a bunch of code in 
>>> preparation for sharing some of it with libedit.
>>> 
>>> 
>>> 
 On 4 May 2019, at 16:01, Jeff Young  wrote:
 
 Hi Tom,
 
 I didn’t even notice it was missing.  If you want to have a crack at it, 
 that would be great.
 
 Cheers,
 Jeff.
 
 
> On 4 May 2019, at 15:56, Tomasz Wlostowski  
> wrote:
> 
> On 02/05/2019 15:51, Jeff Young wrote:
>> The eeschema modern toolset is “finished”.
>> 
>> It can be found at origin/eemodern.  A bit of testing before merging 
>> might be in order….
> 
> Hi Jeff,
> 
> I noticed eemodern it's missing mouse drag action (i.e. dragging a
> selected wire/component/etc. just starts drawing another selection
> rectangle). Are you planning to add it (I can also contribute this
> feature - long flight tomorrow should be enough to code it ;-)
> 
> Cheers,
> Tom
 
 
 ___
 Mailing list: https://launchpad.net/~kicad-developers
 Post to : kicad-developers@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~kicad-developers
 More help   : https://help.launchpad.net/ListHelp
>>> 
>>> 
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@lists.launchpad.net
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>> 
>> 
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Unfolding a bus....

[Jeff Young]

I’ve pushed fixes for these.

Cheers,
Jeff.

> On 5 May 2019, at 00:37, Jeff Young  wrote:
> 
> Hi Jon,
> 
> I must have overlooked this in my email.  I’ll get these patched up tomorrow.
> 
> Cheers,
> Jeff.
> 
> 
>> On 3 May 2019, at 01:31, Jon Evans > > wrote:
>> 
>> Hi Jeff,
>> Thanks for cranking through all these features!  It's quite impressive 
>> seeing the progress :-)
>> 
>> I gave bus unfolding a try and noticed a few issues:
>> 
>> 1) It looks like in your branch, bus unfolding is only possible while 
>> already in the "draw bus" tool.  It was originally intended to be something 
>> that you could trigger from a selected bus, just like the other immediate 
>> commands (move/rotate/etc)
>> 
>> 2) When I start unfolding a bus, I get the following assertion when I place 
>> the bus label:
>> eeschema/tools/sch_line_drawing_tool.cpp(561): assert "aType == LAYER_WIRE" 
>> failed in doDrawSegments().
>> I think this is because the doDrawSegments() of the "draw bus" tool is still 
>> called even after the unfold starts (and another doDrawSegments is running 
>> to place the unfolded wires)
>> 
>> 3) The keyboard shortcut doesn't seem to do anything anymore, I can only 
>> unfold from the context menu.  Does it work for you?
>> 
>> Unfortunately I don't have time tonight to look more closely at any of these 
>> issues, but I can look at them tomorrow if you don't find them first.
>> 
>> I like your implementation of BUS_UNFOLD_MENU to handle the dynamic checks 
>> -- this pattern will probably be useful for other things in the future!
>> 
>> Best,
>> Jon
>> 
>> On Thu, May 2, 2019 at 4:05 PM Jeff Young > > wrote:
>> Bits pushed.
>> 
>> Main parts are now in sch_line_drawing_tool.cpp.  BUS_UNFOLD_MENU starts on 
>> line 96, it’s added to the context menu at line 222, and the commands are 
>> dispatched starting at line 674.
>> 
>> BTW: there are some synthetic KICAD_T types that can be used for fishing out 
>> sub-types of KICAD_T.  Of interest will be SCH_LINE_LOCATE_BUS_T and 
>> SCH_LINE_LOCATE_WIRE_T.  (There have been similar ones for reference, value, 
>> footprint and datasheet SCH_FIELD_Ts for some time.)
>> 
>> Cheers,
>> Jeff.
>> 
>>> On 2 May 2019, at 20:41, Jeff Young >> > wrote:
>>> 
>>> (I also got my simple test working by renaming my bus label from "D0..31" 
>>> to "D[0..31]”.)
>>> 
 On 2 May 2019, at 20:39, Jeff Young >>> > wrote:
 
 Ha!  Works right out of the box.
 
 I’ll push it to origin/eemodern shortly so you can have a look.
 
 Cheers,
 Jeff.
 
 
> On 2 May 2019, at 20:07, Jon Evans  > wrote:
> 
> Hi Jeff,
> You can test unfolding using one of the demo projects that uses buses 
> (for example: video)
> 
> -Jon
> 
> On Thu, May 2, 2019 at 2:57 PM Jeff Young  > wrote:
> Hi Jon,
> 
> I’ve moved the bus unfolding menu to the modern toolkit and I’m trying to 
> test it.  How do I give a bus connections?  I tried a wire2bus entry with 
> a label on the wire, and connecting the wire to an annotated component, 
> and giving the bus a label of “D0..D31”, but none of those worked.  (Or 
> one of them did but I’ve got a bug somewhere.)
> 
> Thanks,
> Jeff.
> ___
> Mailing list: https://launchpad.net/~kicad-developers 
> 
> Post to : kicad-developers@lists.launchpad.net 
> 
> Unsubscribe : https://launchpad.net/~kicad-developers 
> 
> More help   : https://help.launchpad.net/ListHelp 
> 
 
 ___
 Mailing list: https://launchpad.net/~kicad-developers 
 
 Post to : kicad-developers@lists.launchpad.net 
 
 Unsubscribe : https://launchpad.net/~kicad-developers 
 
 More help   : https://help.launchpad.net/ListHelp 
 
>>> 
>>> ___
>>> Mailing list: https://launchpad.net/~kicad-developers 
>>> 
>>> Post to : kicad-developers@lists.launchpad.net 
>>> 
>>> Unsubscribe : https://launchpad.net/~kicad-developers 
>>> 
>>> More help   : https://help.launchpad.net/ListHelp 
>>> 
>> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net

Re: [Kicad-developers] [PATCH] Replace remaining Boost Mutexes with std::mutex

[Ian McInerney]

Seth,

Thanks for pushing it. I saw that on the todo list along with the auto_ptr
replacement and decided to take a stab at it. I didn't end up doing the
auto_ptr replacement part since when I looked through the code it seems
they are only used in the sch_lib_table files, which I believe would be
part of the overhaul for v6 with the new file formats. Whoever ends up
working with those parts can do the replacements then and that will take
care of all the parts in the C++11 technical todo list.

-Ian

On Sat, May 4, 2019 at 1:20 AM Seth Hillbrand  wrote:

> Am 2019-05-03 14:04, schrieb Ian McInerney:
> > This patch series removes the last uses of MUTEX and MUTLOCK from the
> > code base, so now everything is using std::mutex and std::lock_guard
> > instead of the Boost provided classes. I have also removed the
> > ki_mutex.h header file since this is no longer needed (and found an
> > extraneous inclusion in the process).
> >
> > This was made against the master branch. It appears the kicad_curl.cpp
> > file has diverged due to openssl changes between 5.1 and master, which
> > makes this not apply cleanly to 5.1.
>
>
> This looks good Ian.  I had been meaning to get around to this but you
> beat me to it!  Nice work.  Thank you for your contribution!
>
> I don't think we need to push this to 5.1 but it's nice to have in
> master.
>
> -Seth
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] kicad_pcb, kicad_mod format change for daily build?

[Rene Pöschl]

Even if the current kicad versions can read it it still makes problems 
with version control.


For that reason i would request a file format verion update on any 
change to the file generation at least for library assets as it has 
direct impact on the library maintainance!
It makes it near to impossible to easily identify changes made by the 
contributor compared to changes made by the new file format algorithm.


The reason for my report is: 
https://github.com/KiCad/kicad-footprints/pull/815/commits/624037c1ca388506fca4d1d5b6b42e9f68157470 
Now tell me which changes where made by the user on purpose and which 
where introduced by the algorithm change.


I would simply suggest the following rule to be added to the release 
policy: Have a set of reference files. Save them without doing actual 
changes. If git detects a change in the resulting files than a file 
format change did happen and needs to be clearly indicated.


On 21/04/19 18:46, Jeff Young wrote:

Hi Kevin,

KiCad will read them in either way (quoted or un-quoted).

KiCad has always written them out with quotes if they had spaces in them (so 
other tools have always needed to handle quotes).

We’re just being more consistent now as there’s no justification for “saving a 
few characters” in this day and age (and going forward it will make things 
easier).

Cheers,
Jeff.



On 21 Apr 2019, at 17:25, Kevin Cozens  wrote:


On 15 Apr 2019, at 13:56, easyw  wrote:
recently I have noticed that both kicad_pcb and kicad_mod seems to have changed 
their format.
It have been introduced double quotes for layers pads etc.

[snip]

(layers
(0 F.Cu signal)
(31 B.Cu signal)

(layers
(0 "F.Cu" signal)
(31 "B.Cu" signal)

When I was asking about an updated file format document I was told "There have been 
virtually no changes to the file format other than how symbol library links are defined 
for a very long time."

I consider it a file format change if quotes weren't needed before but they are 
now. It is the type of information I need to be sure I'm generating files in 
the proper format to avoid possibly having to go through the migration process.

There may be other change(s) I may need to know about because the version 
number in the files has been bumped since the current file format doc was 
written. The files I'm generating are a version behind and have to go through a 
migration process when I try and open them. I don't fully trust the migration 
process.

I hope someone can update the docs after KiCon, or perhaps someone can point me 
to which file(s) generate the schematic files used by eeschema.

--
Cheers!

Kevin.

http://www.ve3syb.ca/   | "Nerds make the shiny things that
https://www.patreon.com/KevinCozens | distract the mouth-breathers, and
| that's why we're powerful"
Owner of Elecraft K2 #2172  |
#include  | --Chris Hardwick

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp




___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp