Patch pushed to master. Thank you for your contribution to KiCad.
Cheers,
Wayne
On 9/8/2016 2:56 PM, Werner Almesberger wrote:
> The default and logo page layout templates are missing some opening
> parentheses. Eeschema's parser accepts them anyway, but it tripped
> my s-expr parser.
>
> The
On 9/9/2016 4:49 PM, Mark Roszko wrote:
>> I'm not opposed to quoting all strings. However the parser still needs
> to differentiate a string versus a keyword such as bold or italic used
> in the font definition. Those should not be quoted. I'm guessing
> you've covered that.
>
>
> Yep, it
>I'm not opposed to quoting all strings. However the parser still needs
to differentiate a string versus a keyword such as bold or italic used
in the font definition. Those should not be quoted. I'm guessing
you've covered that.
Yep, it still has a concept of "keywords" (symbols in sexpr).
On 9/9/2016 3:24 PM, Mark Roszko wrote:
>> I'm assuming this doesn't change the fp-lib-table file formatting.
>
> ~Mostly~ doesn't.
>
> One major difference is I absolutely quote all strings. Right now
> kicad's output formatter does not quote string types if there is only
> a single word. This
>I'm assuming this doesn't change the fp-lib-table file formatting.
~Mostly~ doesn't.
One major difference is I absolutely quote all strings. Right now
kicad's output formatter does not quote string types if there is only
a single word. This violated the sanctity of what was a Symbol vs
String
the existing parser is "by the seat of our pants" style parsing
where there is no centralized parsing logic and instead
manual definition of expected tokens for every single parsable atom
and well, this has led to places where expectRightParenthesis() isn't
called and the like. But that won't
Hmm. I took another look at this patch and I'm concerned as to why the
page layout template parser did not choke on this. That should be fixed
as well.
On 9/8/2016 2:56 PM, Werner Almesberger wrote:
> The default and logo page layout templates are missing some opening
> parentheses. Eeschema's
On 2016-09-08 20:56, Werner Almesberger wrote:
> The default and logo page layout templates are missing some opening
> parentheses. Eeschema's parser accepts them anyway, but it tripped
> my s-expr parser.
Is accepting a wrong syntax without a warning not a bug worth fixing?
Regards,
Clemens
8 matches
Mail list logo
