Re: [Kicad-developers] [PATCH] hierarchy navigator icon moved where it belongs

[Marcos Chaparro]

Yeah, please remove it, I never used it despite I know its there. It will
make more space for other more useful icons that are not displayed on a 720
display.

Regards


On Jun 17, 2017 13:08, "jp charras"  wrote:

> Le 17/06/2017 à 17:43, Simon Richter a écrit :
> > Hi,
> >
> > On 17.06.2017 14:41, Wayne Stambaugh wrote:
> >
> >> I wonder if the navigation tool is really necessary.  Does any one use
> >> it?
> >
> > There is a hierarchy navigation tool?
> >
> >Simon
> >
>
> The actual hierarchy navigation tool is located on the main horizontal
> toolbar.
>
> the "hierarchy navigation tool" we are talking here and located on the
> right vertical toolbar is
> just a tool to enter and leave a sheet with only one mouse click.
>
> I don't think this tool is very useful, and I do not really use it.
>
>
> --
> Jean-Pierre CHARRAS
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] hierarchy navigator icon moved where it belongs

[jp charras]

Le 17/06/2017 à 17:43, Simon Richter a écrit :
> Hi,
> 
> On 17.06.2017 14:41, Wayne Stambaugh wrote:
> 
>> I wonder if the navigation tool is really necessary.  Does any one use
>> it?
> 
> There is a hierarchy navigation tool?
> 
>Simon
> 

The actual hierarchy navigation tool is located on the main horizontal toolbar.

the "hierarchy navigation tool" we are talking here and located on the right 
vertical toolbar is
just a tool to enter and leave a sheet with only one mouse click.

I don't think this tool is very useful, and I do not really use it.


-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] hierarchy navigator icon moved where it belongs

[Simon Richter]

Hi,

On 17.06.2017 14:41, Wayne Stambaugh wrote:

> I wonder if the navigation tool is really necessary.  Does any one use
> it?

There is a hierarchy navigation tool?

   Simon



signature.asc
Description: OpenPGP digital signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] hierarchy navigator icon moved where it belongs

[Fabrizio Tappero]

Hi guys,
no worries. To my eyes this change was similar to move the zoom icon. I
learn only now that right hand side icons change the status of the mouse
and horizontal icons cannot have this functionality. My knowledge of KiCad
is definitely limited.


+1 for removing it. I find its use already fulfilled by the hierarchical
nav dialog.

cheers
Fabrizio



On Sat, Jun 17, 2017 at 2:41 PM, Wayne Stambaugh 
wrote:

> On 6/17/2017 8:11 AM, jp charras wrote:
> > Le 17/06/2017 à 13:38, Fabrizio Tappero a écrit :
> >> Hi guys,
> >> I'd like to reminder that this patch is still pending. I would love it
> to be applied.
> >>
> >> cheers
> >> Fabrizio
> >
> > Hi Fabrizio,
> >
> > Sorry to say that, but you cannot move this icon without changing the
> associated code.
> > Unlike icons in vertical toolbar, this icon, like all icons of the
> vertical right toolbar, is a
> > wxITEM_CHECK tool (and unlike tools of the main upper toolbar).
> >
> > To tell the truth, I am not especially thrilled by your proposal,
> because this icon does not act as
> > the hierarchy navigator icon in main toolbar, but like any other tool
> icon of the vertical right
> > toolbar (It changes the properties of the left click mouse button and
> the shape of the mouse cursor).
> >
> > For instance, after moving the Zoom on selection tool from vertical
> toolbar to main toolbar, I spent
> > 2 days to fix UI issues created by this change.
> > Just because the associated code was designed to manage tools of the
> vertical toolbar, not for any
> > tool in any toolbar, both in legacy canvas and gal canvas, and was not
> fixed by the initial patch.
> >
>
> I'm going to side with JP on this.  While I applaud all efforts to
> improve our UI consistency, breaking things is not the way to go about it.
>
> I wonder if the navigation tool is really necessary.  Does any one use
> it?  I can't recall ever using it.  We already have the hierarchy
> navigator dialog, leave sheet command, double click to enter a sheet,
> and alt-bkspc to leave sheet.  Interestingly, the hierarchy navigation
> tool always enabled even on schematics with no sheets.  Perhaps this is
> a tool that we can remove in the name of simplification.
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] hierarchy navigator icon moved where it belongs

[Wayne Stambaugh]

On 6/17/2017 8:11 AM, jp charras wrote:
> Le 17/06/2017 à 13:38, Fabrizio Tappero a écrit :
>> Hi guys,
>> I'd like to reminder that this patch is still pending. I would love it to be 
>> applied.
>>
>> cheers
>> Fabrizio
> 
> Hi Fabrizio,
> 
> Sorry to say that, but you cannot move this icon without changing the 
> associated code.
> Unlike icons in vertical toolbar, this icon, like all icons of the vertical 
> right toolbar, is a
> wxITEM_CHECK tool (and unlike tools of the main upper toolbar).
> 
> To tell the truth, I am not especially thrilled by your proposal, because 
> this icon does not act as
> the hierarchy navigator icon in main toolbar, but like any other tool icon of 
> the vertical right
> toolbar (It changes the properties of the left click mouse button and the 
> shape of the mouse cursor).
> 
> For instance, after moving the Zoom on selection tool from vertical toolbar 
> to main toolbar, I spent
> 2 days to fix UI issues created by this change.
> Just because the associated code was designed to manage tools of the vertical 
> toolbar, not for any
> tool in any toolbar, both in legacy canvas and gal canvas, and was not fixed 
> by the initial patch.
> 

I'm going to side with JP on this.  While I applaud all efforts to
improve our UI consistency, breaking things is not the way to go about it.

I wonder if the navigation tool is really necessary.  Does any one use
it?  I can't recall ever using it.  We already have the hierarchy
navigator dialog, leave sheet command, double click to enter a sheet,
and alt-bkspc to leave sheet.  Interestingly, the hierarchy navigation
tool always enabled even on schematics with no sheets.  Perhaps this is
a tool that we can remove in the name of simplification.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] hierarchy navigator icon moved where it belongs

[jp charras]

Le 17/06/2017 à 13:38, Fabrizio Tappero a écrit :
> Hi guys,
> I'd like to reminder that this patch is still pending. I would love it to be 
> applied.
> 
> cheers
> Fabrizio

Hi Fabrizio,

Sorry to say that, but you cannot move this icon without changing the 
associated code.
Unlike icons in vertical toolbar, this icon, like all icons of the vertical 
right toolbar, is a
wxITEM_CHECK tool (and unlike tools of the main upper toolbar).

To tell the truth, I am not especially thrilled by your proposal, because this 
icon does not act as
the hierarchy navigator icon in main toolbar, but like any other tool icon of 
the vertical right
toolbar (It changes the properties of the left click mouse button and the shape 
of the mouse cursor).

For instance, after moving the Zoom on selection tool from vertical toolbar to 
main toolbar, I spent
2 days to fix UI issues created by this change.
Just because the associated code was designed to manage tools of the vertical 
toolbar, not for any
tool in any toolbar, both in legacy canvas and gal canvas, and was not fixed by 
the initial patch.


> 
> 
> 
> On Thu, Jun 8, 2017 at 10:03 AM, Fabrizio Tappero  > wrote:
> 
> Hello,
> I moved the hierarchy navigator icon next to the other two hierarchy 
> icons to make the toolbar
> more coherent. 
> 
> Inline image 1
> 
> I think the hierarchy navigator window, activated by the first hierarchy 
> icon, has a bigger
> margin so that scrollbar is not show (see below) but I could not find a 
> way to do that. Maybe
> some wxwidget person can advise.
> 
> Inline image 2
> 
> cheers
> Fabrizio
> 
> 
> 
> 
> 
> 
> 
> From 6ffa93414e2076dc048769eee48581abcb2f1634 Mon Sep 17 00:00:00 2001
> From: Fabrizio Tappero  >
> Date: Thu, 8 Jun 2017 09:56:25 +0200
> Subject: [PATCH] hierarchy navigator icon moved where it belongs
> 
> ---
>  eeschema/tool_sch.cpp | 11 +--
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/eeschema/tool_sch.cpp b/eeschema/tool_sch.cpp
> index 78e0179..f872592 100644
> --- a/eeschema/tool_sch.cpp
> +++ b/eeschema/tool_sch.cpp
> @@ -130,11 +130,14 @@ void SCH_EDIT_FRAME::ReCreateHToolbar()
>  m_mainToolBar->AddSeparator();
>  
>  m_mainToolBar->AddTool( ID_HIERARCHY, wxEmptyString, KiBitmap( 
> hierarchy
> _nav_xpm ),
> -_( "Navigate schematic hierarchy" ) );
> +_( "Show sheet hierarchy window" ) );
>  
>  
>  m_mainToolBar->AddTool( ID_POPUP_SCH_LEAVE_SHEET, wxEmptyString, 
> KiBitma
> p( leave_sheet_xpm ),
> -_( "Leave sheet" ) );
> +_( "Jump to master sheet" ) );
> +
> +m_mainToolBar->AddTool( ID_HIERARCHY_PUSH_POP_BUTT, wxEmptyString, 
> KiBit
> map( hierarchy_cursor_xpm ),
> +_( "Navigate sheet hierarchy" ), 
> wxITEM_CHECK );
>  
>  m_mainToolBar->AddSeparator();
>  
> @@ -201,10 +204,6 @@ void SCH_EDIT_FRAME::ReCreateVToolbar()
>  m_drawToolBar->AddTool( ID_HIGHLIGHT, wxEmptyString, KiBitmap( 
> net_highl
> ight_schematic_xpm ),
>  _( "Highlight net" ), wxITEM_CHECK );
>  
> -m_drawToolBar->AddTool( ID_HIERARCHY_PUSH_POP_BUTT, wxEmptyString,
> -KiBitmap( hierarchy_cursor_xpm ),
> -_( "Ascend/descend hierarchy" ), 
> wxITEM_CHECK );
> -
>  m_drawToolBar->AddTool( ID_SCH_PLACE_COMPONENT, wxEmptyString, 
> KiBitmap(
>  add_component_xpm ),
>  HELP_PLACE_COMPONENTS, wxITEM_CHECK );
>  
> -- 
> 2.7.4
> 
> 
> 
> 
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


-- 
Jean-Pierre CHARRAS

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] hierarchy navigator icon moved where it belongs

[Fabrizio Tappero]

Hi guys,
I'd like to reminder that this patch is still pending. I would love it to
be applied.

cheers
Fabrizio



On Thu, Jun 8, 2017 at 10:03 AM, Fabrizio Tappero <
fabrizio.tapp...@gmail.com> wrote:

> Hello,
> I moved the hierarchy navigator icon next to the other two hierarchy icons
> to make the toolbar more coherent.
>
> [image: Inline image 1]
>
> I think the hierarchy navigator window, activated by the first hierarchy
> icon, has a bigger margin so that scrollbar is not show (see below) but I
> could not find a way to do that. Maybe some wxwidget person can advise.
>
> [image: Inline image 2]
>
> cheers
> Fabrizio
>
>
>
>
>
>
>
> From 6ffa93414e2076dc048769eee48581abcb2f1634 Mon Sep 17 00:00:00 2001
> From: Fabrizio Tappero 
> Date: Thu, 8 Jun 2017 09:56:25 +0200
> Subject: [PATCH] hierarchy navigator icon moved where it belongs
>
> ---
>  eeschema/tool_sch.cpp | 11 +--
>  1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/eeschema/tool_sch.cpp b/eeschema/tool_sch.cpp
> index 78e0179..f872592 100644
> --- a/eeschema/tool_sch.cpp
> +++ b/eeschema/tool_sch.cpp
> @@ -130,11 +130,14 @@ void SCH_EDIT_FRAME::ReCreateHToolbar()
>  m_mainToolBar->AddSeparator();
>
>  m_mainToolBar->AddTool( ID_HIERARCHY, wxEmptyString, KiBitmap(
> hierarchy
> _nav_xpm ),
> -_( "Navigate schematic hierarchy" ) );
> +_( "Show sheet hierarchy window" ) );
>
>
>  m_mainToolBar->AddTool( ID_POPUP_SCH_LEAVE_SHEET, wxEmptyString,
> KiBitma
> p( leave_sheet_xpm ),
> -_( "Leave sheet" ) );
> +_( "Jump to master sheet" ) );
> +
> +m_mainToolBar->AddTool( ID_HIERARCHY_PUSH_POP_BUTT, wxEmptyString,
> KiBit
> map( hierarchy_cursor_xpm ),
> +_( "Navigate sheet hierarchy" ), wxITEM_CHECK
> );
>
>  m_mainToolBar->AddSeparator();
>
> @@ -201,10 +204,6 @@ void SCH_EDIT_FRAME::ReCreateVToolbar()
>  m_drawToolBar->AddTool( ID_HIGHLIGHT, wxEmptyString, KiBitmap(
> net_highl
> ight_schematic_xpm ),
>  _( "Highlight net" ), wxITEM_CHECK );
>
> -m_drawToolBar->AddTool( ID_HIERARCHY_PUSH_POP_BUTT, wxEmptyString,
> -KiBitmap( hierarchy_cursor_xpm ),
> -_( "Ascend/descend hierarchy" ), wxITEM_CHECK
> );
> -
>  m_drawToolBar->AddTool( ID_SCH_PLACE_COMPONENT, wxEmptyString,
> KiBitmap(
>  add_component_xpm ),
>  HELP_PLACE_COMPONENTS, wxITEM_CHECK );
>
> --
> 2.7.4
>
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH] hierarchy navigator icon moved where it belongs

[Fabrizio Tappero]

Hello,
I moved the hierarchy navigator icon next to the other two hierarchy icons
to make the toolbar more coherent.

[image: Inline image 1]

I think the hierarchy navigator window, activated by the first hierarchy
icon, has a bigger margin so that scrollbar is not show (see below) but I
could not find a way to do that. Maybe some wxwidget person can advise.

[image: Inline image 2]

cheers
Fabrizio







>From 6ffa93414e2076dc048769eee48581abcb2f1634 Mon Sep 17 00:00:00 2001
From: Fabrizio Tappero 
Date: Thu, 8 Jun 2017 09:56:25 +0200
Subject: [PATCH] hierarchy navigator icon moved where it belongs

---
 eeschema/tool_sch.cpp | 11 +--
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/eeschema/tool_sch.cpp b/eeschema/tool_sch.cpp
index 78e0179..f872592 100644
--- a/eeschema/tool_sch.cpp
+++ b/eeschema/tool_sch.cpp
@@ -130,11 +130,14 @@ void SCH_EDIT_FRAME::ReCreateHToolbar()
 m_mainToolBar->AddSeparator();

 m_mainToolBar->AddTool( ID_HIERARCHY, wxEmptyString, KiBitmap(
hierarchy
_nav_xpm ),
-_( "Navigate schematic hierarchy" ) );
+_( "Show sheet hierarchy window" ) );


 m_mainToolBar->AddTool( ID_POPUP_SCH_LEAVE_SHEET, wxEmptyString,
KiBitma
p( leave_sheet_xpm ),
-_( "Leave sheet" ) );
+_( "Jump to master sheet" ) );
+
+m_mainToolBar->AddTool( ID_HIERARCHY_PUSH_POP_BUTT, wxEmptyString,
KiBit
map( hierarchy_cursor_xpm ),
+_( "Navigate sheet hierarchy" ), wxITEM_CHECK
);

 m_mainToolBar->AddSeparator();

@@ -201,10 +204,6 @@ void SCH_EDIT_FRAME::ReCreateVToolbar()
 m_drawToolBar->AddTool( ID_HIGHLIGHT, wxEmptyString, KiBitmap(
net_highl
ight_schematic_xpm ),
 _( "Highlight net" ), wxITEM_CHECK );

-m_drawToolBar->AddTool( ID_HIERARCHY_PUSH_POP_BUTT, wxEmptyString,
-KiBitmap( hierarchy_cursor_xpm ),
-_( "Ascend/descend hierarchy" ), wxITEM_CHECK
);
-
 m_drawToolBar->AddTool( ID_SCH_PLACE_COMPONENT, wxEmptyString,
KiBitmap(
 add_component_xpm ),
 HELP_PLACE_COMPONENTS, wxITEM_CHECK );

-- 
2.7.4
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp