Re: [Kicad-developers] [PATCH 1/2] Update FindGLEW.cmake

2017-07-28 Thread Maciej Sumiński
Hi Simon, Thank you, I have just pushed both patches. Regards, Orson On 07/22/2017 12:43 AM, Simon Richter wrote: > --- > CMakeModules/FindGLEW.cmake | 155 > > 1 file changed, 56 insertions(+), 99 deletions(-) > > > >

Re: [Kicad-developers] [PATCH 1/2] Update FindGLEW.cmake

2017-07-27 Thread Simon Richter
Hi, On 27.07.2017 16:48, Simon Richter wrote: >> Did you just copy this from CMake or did you merge it with our changes >> to the old FindGLEW.cmake? If you copied it, it will most likely break >> msys2 builds on windows. Did you test it on msys2? > IIRC I tested it (it's an old patch). Will

Re: [Kicad-developers] [PATCH 1/2] Update FindGLEW.cmake

2017-07-27 Thread Simon Richter
Hi, On 27.07.2017 16:13, Wayne Stambaugh wrote: > Did you just copy this from CMake or did you merge it with our changes > to the old FindGLEW.cmake? If you copied it, it will most likely break > msys2 builds on windows. Did you test it on msys2? IIRC I tested it (it's an old patch). Will

Re: [Kicad-developers] [PATCH 1/2] Update FindGLEW.cmake

2017-07-27 Thread Wayne Stambaugh
On 7/27/2017 7:29 AM, Simon Richter wrote: > Hi, > > On 27.07.2017 11:38, Maciej Sumiński wrote: > >> Are there any problems with the current FindGLEW script? I rather would >> not modify correct CMake scripts without any particular reason, as it >> may result in new problems. > > Yes, it

Re: [Kicad-developers] [PATCH 1/2] Update FindGLEW.cmake

2017-07-27 Thread Simon Richter
Hi, On 27.07.2017 11:38, Maciej Sumiński wrote: > Are there any problems with the current FindGLEW script? I rather would > not modify correct CMake scripts without any particular reason, as it > may result in new problems. Yes, it doesn't support the mapping of debug and release builds on

Re: [Kicad-developers] [PATCH 1/2] Update FindGLEW.cmake

2017-07-27 Thread Maciej Sumiński
Hi Simon, Are there any problems with the current FindGLEW script? I rather would not modify correct CMake scripts without any particular reason, as it may result in new problems. Cheers, Orson On 07/22/2017 12:43 AM, Simon Richter wrote: > --- > CMakeModules/FindGLEW.cmake | 155 >

[Kicad-developers] [PATCH 1/2] Update FindGLEW.cmake

2017-07-21 Thread Simon Richter
--- CMakeModules/FindGLEW.cmake | 155 1 file changed, 56 insertions(+), 99 deletions(-) diff --git a/CMakeModules/FindGLEW.cmake b/CMakeModules/FindGLEW.cmake index 621fe3b3f..ac2eb9ee8 100644 --- a/CMakeModules/FindGLEW.cmake +++