Re: [Kicad-developers] Odp: broken pipe and a simple commit
On Thu, Oct 22, 2020 at 11:02:16AM +0100, Ian McInerney wrote: > If all you are doing is touching the translations, we will be skipping the > CI checks. Just make the merge request with the update files and it will be > merged. I will look into changing the CI so that it doesn't run if only the > translation files are updated. Thanks, in the meantime I updated the merge request for the patch to the script (I think I finally grasped the workflow ... sorry not really developer skills here...) and rebased. https://gitlab.com/kicad/code/kicad/-/merge_requests/489 TIA -- Saluton, Marco Ciampa ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Odp: broken pipe and a simple commit
No worries. Everyone runs into it. > On 22 Oct 2020, at 12:22, Marco Ciampa wrote: > > On Thu, Oct 22, 2020 at 11:01:48AM +0100, Jeff Young wrote: >> I can’t see the pipeline reports (they’re all 404), >> but did you increase the CI timeout for your repo to 4 hours? > > I am really sorry, I didn't know that I should do it ... let's try again > ... if it do not finish I just can't ask a pull request... > >> (Our CI system is really slow.) > > Yes I saw... > > -- > > Saluton, > Marco Ciampa ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Odp: broken pipe and a simple commit
On Thu, Oct 22, 2020 at 11:01:48AM +0100, Jeff Young wrote: > I can’t see the pipeline reports (they’re all 404), > but did you increase the CI timeout for your repo to 4 hours? I am really sorry, I didn't know that I should do it ... let's try again ... if it do not finish I just can't ask a pull request... > (Our CI system is really slow.) Yes I saw... -- Saluton, Marco Ciampa ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Odp: broken pipe and a simple commit
If all you are doing is touching the translations, we will be skipping the CI checks. Just make the merge request with the update files and it will be merged. I will look into changing the CI so that it doesn't run if only the translation files are updated. On Thu, Oct 22, 2020 at 10:43 AM Marco Ciampa wrote: > On Thu, Oct 22, 2020 at 10:52:08AM +0200, Sylwester Kocjan wrote: > > Hi Marco, Did you try to push your commit directly on master branch? > > No, I did this (as I am used to in github...): > > > General Guidelines: > > > >1)Always create a new branch for merge requests instead of using your > fork's master branch. > > I created a personal fork. First commit (super small change that does not > affect compilation at all) error message: > > Your pipeline has failed. > > Project: kicad ( https://gitlab.com/ciampix/kicad ) > Branch: master ( https://gitlab.com/ciampix/kicad/-/commits/master ) > > Commit: d8da1615 ( > https://gitlab.com/ciampix/kicad/-/commit/d8da161599065e519cc1a33b8bef01d3be3f8204 > ) > Commit Message: Fixed single language translation update that w... > Commit Author: Marco Ciampa ( https://gitlab.com/ciampix ) > > Pipeline #206121055 ( > https://gitlab.com/ciampix/kicad/-/pipelines/206121055 ) triggered by > Marco Ciampa ( https://gitlab.com/ciampix ) > had 3 failed builds. > > Job #805521551 ( https://gitlab.com/ciampix/kicad/-/jobs/805521551/raw ) > > Stage: report > Name: report_build_warn > Job #805521552 ( https://gitlab.com/ciampix/kicad/-/jobs/805521552/raw ) > > Stage: report > Name: report_metrics > Job #805521539 ( https://gitlab.com/ciampix/kicad/-/jobs/805521539/raw ) > > Stage: build > Name: build_linux > > TIA > > -- > > Saluton, > Marco Ciampa > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp > ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Odp: broken pipe and a simple commit
I can’t see the pipeline reports (they’re all 404), but did you increase the CI timeout for your repo to 4 hours? (Our CI system is really slow.) > On 22 Oct 2020, at 10:42, Marco Ciampa wrote: > > On Thu, Oct 22, 2020 at 10:52:08AM +0200, Sylwester Kocjan wrote: >> Hi Marco, Did you try to push your commit directly on master branch? > > No, I did this (as I am used to in github...): > >> General Guidelines: >> >> 1)Always create a new branch for merge requests instead of using your >> fork's master branch. > > I created a personal fork. First commit (super small change that does not > affect compilation at all) error message: > > Your pipeline has failed. > > Project: kicad ( https://gitlab.com/ciampix/kicad ) > Branch: master ( https://gitlab.com/ciampix/kicad/-/commits/master ) > > Commit: d8da1615 ( > https://gitlab.com/ciampix/kicad/-/commit/d8da161599065e519cc1a33b8bef01d3be3f8204 > ) > Commit Message: Fixed single language translation update that w... > Commit Author: Marco Ciampa ( https://gitlab.com/ciampix ) > > Pipeline #206121055 ( https://gitlab.com/ciampix/kicad/-/pipelines/206121055 > ) triggered by Marco Ciampa ( https://gitlab.com/ciampix ) > had 3 failed builds. > > Job #805521551 ( https://gitlab.com/ciampix/kicad/-/jobs/805521551/raw ) > > Stage: report > Name: report_build_warn > Job #805521552 ( https://gitlab.com/ciampix/kicad/-/jobs/805521552/raw ) > > Stage: report > Name: report_metrics > Job #805521539 ( https://gitlab.com/ciampix/kicad/-/jobs/805521539/raw ) > > Stage: build > Name: build_linux > > TIA > > -- > > Saluton, > Marco Ciampa > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
Re: [Kicad-developers] Odp: broken pipe and a simple commit
On Thu, Oct 22, 2020 at 10:52:08AM +0200, Sylwester Kocjan wrote: > Hi Marco, Did you try to push your commit directly on master branch? No, I did this (as I am used to in github...): > General Guidelines: > >1)Always create a new branch for merge requests instead of using your > fork's master branch. I created a personal fork. First commit (super small change that does not affect compilation at all) error message: Your pipeline has failed. Project: kicad ( https://gitlab.com/ciampix/kicad ) Branch: master ( https://gitlab.com/ciampix/kicad/-/commits/master ) Commit: d8da1615 ( https://gitlab.com/ciampix/kicad/-/commit/d8da161599065e519cc1a33b8bef01d3be3f8204 ) Commit Message: Fixed single language translation update that w... Commit Author: Marco Ciampa ( https://gitlab.com/ciampix ) Pipeline #206121055 ( https://gitlab.com/ciampix/kicad/-/pipelines/206121055 ) triggered by Marco Ciampa ( https://gitlab.com/ciampix ) had 3 failed builds. Job #805521551 ( https://gitlab.com/ciampix/kicad/-/jobs/805521551/raw ) Stage: report Name: report_build_warn Job #805521552 ( https://gitlab.com/ciampix/kicad/-/jobs/805521552/raw ) Stage: report Name: report_metrics Job #805521539 ( https://gitlab.com/ciampix/kicad/-/jobs/805521539/raw ) Stage: build Name: build_linux TIA -- Saluton, Marco Ciampa ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
[Kicad-developers] Odp: broken pipe and a simple commit
Hi Marco, Did you try to push your commit directly on master branch? If yes, this is not correct gitlab workflow. For every change you need to create new branch, which will be merged in pull request. Heres a summary: gitlab.com gitlab.com I couldnt see exact error message. Could you please post it if its not the case? BR, SK Dnia 22 października 2020 10:34 Marco Ciampa ciam...@posteo.net napisał(a): Hello devs! I am a translator. Recently translations migrated to the main sources git repo. No problem with that, but one. I forked the master tree on gitlab, committed a simple fix on my repo to upgrade the translation script that was a little broken, and gitlab says that my commit broke the compilation? 1) that thus prevented me to post a pull request 2) this all, after waiting for more than 1 hour (!) 3) my fix is simple simple enough to not broke anything that was not already broken 4) please grant me write commit rights and spare me all this crap TIA PS: this is the commit SHA: d8da161599065e519cc1a33b8bef01 gitlab.com gitlab.com -- Saluton, Marco Ciampa __ Mailing list: launchpad.net launchpad.net Post to : kicad-developers@lists.launchp Unsubscribe : launchpad.net launchpad.net More help : help.launchpad.net help.launchpad.net ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
