Re: [Kicad-developers] Patch: Fixing a compile error on Power PC

2019-08-27 Thread Simon Richter
Hi, On Tue, Aug 27, 2019 at 05:14:47PM +0200, Tomasz Wlostowski wrote: > Does anybody here have a PPC machine to test this? Preferably one with > working OpenGL? I have half of one, missing a case though so it's not set up yet. With luck, I'll get to that next week, then I can also integrate it

Re: [Kicad-developers] Patch: Fixing a compile error on Power PC

2019-08-27 Thread Steven A. Falco
On 8/27/19 11:14 AM, Tomasz Wlostowski wrote: > On 27/08/2019 16:18, Steven A. Falco wrote: >> On 8/26/19 4:16 PM, Seth Hillbrand wrote: >>> On 2019-08-26 16:05, Tomasz Wlostowski wrote: On 26/08/2019 17:24, Seth Hillbrand wrote: > Agreed.  That looks like it may be have been a rebase

Re: [Kicad-developers] Patch: Fixing a compile error on Power PC

2019-08-27 Thread Tomasz Wlostowski
On 27/08/2019 16:18, Steven A. Falco wrote: > On 8/26/19 4:16 PM, Seth Hillbrand wrote: >> On 2019-08-26 16:05, Tomasz Wlostowski wrote: >>> On 26/08/2019 17:24, Seth Hillbrand wrote: Agreed.  That looks like it may be have been a rebase issue as the commit was for MSVC and shouldn't

Re: [Kicad-developers] Patch: Fixing a compile error on Power PC

2019-08-27 Thread Steven A. Falco
On 8/26/19 4:16 PM, Seth Hillbrand wrote: > On 2019-08-26 16:05, Tomasz Wlostowski wrote: >> On 26/08/2019 17:24, Seth Hillbrand wrote: >>> Agreed.  That looks like it may be have been a rebase issue as the >>> commit was for MSVC and shouldn't affect PPC. >>> >>> @Tom, shout if you see an issue

Re: [Kicad-developers] Patch: Fixing a compile error on Power PC

2019-08-26 Thread Seth Hillbrand
On 2019-08-26 16:05, Tomasz Wlostowski wrote: On 26/08/2019 17:24, Seth Hillbrand wrote: Agreed.  That looks like it may be have been a rebase issue as the commit was for MSVC and shouldn't affect PPC. @Tom, shout if you see an issue here.  I've pushed the patch to master in the meantime. I

Re: [Kicad-developers] Patch: Fixing a compile error on Power PC

2019-08-26 Thread Tomasz Wlostowski
On 26/08/2019 17:24, Seth Hillbrand wrote: > Agreed.  That looks like it may be have been a rebase issue as the > commit was for MSVC and shouldn't affect PPC. > > @Tom, shout if you see an issue here.  I've pushed the patch to master > in the meantime. > I don't see a technical issue, but

Re: [Kicad-developers] Patch: Fixing a compile error on Power PC

2019-08-26 Thread Seth Hillbrand
Agreed. That looks like it may be have been a rebase issue as the commit was for MSVC and shouldn't affect PPC. @Tom, shout if you see an issue here. I've pushed the patch to master in the meantime. Best- Seth On 2019-08-24 18:00, Steven A. Falco wrote: I have enabled compilation for

[Kicad-developers] Patch: Fixing a compile error on Power PC

2019-08-24 Thread Steven A. Falco
I have enabled compilation for PPC64LE, because that was requested by a Fedora user. KiCAD builds fine for 5.1, but the PPC64 compilation is broken on master. The attached patch fixes that by reverting a small portion of commit 6cab769f41f. Basically, on a 64-bit PPC machine, gcc defines both