Re: [Kicad-developers] Rev 6350, abs vs std::abs

2015-12-07 Thread Wayne Stambaugh
JP, Please add to math_for_graphic.cpp to see if it resolves the issue? It does look a bit odd using both abs() and std::abs() in the same source file. Thanks, Wayne On 12/7/2015 8:28 AM, Chris Pavlina wrote: > It is indeed difficult to test an issue that doesn't appear on your computer, >

Re: [Kicad-developers] Rev 6350, abs vs std::abs

2015-12-07 Thread jp charras
Le 07/12/2015 14:28, Chris Pavlina a écrit : > It is indeed difficult to test an issue that doesn't appear on your > computer, but from a quick look around, it looks like the correct way > is to leave std::abs, but add #include . Unlike stdlib.h, > cstdlib defines overloads for all the integer

Re: [Kicad-developers] Rev 6350, abs vs std::abs

2015-12-07 Thread Chris Pavlina
It is indeed difficult to test an issue that doesn't appear on your computer, but from a quick look around, it looks like the correct way is to leave std::abs, but add #include . Unlike stdlib.h, cstdlib defines overloads for all the integer widths, reducing the possibility of a bad mistake

[Kicad-developers] Rev 6350, abs vs std::abs

2015-12-07 Thread Chris Pavlina
Mostly directed at JP: Back in June, I went through and changed a few 'weird' things we were doing, including using C abs instead of C++ std::abs: http://bazaar.launchpad.net/~kicad-product-committers/kicad/product/revision/5831 You just changed it back:

Re: [Kicad-developers] Rev 6350, abs vs std::abs

2015-12-07 Thread jp charras
Le 07/12/2015 13:51, Chris Pavlina a écrit : > Mostly directed at JP: > > Back in June, I went through and changed a few 'weird' things we were doing, > including using C abs instead of C++ std::abs: > > http://bazaar.launchpad.net/~kicad-product-committers/kicad/product/revision/5831 > > You