Re: [Kicad-developers] wxStaticBox bug

2017-12-26 Thread Adam Wolf 
Ah, I saw you already updated a bug on the tracker--ignore my last question :)

Adam

On Tue, Dec 26, 2017 at 5:01 PM, Adam Wolf
 wrote:
> I would suggest making a patch for wxwidgets and sending it to the
> list.  There are other macOS specific wxwidgets patches.  I have
> always created the patch manually, and included the upstream bug/patch
> in the email to the list here.
>
> Let me know if you need step by steps, and thanks for tracking this
> down!  Does this fix any particular macOS bugs?
>
> Adam Wolf
>
> On Tue, Dec 26, 2017 at 4:55 PM, Jeff Young  wrote:
>> I got a reply back from Igor Korot that wxWidgets 3.1.0 is scheduled for
>> mid-January.  The fix being tagged 3.1.0, however, is no guarantee that it
>> will make it in.
>>
>> How often do we roll our wxWidgets version?  Should I just go ahead and
>> create another wxWidgets patch for it?  (If so, is there a cheatsheet
>> anywhere on how to do that?)
>>
>> Thanks,
>> Jeff.
>>
>>
>> On 26 Dec 2017, at 21:00, Jeff Young  wrote:
>>
>> I just tracked down a bug in OSX where tabbing doesn’t work within a
>> wxStaticBox.  The bug was in include/wx/osx/statbox.h, which failed to
>> inherit from wxStaticBoxBase.
>>
>> I checked on master, and that bug was fixed by vadz two years ago:
>> https://github.com/wxWidgets/wxWidgets/blame/master/include/wx/osx/statbox.h
>>
>> I’m on 3.0.3, which is far more recent that that.  Fearing I had somehow
>> bungled my git clone, I double-checked the WX_3_0_3_BRANCH only to discover
>> that statbox.h’s commit history there stops at July 26, 2013:
>> https://github.com/wxWidgets/wxWidgets/commits/WX_3_0_3_BRANCH/include/wx/osx/statbox.h
>>
>> Digging deeper, I see that the commit has a 3.1.0 tag, which I assume is the
>> release it is planned for?
>> https://github.com/wxWidgets/wxWidgets/commit/e9b379fe2abb579fc1c334cc3e642e66c0a5d158
>>
>> Why is it not in earlier releases, since it’s a relatively old fix?
>>
>> Thanks,
>> Jeff.
>>
>>
>>
>> ___
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to : kicad-developers@lists.launchpad.net
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] wxStaticBox bug

2017-12-26 Thread Adam Wolf 
I would suggest making a patch for wxwidgets and sending it to the
list.  There are other macOS specific wxwidgets patches.  I have
always created the patch manually, and included the upstream bug/patch
in the email to the list here.

Let me know if you need step by steps, and thanks for tracking this
down!  Does this fix any particular macOS bugs?

Adam Wolf

On Tue, Dec 26, 2017 at 4:55 PM, Jeff Young  wrote:
> I got a reply back from Igor Korot that wxWidgets 3.1.0 is scheduled for
> mid-January.  The fix being tagged 3.1.0, however, is no guarantee that it
> will make it in.
>
> How often do we roll our wxWidgets version?  Should I just go ahead and
> create another wxWidgets patch for it?  (If so, is there a cheatsheet
> anywhere on how to do that?)
>
> Thanks,
> Jeff.
>
>
> On 26 Dec 2017, at 21:00, Jeff Young  wrote:
>
> I just tracked down a bug in OSX where tabbing doesn’t work within a
> wxStaticBox.  The bug was in include/wx/osx/statbox.h, which failed to
> inherit from wxStaticBoxBase.
>
> I checked on master, and that bug was fixed by vadz two years ago:
> https://github.com/wxWidgets/wxWidgets/blame/master/include/wx/osx/statbox.h
>
> I’m on 3.0.3, which is far more recent that that.  Fearing I had somehow
> bungled my git clone, I double-checked the WX_3_0_3_BRANCH only to discover
> that statbox.h’s commit history there stops at July 26, 2013:
> https://github.com/wxWidgets/wxWidgets/commits/WX_3_0_3_BRANCH/include/wx/osx/statbox.h
>
> Digging deeper, I see that the commit has a 3.1.0 tag, which I assume is the
> release it is planned for?
> https://github.com/wxWidgets/wxWidgets/commit/e9b379fe2abb579fc1c334cc3e642e66c0a5d158
>
> Why is it not in earlier releases, since it’s a relatively old fix?
>
> Thanks,
> Jeff.
>
>
>
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] wxStaticBox bug

2017-12-26 Thread Jeff Young 
I got a reply back from Igor Korot that wxWidgets 3.1.0 is scheduled for 
mid-January.  The fix being tagged 3.1.0, however, is no guarantee that it will 
make it in.

How often do we roll our wxWidgets version?  Should I just go ahead and create 
another wxWidgets patch for it?  (If so, is there a cheatsheet anywhere on how 
to do that?)

Thanks,
Jeff.


> On 26 Dec 2017, at 21:00, Jeff Young  wrote:
> 
> I just tracked down a bug in OSX where tabbing doesn’t work within a 
> wxStaticBox.  The bug was in include/wx/osx/statbox.h, which failed to 
> inherit from wxStaticBoxBase.
> 
> I checked on master, and that bug was fixed by vadz two years ago:
> https://github.com/wxWidgets/wxWidgets/blame/master/include/wx/osx/statbox.h 
> 
> 
> I’m on 3.0.3, which is far more recent that that.  Fearing I had somehow 
> bungled my git clone, I double-checked the WX_3_0_3_BRANCH only to discover 
> that statbox.h’s commit history there stops at July 26, 2013:
> https://github.com/wxWidgets/wxWidgets/commits/WX_3_0_3_BRANCH/include/wx/osx/statbox.h
>  
> 
> 
> Digging deeper, I see that the commit has a 3.1.0 tag, which I assume is the 
> release it is planned for?
> https://github.com/wxWidgets/wxWidgets/commit/e9b379fe2abb579fc1c334cc3e642e66c0a5d158
>  
> 
> 
> Why is it not in earlier releases, since it’s a relatively old fix?  
> 
> Thanks,
> Jeff.

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] wxStaticBox bug

2017-12-26 Thread Jeff Young 
I just tracked down a bug in OSX where tabbing doesn’t work within a 
wxStaticBox.  The bug was in include/wx/osx/statbox.h, which failed to inherit 
from wxStaticBoxBase.

I checked on master, and that bug was fixed by vadz two years ago:
https://github.com/wxWidgets/wxWidgets/blame/master/include/wx/osx/statbox.h 


I’m on 3.0.3, which is far more recent that that.  Fearing I had somehow 
bungled my git clone, I double-checked the WX_3_0_3_BRANCH only to discover 
that statbox.h’s commit history there stops at July 26, 2013:
https://github.com/wxWidgets/wxWidgets/commits/WX_3_0_3_BRANCH/include/wx/osx/statbox.h
 


Digging deeper, I see that the commit has a 3.1.0 tag, which I assume is the 
release it is planned for?
https://github.com/wxWidgets/wxWidgets/commit/e9b379fe2abb579fc1c334cc3e642e66c0a5d158
 


Why is it not in earlier releases, since it’s a relatively old fix?  

Thanks,
Jeff.___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp