Re: [Kicad-developers] [PATCH/RFC] Footprint editor menu bar

2018-02-19 Thread Michael Kavanagh
Jeff, are you okay to implement these changes on top of this patch? Cheers, Michael On 19 February 2018 at 20:16, Wayne Stambaugh wrote: > I'm fine with this change. What kind of time frame are we talking > about? I can push this off to rc2 if necessary. As soon as

Re: [Kicad-developers] [PATCH/RFC] Footprint editor menu bar

2018-02-19 Thread Wayne Stambaugh
Please queue the patches up for me. I have lost track of which patches are relevant due to all of the revisions. Thanks, Wayne On 02/19/2018 06:21 PM, Jeff Young wrote: > Yep, no worries. > > @Wayne, if you want to go ahead and merge this then I can commit any > tweaks we need. > > Cheers, >

Re: [Kicad-developers] New menu structure tweaks

2018-02-19 Thread Michael Kavanagh
Minor modification. Sorry for the noise. On 19 February 2018 at 23:07, Michael Kavanagh wrote: > Here are the changes. > > Cheers, > Michael > > On 19 February 2018 at 22:42, Jon Evans wrote: >> I like keeping it shorter but TBH the exact wording

Re: [Kicad-developers] [PATCH] Use polygonal hit testing for module selection

2018-02-19 Thread Wayne Stambaugh
Jon, This looks good to me and seems to work as advertised so unless anyone else can think of a reason not to merge I will try to get it merged in the next day or so. Wayne On 02/18/2018 07:01 PM, Jon Evans wrote: > Hi Wayne, > > In my testing there is no performance impact, but more testing

Re: [Kicad-developers] New menu structure tweaks

2018-02-19 Thread Michael Kavanagh
Here are the changes. Cheers, Michael On 19 February 2018 at 22:42, Jon Evans wrote: > I like keeping it shorter but TBH the exact wording of this seems not super > important because these menu options will be gone by 6.0 with any luck... > > On Mon, Feb 19, 2018 at 5:40 PM,

Re: [Kicad-developers] [PATCH/RFC] Footprint editor menu bar

2018-02-19 Thread Jeff Young
Yep, no worries. @Wayne, if you want to go ahead and merge this then I can commit any tweaks we need. Cheers, Jeff. > On 19 Feb 2018, at 23:19, Michael Kavanagh wrote: > > ___

Re: [Kicad-developers] [PATCH/RFC] Footprint editor menu bar

2018-02-19 Thread Michael Kavanagh
Hi Wayne, Heres the first patch, just menubar and hotkey tweaks. Cheers, Michael On 19 February 2018 at 23:35, Wayne Stambaugh wrote: > Please queue the patches up for me. I have lost track of which patches > are relevant due to all of the revisions. > > Thanks, > >

Re: [Kicad-developers] [PATCH/RFC] Footprint editor menu bar

2018-02-19 Thread Jeff Young
And here’s the dialog patch: 0005-Dialog-changes-to-go-with-ModEdit-menu-update.patch Description: Binary data > On 19 Feb 2018, at 23:42, Michael Kavanagh wrote: > > Hi Wayne, > > Heres the first patch, just menubar and hotkey tweaks. > > Cheers, > Michael >

Re: [Kicad-developers] [PATCH] Pcbnew menu bar

2018-02-19 Thread Nick Østergaard
Hello Michael and Jeff, It seems like we got our first small regression from this patch series. Could you have a look. Please note it looks like it is window manager dependent. https://bugs.launchpad.net/kicad/+bug/1750494 Nick 2018-02-18 23:03 GMT+01:00 Wayne Stambaugh :

Re: [Kicad-developers] wxPython/wxWidgets compatibility check

2018-02-19 Thread Maciej Sumiński
Hi Nick, Thank you for testing the patch. I think a hint about disabling scripting is a good idea. Do you know if it is enough just to disable wxPython or rather everything scripting related should be turned off? There is a different warning when GTK3 is detected as the wxWidgets toolkit.

Re: [Kicad-developers] [PATCH/RFC] Footprint editor menu bar

2018-02-19 Thread Jeff Young
Hi Rene, Comments in-line: > On 19 Feb 2018, at 12:07, Rene Pöschl wrote: > > On 19/02/18 12:14, Jeff Young wrote: >> The Open / List All button is much faster on all libraries than it used to >> be, and it’s a bit of a step-child to Search by Keyword and Select by >>

[Kicad-developers] Bug priority proposal

2018-02-19 Thread Jeff Young
I’d like to have 5 priority levels: crash with data loss crash with no data loss high-impact with no viable workaround high-impact with workaround low-impact Right now we’re sort of lumping the last 2 into “Low”, which I find troublesome. On the other hand, we’re pretty good at reacting to the

Re: [Kicad-developers] [RFC] Change to object visibility system for usability/clarity

2018-02-19 Thread Andrzej Wolski
Patch (in attachment) for "Tracks" turned out to be very simple. If it gets accepted, I could make more of these. Andrzej On 02/19/2018 02:12 PM, Andrzej Wolski wrote: It would be also nice to have separate controls for: 1. Tracks 2. Drawing primitives (graphic lines, arcs, and circles) 3.

Re: [Kicad-developers] [PATCH/RFC] Footprint editor menu bar

2018-02-19 Thread Jeff Young
I logged https://bugs.launchpad.net/kicad/+bug/1750374 for the (non-intentional) removal of library filters. I imagine we’ll fix that in the Place Symbol browser. Since we don’t have a Place Footprint browser yet (not to be confused with the

Re: [Kicad-developers] Improving Eagle Import netlist matching

2018-02-19 Thread Maciej Sumiński
Hi Russell, I am grateful for your continuous support. I confirm your patch handles local net labels and zones in the attached example (orphanzonetest.zip) correctly, but I am still getting global labels with the Arduino project mentioned by Wayne. Reverting "Fix netlist mapping for zones and

Re: [Kicad-developers] [PATCH/RFC] Footprint editor menu bar

2018-02-19 Thread Rene Pöschl
On 19/02/18 12:14, Jeff Young wrote: The Open / List All button is much faster on all libraries than it used to be, and it’s a bit of a step-child to Search by Keyword and Select by Browser anyway. So, I’m going to propose that we add a Library selection widget to New Footprint..., Export

Re: [Kicad-developers] [PATCH/RFC] Footprint editor menu bar

2018-02-19 Thread Michael Kavanagh
On 19 February 2018 at 11:14, Jeff Young wrote: > > I was thinking we couldn’t get rid of the active library concept until we had > the tree browser in the left-hand side of the window. > > But there are actually only three clients of the active library: > The List All button

Re: [Kicad-developers] [PATCH/RFC] Footprint editor menu bar

2018-02-19 Thread Rene Pöschl
On 19/02/18 13:16, Jeff Young wrote: Hi Rene, Comments in-line: On 19 Feb 2018, at 12:07, Rene Pöschl wrote: On 19/02/18 12:14, Jeff Young wrote: The Open / List All button is much faster on all libraries than it used to be, and it’s a bit of a step-child to Search by

Re: [Kicad-developers] [PATCH/RFC] Footprint editor menu bar

2018-02-19 Thread Jeff Young
I was thinking we couldn’t get rid of the active library concept until we had the tree browser in the left-hand side of the window. But there are actually only three clients of the active library: The List All button in the Open dialog The Save action The Export Library action New

Re: [Kicad-developers] [RFC] Change to object visibility system for usability/clarity

2018-02-19 Thread Andrzej Wolski
It would be also nice to have separate controls for: 1. Tracks 2. Drawing primitives (graphic lines, arcs, and circles) 3. Zones 4. Polygons 5. Text (now there is control only for footprint text) 6. Dimensions 7. Plated holes That would make Render tab (almost) complete. Andrzej W dniu

Re: [Kicad-developers] [RFC] Change to object visibility system for usability/clarity

2018-02-19 Thread Nick Østergaard
2018-02-19 1:37 GMT+01:00 Jon Evans : > I'm going to go to the user forum with these questions too, but curious > what the devs think about this: > > In my original RFC, I proposed eliminating the different between "front" > and "back" in the Render checkboxes. > I still think

Re: [Kicad-developers] Improving Eagle Import netlist matching

2018-02-19 Thread Russell Oliver
here are the patches again after the relevant sections being uncrustified. Kind Regards Russell On Mon, Feb 19, 2018 at 3:07 AM Wayne Stambaugh wrote: > This looks a lot more reasonable to me although there may be some corner > cases that we haven't thought about but we

[Kicad-developers] New menu structure tweaks

2018-02-19 Thread Jeff Young
I’m glad we got the new menu structure in, because some of the issue will only be uncovered with a bit of use. I’ve found the first one, but I’ve got a meta-question first: Michael, do you want to do the modifications for any issues that we find? Or do you have limited bandwidth? On to the

Re: [Kicad-developers] [PATCH/RFC] Footprint editor menu bar

2018-02-19 Thread Jeff Young
Looking at this some more we already have Export Footprint... which does exactly the same thing as Save Footprint in a New Library…. So we can just ditch the later menu item. And since those appear to be the only ways to create a new library in 4.0, I suggest we leave it that way until 6.0.

Re: [Kicad-developers] [RFC] Change to object visibility system for usability/clarity

2018-02-19 Thread Jon Evans
Lots of good feedback here and on the forums. For a long time it has been on my to-do list to add "saved view schemes" like Altium and Xpedition support, which would allow you to quickly pull up sets of shown/hidden layers/objects. I still plan on working on that for 6.0. In the short term it

Re: [Kicad-developers] [RFC] Change to object visibility system for usability/clarity

2018-02-19 Thread Wayne Stambaugh
I have wanted user definable layer visibility settings since we implemented the layer manager. I would be nice if the user definable layer visibility settings could be named and added to the layer manager for easy access. On 2/19/2018 12:16 PM, Jon Evans wrote: > Lots of good feedback here and

Re: [Kicad-developers] [PATCH/RFC] Footprint editor menu bar

2018-02-19 Thread Wayne Stambaugh
This is starting to blur the line between bug fixing and bike shedding. I have no great fondness for the current library metaphor either but we are talking about making significant changes in the way the footprint library editor works. I really don't want to make too many changes here because we

Re: [Kicad-developers] [PATCH/RFC] Footprint editor menu bar

2018-02-19 Thread Jeff Young
Understood, Wayne. However, in the last proposal the only change other than menus is to add a Library selector to the New Footprint dialog. Cheers, Jeff. > On 19 Feb 2018, at 17:39, Wayne Stambaugh wrote: > > This is starting to blur the line between bug fixing and

Re: [Kicad-developers] [PATCH/RFC] Footprint editor menu bar

2018-02-19 Thread Michael Kavanagh
For a stop gap until the symbol editor style footprint editor, how about the attached? We maintain the concept of "active library", just group the options better. On a side note Jeff, would you mind helping out with a dialog change similar to with the Pcbnew one? Move the icon scale slider from

Re: [Kicad-developers] [RFC] Change to object visibility system for usability/clarity

2018-02-19 Thread Eeli Kaikkonen
It's been difficult to follow the discussion, and the subject matter and problems related to it are complex. If only minimal changes are done now I want to propose two easy things (which may have been mentioned before, but I didn't find them): 1. The Render items seem to be in a random order, at

Re: [Kicad-developers] New menu structure tweaks

2018-02-19 Thread Michael Kavanagh
On 19 February 2018 at 12:26, Jeff Young wrote: > I’m glad we got the new menu structure in, because some of the issue will > only be uncovered with a bit of use. > > I’ve found the first one, but I’ve got a meta-question first: > > Michael, do you want to do the modifications

Re: [Kicad-developers] [RFC] Change to object visibility system for usability/clarity

2018-02-19 Thread Jon Evans
1. Agree, I will try to do this 2. I will see if there is an easy grouping. I don't want to make sweeping UI changes this close to the release. I also think it would be good to be able to show plated holes in the copper layer color somehow. I will think about easy ways to do this. On Mon, Feb

Re: [Kicad-developers] [PATCH/RFC] Footprint editor menu bar

2018-02-19 Thread Jeff Young
Hi Michael, Yes, those menus look like a good starting point with one reservation: the canvas items need the same promotion and wording changes as the pcbnew ones. I should have the dialog stuff later today. Cheers, Jeff. > On 19 Feb 2018, at 18:11, Michael Kavanagh

Re: [Kicad-developers] wxPython/wxWidgets compatibility check

2018-02-19 Thread Nick Østergaard
Hello Maciej, I just tested your patch on archlinux. It does not seem to work properly, tested in a clean build dir. Even if I remove wxpython (with gtk3) and install wxpython-gtk2 (with gtk2 from AUR) it still complains that there is a mismatch. I have wxwidgets with gtk2 and gtk3 installed,

Re: [Kicad-developers] Version naming scheme

2018-02-19 Thread Eeli Kaikkonen
Thanks, that's great. I just had the impression that there would be more changes after an RC release. In that case "beta" would have been more realistic and the first RC could have been released a bit later. Another thing, which also doesn't have to affect in any way but which I anticipate, is

Re: [Kicad-developers] Version naming scheme

2018-02-19 Thread Jeff Young
That Wikipedia page is defining the waterfall methodology life cycle. KiCad is somewhere in between waterfall and agile methodology. https://en.wikipedia.org/wiki/Software_development_process Cheers, Jeff. > On 19 Feb 2018, at

Re: [Kicad-developers] wxPython/wxWidgets compatibility check

2018-02-19 Thread Nick Østergaard
Ok, I just tried to do: In [3]: wx.version() Out[3]: '4.0.1 gtk3 (phoenix)' I clearly also have python2-wxpython-phoenix installed. I just tried to remove that from my system. Now it seems to complete the cmake configure successfully. I guess the patch works afterall :D But I have a comment.

Re: [Kicad-developers] Bug priority proposal

2018-02-19 Thread Wayne Stambaugh
The problem with this is interpretation. One man's important is another man's don't care. The other issue is that there is no way to prevent anyone for changing the severity level any time they want. It would be nice if we could restrict who sets the bug severity level to the kicad-bug-squad

[Kicad-developers] Version naming scheme

2018-02-19 Thread Eeli Kaikkonen
I'm not a KiCad developer, nor do I know much about its history or developers, so I don't have any kind of authority here, but I feel I have to talk about the version names. Now is probably the last possible time to draw attention to it because "RC1" is around the corner.

Re: [Kicad-developers] New menu structure tweaks

2018-02-19 Thread Jeff Young
No worries, Michael. I can even do the canvas selection changes if you want me to. Cheers, Jeff. > On 19 Feb 2018, at 18:21, Michael Kavanagh wrote: > > On 19 February 2018 at 12:26, Jeff Young wrote: >> I’m glad we got the new menu structure in,

Re: [Kicad-developers] Version naming scheme

2018-02-19 Thread Wayne Stambaugh
I think we are using rc in the correct context here. Our alpha and beta testing is completely open and continuous thanks to our nightly builds. We are in feature freeze so no new feature code is being added to KiCad. We are in the process of cleaning up a final few bugs before rc1. If no bugs

Re: [Kicad-developers] [PATCH/RFC] Footprint editor menu bar

2018-02-19 Thread Wayne Stambaugh
I'm fine with this change. What kind of time frame are we talking about? I can push this off to rc2 if necessary. As soon as Orson pushes his Eagle label fix, I'm going branch v5 and tag rc1. Whatever is left will have to go into rc2. I'm also going to push the UI string freeze to rc2 since

Re: [Kicad-developers] [PATCH/RFC] Footprint editor menu bar

2018-02-19 Thread Jeff Young
Here’s the dialog stuff to go with them: 0007-Dialog-changes-to-go-with-ModEdit-menu-update.patch Description: Binary data On 19 Feb 2018, at 20:16, Wayne Stambaugh wrote:I'm fine with this change.  What kind of time frame are we talkingabout?  I can push this off to rc2 if

Re: [Kicad-developers] [PATCH/RFC] Footprint editor menu bar

2018-02-19 Thread Michael Kavanagh
Final patch attached. Added Footprint Viewer to View menu (need to include this in the Pcbnew menubar update) Also added Tools menu with some items I just found on the horizontal toolbar: Update Footprint on PCB Insert Footprint on PCB - Delete a Footprint in

Re: [Kicad-developers] Improving Eagle Import netlist matching

2018-02-19 Thread Russell Oliver
Hi Orson, I wasn't sure about using the KiMail, since I didn't know how immediate those calls are processed plus I didn't have the time to implement it using that anyway. I'm a bit puzzled by the statement that you are getting global labels using the Arduino project. Can you send me your copy of

Re: [Kicad-developers] [RFC] Change to object visibility system for usability/clarity

2018-02-19 Thread Andrzej Wolski
It would also be great to see all the holes like in a drill file Something like this? :) http://bit.ly/2ojZEq7 Cheers, ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe :

Re: [Kicad-developers] New menu structure tweaks

2018-02-19 Thread Jon Evans
I like keeping it shorter but TBH the exact wording of this seems not super important because these menu options will be gone by 6.0 with any luck... On Mon, Feb 19, 2018 at 5:40 PM, Michael Kavanagh < mich...@michaelkavanagh.me> wrote: > I'm doing them now. Can I suggest we use "Modern Toolset

Re: [Kicad-developers] Improving Eagle Import netlist matching

2018-02-19 Thread Maciej Suminski
Hi Russell, On 02/19/2018 08:25 PM, Russell Oliver wrote: > Hi Orson, > > I wasn't sure about using the KiMail, since I didn't know how immediate > those calls are processed plus I didn't have the time to implement it using > that anyway. That is fine, no problem. I realize it takes more time

Re: [Kicad-developers] [RFC] Change to object visibility system for usability/clarity

2018-02-19 Thread Eeli Kaikkonen
Pretty much, looks great :) BTW, I remembered still one little thing: Through Hole Pads and Non Plated Holes tooltips aren't in line with what they actually do; it's like someone who wrote the texts had a different kind of action in mind. Now it looks like that if it's checked, the rendering