bump
I've updated my patch to be much better/cleaner. Attached patch is the same
as in my previous, confusing perhaps, mail.
:-)
Miles
On Thu, Mar 22, 2018 at 10:33 PM, miles mccoo wrote:
> resend, this time to the list and not just to Wayne. Keep forgetting that
> the
Hey Adam,
According to the latest cmake (3.11) docs[1], CheckCXXSymbolExists.cmake
still contains a CHECK_SYMBOL_EXISTS command. This has been around for
a really long time, I'm not sure why you would be having issues with
this now unless you have a broken cmake install.
Wayne
On 3/30/2018
Yikes. That’s probably beyond a couple of help strings in the UI. Perhaps
I’ll just de-emphasize the multiple-models part of it for users who don’t need
this.
Thanks for the explanation.
Cheers,
Jeff.
> On 30 Mar 2018, at 23:13, Nick Østergaard wrote:
>
> Den lør. 31.
Den lør. 31. mar. 2018 00.02 skrev Jeff Young :
> A footprint can have several 3D models associated with it (confusingly
> named 3D Shape Names in the dialog, but never mind that).
>
> What is the purpose of this?
>
> Is it so that library devs can add different formats and the
Hi folks!
Normally I wouldn't ask this question on the list, but it's at or past
crunch time on the new macOS packaging, so please forgive me.
I have a macOS 10.11 system I use for KiCad packaging sometimes, and
I'm running some tests on it. It has cmake 3.11.0 on it.
8 days ago, I was able to
I'm using 3.10 so that's why I haven't seen this yet. I guess we are
going to have to fix this. It's would be nice if the cmake folks would
have at least provided a substitution and a warning rather than break
everybody's configuration who uses CHECK_SYMBOL_EXISTS.
On 3/30/2018 5:15 PM, Seth
Yeah, I wholeheartedly agree. The file hasn't been touched in years,
but the issue persisted after a clean. Good thing I can abandon this
machine soon :)
I'll keep an eye on it, but if it doesn't happen again, /shrug.
Adam
On Fri, Mar 30, 2018 at 3:24 PM, Wayne Stambaugh
A footprint can have several 3D models associated with it (confusingly named 3D
Shape Names in the dialog, but never mind that).
What is the purpose of this?
Is it so that library devs can add different formats and the renderer will
choose the first it has a plugin for?
If so, we need to say
Hi Adam-
You will need to downgrade to CMake 3.10 or lower. In 3.11, they revised
the internals of CheckSymbolExists.
Our macro depends on the internal CMake macro _CHECK_SYMBOL_EXISTS (note
the underscore at the beginning). In 3.11, they replaced it with
__CHECK_SYMBOL_EXISTS_IMPL.
-S
do they really need to if its an “internal” cmake macro
> On 31/03/2018, at 10:24 AM, Wayne Stambaugh wrote:
>
> I'm using 3.10 so that's why I haven't seen this yet. I guess we are
> going to have to fix this. It's would be nice if the cmake folks would
> have at least
We use this in CheckCXXSymbolExists and Cmake has provided this function
since 2.8.6.
I've removed the repository copy of this macro to allow Cmake to use its
own. This should be safe as we have already set a minimum Cmake version of
2.8.12.
Let me know if you still have this issue, Adam.
-S
Sending via the correct email address...
-- Forwarded message --
From: Adam Wolf
Date: Fri, Mar 30, 2018 at 8:59 PM
Subject: Re: [Kicad-developers] _CHECK_SYMBOL_EXISTS?
To: Seth Hillbrand
Cc: Wayne Stambaugh
Hi Russell-
Will you have time to update this patch? If not, I'm happy to revise it to
handle the cases this weekend. We're getting close to rc2 and I'd like to
get your fix in before it is released.
Best-
Seth
2018-03-27 13:12 GMT-07:00 Seth Hillbrand :
> Hi
13 matches
Mail list logo